GNU bug report logs - #27907
[PATCH] graph: Provide access to the package record in the emit

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Roel Janssen <roel <at> gnu.org>
Subject: bug#27907: closed (Re: [bug#27907] [PATCH] graph: Provide access
 to the package record in the emit)
Date: Tue, 01 Aug 2017 22:49:04 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#27907: [PATCH] graph:  Provide access to the package record in the emit

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 27907 <at> debbugs.gnu.org.

-- 
27907: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27907
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 27907-done <at> debbugs.gnu.org
Subject: Re: [bug#27907] [PATCH] graph: Provide access to the package record
 in the emit
Date: Wed, 02 Aug 2017 00:47:53 +0200

Ludovic Courtès writes:

> Roel Janssen <roel <at> gnu.org> skribis:
>
>> I would like to expand the Cypher back-end and in the long run add a
>> SPARQL graph back-end to GNU Guix.  For this, I will need to have access
>> to the package records inside the emit-* functions.
>>
>> This patch makes this change by essentially changing the "label"
>> parameter of the emit-* functions passed as "(node-label head)" into a
>> "node" parameter, passed as "head".
>>
>> The rest of the patch adapts the current emit-* functions to this
>> change.
>>
>> I tested the Graphviz, D3js, and Cypher back-ends, and all seem to work
>> as before.
>>
>> Is it OK to apply this change?
>
> Sure, looks good to me!
>
> Ludo’.

Thanks! I pushed this patch.

Kind regards,
Roel Janssen

[Message part 3 (message/rfc822, inline)]

From: Roel Janssen <roel <at> gnu.org>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] graph:  Provide access to the package record in the emit
Date: Tue, 01 Aug 2017 16:40:05 +0200

[0001-graph-Provide-access-to-the-package-record-in-the-em.patch (text/x-diff, attachment)]

[Message part 5 (text/plain, inline)]

Dear Guix,

I would like to expand the Cypher back-end and in the long run add a
SPARQL graph back-end to GNU Guix.  For this, I will need to have access
to the package records inside the emit-* functions.

This patch makes this change by essentially changing the "label"
parameter of the emit-* functions passed as "(node-label head)" into a
"node" parameter, passed as "head".

The rest of the patch adapts the current emit-* functions to this
change.

I tested the Graphviz, D3js, and Cypher back-ends, and all seem to work
as before.

Is it OK to apply this change?

Kind regards,
Roel Janssen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.