GNU bug report logs - #27616
[PATCH] gnu: you-get: Update to 0.4.775.

Previous Next

Full log

Message #8 received at 27616 <at> debbugs.gnu.org (full text, mbox):

From: Ben Woodcroft <b.woodcroft <at> uq.edu.au>
To: Feng Shu <tumashu <at> 163.com>, 27616 <at> debbugs.gnu.org
Subject: Re: [bug#27616] [PATCH] gnu: you-get: Update to 0.4.775.
Date: Sat, 8 Jul 2017 22:37:13 +1000

[Message part 1 (text/plain, inline)]

Hi Feng, thanks for the patch.


On 08/07/17 21:53, Feng Shu wrote:
> -    (version "0.4.715")
> +    (version "0.4.775")
>       (source (origin
>                 (method url-fetch)
>                 (uri (string-append
> -"https://github.com/soimort/you-get/releases/download/v"
> -                    version "/you-get-" version ".tar.gz"))
> +"https://github.com/soimort/you-get/archive/v"
> +                    version ".tar.gz"))
Here, the downloaded filename is "v0.4.775.tar.gz", which doesn't 
contain "you-get" anymore (we prefer it does so the base directory 
doesn't fill with opaque names, and this is checked by 'guix lint'). We 
usually fix this by adding

(file-name (string-append name "-" version ".tar.gz"))

to the package definition. However, is there some reason why the URL 
scheme should be changed? Alternatively, we could also source this 
package from PyPI given that is recommended on the you-get website. WDYT?

Thanks, ben.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.