GNU bug report logs - #27616
[PATCH] gnu: you-get: Update to 0.4.775.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27616 in the body.
You can then email your comments to 27616 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Feng Shu" <tumashu <at> 163.com>
To: guix-patches <guix-patches <at> gnu.org>
Cc: Feng Shu <tumashu <at> 163.com>
Subject: [PATCH] gnu: you-get: Update to 0.4.775.
Date: Sat, 08 Jul 2017 19:53:42 +0800

[0001-gnu-you-get-Update-to-0.4.775.patch (text/x-patch, inline)]

From 395e96f467038358e86d0e3d970055ed7dfce2ba Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu <at> 163.com>
Date: Sat, 8 Jul 2017 19:43:13 +0800
Subject: [PATCH] gnu: you-get: Update to 0.4.775.

* gnu/packages/video.scm (you-get): Update to 0.4.775.
---
 gnu/packages/video.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index a98a1aa3c..66fce5847 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1238,15 +1238,15 @@ other site that youtube-dl supports.")
 (define-public you-get
   (package
     (name "you-get")
-    (version "0.4.715")
+    (version "0.4.775")
     (source (origin
               (method url-fetch)
               (uri (string-append
-                    "https://github.com/soimort/you-get/releases/download/v"
-                    version "/you-get-" version ".tar.gz"))
+                    "https://github.com/soimort/you-get/archive/v"
+                    version ".tar.gz"))
               (sha256
                (base32
-                "043122hfh56fbbszp1kwd1f65asgyn60j1ijday93hf2dkhvbrnh"))))
+                "1pjjv42c9bysnj8s3c6v0g6b00lr7b21y8ypibnzd6z0jxlsq7sz"))))
     (build-system python-build-system)
     (arguments
      ;; no tests
-- 
2.13.2

[Message part 2 (text/plain, inline)]

-- 

Message #8 received at 27616 <at> debbugs.gnu.org (full text, mbox):

From: Ben Woodcroft <b.woodcroft <at> uq.edu.au>
To: Feng Shu <tumashu <at> 163.com>, 27616 <at> debbugs.gnu.org
Subject: Re: [bug#27616] [PATCH] gnu: you-get: Update to 0.4.775.
Date: Sat, 8 Jul 2017 22:37:13 +1000

[Message part 1 (text/plain, inline)]

Hi Feng, thanks for the patch.


On 08/07/17 21:53, Feng Shu wrote:
> -    (version "0.4.715")
> +    (version "0.4.775")
>       (source (origin
>                 (method url-fetch)
>                 (uri (string-append
> -"https://github.com/soimort/you-get/releases/download/v"
> -                    version "/you-get-" version ".tar.gz"))
> +"https://github.com/soimort/you-get/archive/v"
> +                    version ".tar.gz"))
Here, the downloaded filename is "v0.4.775.tar.gz", which doesn't 
contain "you-get" anymore (we prefer it does so the base directory 
doesn't fill with opaque names, and this is checked by 'guix lint'). We 
usually fix this by adding

(file-name (string-append name "-" version ".tar.gz"))

to the package definition. However, is there some reason why the URL 
scheme should be changed? Alternatively, we could also source this 
package from PyPI given that is recommended on the you-get website. WDYT?

Thanks, ben.

[Message part 2 (text/html, inline)]

Message #11 received at 27616 <at> debbugs.gnu.org (full text, mbox):

From: "Feng Shu" <tumashu <at> 163.com>
To: 27616 <at> debbugs.gnu.org
Cc: Feng Shu <tumashu <at> 163.com>
Subject: Update you-get patch, add file-name
Date: Sat, 08 Jul 2017 21:13:25 +0800

[Message part 1 (text/plain, inline)]

Update patch, add file-name

[0001-gnu-you-get-Update-to-0.4.775.patch (text/x-patch, inline)]

From 544d4b3f8d8f0c5595fba083b6aaf33ebd4d7bda Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu <at> 163.com>
Date: Sat, 8 Jul 2017 19:43:13 +0800
Subject: [PATCH] gnu: you-get: Update to 0.4.775.

* gnu/packages/video.scm (you-get): Update to 0.4.775.
---
 gnu/packages/video.scm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index a98a1aa3c..b90534b4c 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1238,15 +1238,16 @@ other site that youtube-dl supports.")
 (define-public you-get
   (package
     (name "you-get")
-    (version "0.4.715")
+    (version "0.4.775")
     (source (origin
               (method url-fetch)
               (uri (string-append
-                    "https://github.com/soimort/you-get/releases/download/v"
-                    version "/you-get-" version ".tar.gz"))
+                    "https://github.com/soimort/you-get/archive/v"
+                    version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
               (sha256
                (base32
-                "043122hfh56fbbszp1kwd1f65asgyn60j1ijday93hf2dkhvbrnh"))))
+                "1pjjv42c9bysnj8s3c6v0g6b00lr7b21y8ypibnzd6z0jxlsq7sz"))))
     (build-system python-build-system)
     (arguments
      ;; no tests
-- 
2.13.2

[Message part 3 (text/plain, inline)]

-- 

Message #16 received at 27616-done <at> debbugs.gnu.org (full text, mbox):

From: Ben Woodcroft <b.woodcroft <at> uq.edu.au>
To: Feng Shu <tumashu <at> 163.com>, 27616-done <at> debbugs.gnu.org
Subject: Re: [bug#27616] Update you-get patch, add file-name
Date: Sun, 9 Jul 2017 21:32:08 +1000

On 08/07/17 23:13, Feng Shu wrote:
> Update patch, add file-name
Thanks, pushed as e2155f58c0b670f495da4a3a0308d5054cf060b0.
ben

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.