GNU bug report logs - #27617
26.0.50; cl--random-state initialized to old-style vector

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27617 in the body.
You can then email your comments to 27617 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Wellons <wellons <at> nullprogram.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; cl--random-state initialized to old-style vector
Date: Sat, 8 Jul 2017 09:39:18 -0400

The global variable cl--random-state is still being initialized to the 
old defstruct vector format. See lisp/emacs-lisp/cl-lib.el:296. This 
breaks all random number functions when the STATE argument isn't 
supplied:

   $ emacs -Q --batch -l cl-lib --eval '(cl-random 10)'
   Wrong type argument: cl--random-state, [cl--random-state-tag -1 30 ...]

Message #10 received at 27617 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Wellons <wellons <at> nullprogram.com>
To: 27617 <at> debbugs.gnu.org
Subject: [PATCH] Fix cl--random-state initialization.
Date: Mon, 10 Jul 2017 14:56:46 -0400

Here's a trivial patch that fixes this bug.

---
  lisp/emacs-lisp/cl-lib.el | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/cl-lib.el b/lisp/emacs-lisp/cl-lib.el
index 936c852526c..ea47a0562ee 100644
--- a/lisp/emacs-lisp/cl-lib.el
+++ b/lisp/emacs-lisp/cl-lib.el
@@ -294,7 +294,7 @@ cl--random-time
      v))
  
  (defvar cl--random-state
-  (vector 'cl--random-state-tag -1 30 (cl--random-time)))
+  (record 'cl--random-state -1 30 (cl--random-time)))
  
  (defconst cl-most-positive-float nil
    "The largest value that a Lisp float can hold.
-- 
2.11.0

Message #15 received at 27617-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Christopher Wellons <wellons <at> nullprogram.com>
Cc: 27617-done <at> debbugs.gnu.org
Subject: Re: 26.0.50; cl--random-state initialized to old-style vector
Date: Fri, 14 Jul 2017 02:50:40 -0700

[Message part 1 (text/plain, inline)]

Thanks for reporting that. I installed the attached, which differs from what you 
suggested but should also work.

[0001-Remove-duplicate-cl-random-state-definition.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.