GNU bug report logs - #26795
gnu: emacs-ag: Propagate the-silver-searcher.

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Clément Lassieur <clement <at> lassieur.org>
Cc: Christopher Baines <mail <at> cbaines.net>, 26795 <at> debbugs.gnu.org
Subject: bug#26795: gnu: emacs-ag: Propagate the-silver-searcher.
Date: Sat, 06 May 2017 16:05:32 +0200

Hello Clément,

Clément Lassieur <clement <at> lassieur.org> skribis:

> emacs-ag is mostly unusable via Tramp (except if the
> 'the-silver-searcher' store element is also in the remote system, which
> will never happen if the remote system is not running Guix).
>
> I believe 'the-silver-searcher' should be propagated, and the executable
> should be 'ag' (which is the default value) instead of
> '/gnu/store/...-the-silver-searcher-1.0.2/bin/ag', so that it can be
> found on remote systems.

That makes sense to me.  Christopher Baines wrote it; WDYT Chris?

> This allows emacs-ag to be used on remote systems.
>
> * gnu/packages/emacs.scm (emacs-ag)[inputs]: Remove.  Move THE-SILVER-SEARCHER
> to...
> [propagated-inputs]: ... here.
> [arguments]: Remove 'patch-exec-paths' phase.

[...]

>      (propagated-inputs
>       `(("dash" ,emacs-dash)
> -       ("s" ,emacs-s)))
> +       ("s" ,emacs-s)
> +       ("the-silver-searcher" ,the-silver-searcher)))

I’d suggest writing the rationale for propagation in a comment above.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.