GNU bug report logs - #26795
gnu: emacs-ag: Propagate the-silver-searcher.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26795 in the body.
You can then email your comments to 26795 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: guix-patches <at> gnu.org
Subject: gnu: emacs-ag: Propagate the-silver-searcher.
Date: Sat, 06 May 2017 11:04:22 +0200

Hi,

emacs-ag is mostly unusable via Tramp (except if the
'the-silver-searcher' store element is also in the remote system, which
will never happen if the remote system is not running Guix).

I believe 'the-silver-searcher' should be propagated, and the executable
should be 'ag' (which is the default value) instead of
'/gnu/store/...-the-silver-searcher-1.0.2/bin/ag', so that it can be
found on remote systems.

Message #8 received at 26795 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: 26795 <at> debbugs.gnu.org
Subject: [PATCH] gnu: emacs-ag: Propagate the-silver-searcher.
Date: Sat,  6 May 2017 11:07:28 +0200

This allows emacs-ag to be used on remote systems.

* gnu/packages/emacs.scm (emacs-ag)[inputs]: Remove.  Move THE-SILVER-SEARCHER
to...
[propagated-inputs]: ... here.
[arguments]: Remove 'patch-exec-paths' phase.
---
 gnu/packages/emacs.scm | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 74f0ff8b5..3ba5fe102 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1125,13 +1125,6 @@ than @code{electric-indent-mode}.")
     (arguments
      `(#:phases
        (modify-phases %standard-phases
-         (add-before 'install 'patch-exec-paths
-           (lambda* (#:key inputs #:allow-other-keys)
-             (emacs-substitute-variables "ag.el"
-               ("ag-executable"
-                (string-append (assoc-ref inputs "the-silver-searcher")
-                               "/bin/ag")))
-             #t))
          (add-before 'install 'make-info
            (lambda _
              (with-directory-excursion "docs"
@@ -1142,14 +1135,13 @@ than @code{electric-indent-mode}.")
                     (info (string-append out "/share/info")))
                (install-file "docs/_build/texinfo/agel.info" info)
                #t))))))
-    (inputs
-     `(("the-silver-searcher" ,the-silver-searcher)))
     (native-inputs
      `(("python-sphinx" ,python-sphinx)
        ("texinfo" ,texinfo)))
     (propagated-inputs
      `(("dash" ,emacs-dash)
-       ("s" ,emacs-s)))
+       ("s" ,emacs-s)
+       ("the-silver-searcher" ,the-silver-searcher)))
     (home-page "https://github.com/Wilfred/ag.el")
     (synopsis "Front-end for ag (the-silver-searcher) for Emacs")
     (description "This package provides the ability to use the silver
-- 
2.12.2

Message #11 received at 26795 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Clément Lassieur <clement <at> lassieur.org>
Cc: Christopher Baines <mail <at> cbaines.net>, 26795 <at> debbugs.gnu.org
Subject: Re: bug#26795: gnu: emacs-ag: Propagate the-silver-searcher.
Date: Sat, 06 May 2017 16:05:32 +0200

Hello Clément,

Clément Lassieur <clement <at> lassieur.org> skribis:

> emacs-ag is mostly unusable via Tramp (except if the
> 'the-silver-searcher' store element is also in the remote system, which
> will never happen if the remote system is not running Guix).
>
> I believe 'the-silver-searcher' should be propagated, and the executable
> should be 'ag' (which is the default value) instead of
> '/gnu/store/...-the-silver-searcher-1.0.2/bin/ag', so that it can be
> found on remote systems.

That makes sense to me.  Christopher Baines wrote it; WDYT Chris?

> This allows emacs-ag to be used on remote systems.
>
> * gnu/packages/emacs.scm (emacs-ag)[inputs]: Remove.  Move THE-SILVER-SEARCHER
> to...
> [propagated-inputs]: ... here.
> [arguments]: Remove 'patch-exec-paths' phase.

[...]

>      (propagated-inputs
>       `(("dash" ,emacs-dash)
> -       ("s" ,emacs-s)))
> +       ("s" ,emacs-s)
> +       ("the-silver-searcher" ,the-silver-searcher)))

I’d suggest writing the rationale for propagation in a comment above.

Thanks,
Ludo’.

Message #14 received at 26795 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>, Clément Lassieur <clement <at> lassieur.org>
Cc: 26795 <at> debbugs.gnu.org
Subject: Re: bug#26795: gnu: emacs-ag: Propagate the-silver-searcher.
Date: Thu, 11 May 2017 18:44:03 +0200

Hi Clément & Ludo,

I also ran into the same issue. With Ludo's comment below addressed,
it's ok for me !

> I’d suggest writing the rationale for propagation in a comment above.

Thanks,

Mathieu

Message #19 received at 26795-done <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 26795-done <at> debbugs.gnu.org
Subject: Re: bug#26795: gnu: emacs-ag: Propagate the-silver-searcher.
Date: Fri, 12 May 2017 10:42:45 +0200

Mathieu Othacehe <m.othacehe <at> gmail.com> writes:

> Hi Clément & Ludo,
>
> I also ran into the same issue. With Ludo's comment below addressed,
> it's ok for me !
>
>> I’d suggest writing the rationale for propagation in a comment above.

Ok I pushed then, with the comment.  Thanks for the review :-)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.