GNU bug report logs - #26342
[PATCH] gnu: emacs-elfeed: Enable tests.

Previous Next

Full log

Message #11 received at 26342 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26342 <at> debbugs.gnu.org
Subject: Re: bug#26342: [PATCH] gnu: emacs-elfeed: Enable tests.
Date: Mon, 03 Apr 2017 00:27:43 +0530

Kei Kebreau writes:

> Arun Isaac <arunisaac <at> systemreboot.net> writes:
>
>> * gnu/packages/emacs.scm (emacs-elfeed)[arguments]: Add a 'check' phase.
>> ---
>>  gnu/packages/emacs.scm | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index cb2792f63..1091e562a 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -3100,6 +3100,15 @@ If you want to mark a folder manually as a project just create an empty
>>                 (base32
>>                  "145glas04zd0s2rmnif46vhyijs4z03v871gfp1dcrwxvvvns8ap"))))
>>      (build-system emacs-build-system)
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'install 'check
>> +           (lambda _
>> +             (zero? (system* "emacs" "--batch" "--eval" "(add-to-list 'load-path \".\")"
>> +                             "--eval" "(add-to-list 'load-path \"./tests\")"
>> +                             "-l" "tests/elfeed-tests.el"
>> +                             "-f" "ert-run-tests-batch-and-exit")))))))
>>      (home-page "https://github.com/skeeto/elfeed")
>>      (synopsis "Atom/RSS feed reader for Emacs")
>>      (description
>
> Thanks for the patch! I checked out elfeed's makefile and it turns out
> this patch can be made even simpler by just calling (zero? (system* "make"
> "test")). Could you do that and sumbit the new patch?

Ah, I missed the Makefile. I'll submit a new patch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.