GNU bug report logs - #26343
[PATCH] gnu: audacity: Update to 2.1.3.

Previous Next

Package: guix-patches;

Reported by: Kei Kebreau <kei <at> openmailbox.org>

Date: Sun, 2 Apr 2017 15:53:02 UTC

Severity: normal

Tags: patch

Done: Kei Kebreau <kei <at> openmailbox.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26343 in the body.
You can then email your comments to 26343 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#26343; Package guix-patches. (Sun, 02 Apr 2017 15:53:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Kei Kebreau <kei <at> openmailbox.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 02 Apr 2017 15:53:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kei <at> openmailbox.org>
Subject: [PATCH] gnu: audacity: Update to 2.1.3.
Date: Sun,  2 Apr 2017 11:52:11 -0400
* gnu/packages/audacity.scm (audacity): Update to 2.1.3.
[source]: Fetch gzipped tar archive instead of a zip archive; add
snippet to remove time-dependent code; remove unnecessary patch.
[native-inputs]: Add autoconf, automake and libtool.
[arguments]: Add autoreconf phase to detect system libraries.
* gnu/packages/patches/audacity-fix-ffmpeg-binding.patch: Delete patch.
* gnu/local.mk: Remove reference to removed patch.
---
 gnu/local.mk                                       |  1 -
 gnu/packages/audacity.scm                          | 25 +++++++++++++----
 .../patches/audacity-fix-ffmpeg-binding.patch      | 32 ----------------------
 3 files changed, 20 insertions(+), 38 deletions(-)
 delete mode 100644 gnu/packages/patches/audacity-fix-ffmpeg-binding.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index 68f561e95..f03f50855 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -494,7 +494,6 @@ dist_patch_DATA =						\
   %D%/packages/patches/ath9k-htc-firmware-binutils.patch	\
   %D%/packages/patches/ath9k-htc-firmware-gcc.patch		\
   %D%/packages/patches/ath9k-htc-firmware-objcopy.patch		\
-  %D%/packages/patches/audacity-fix-ffmpeg-binding.patch	\
   %D%/packages/patches/automake-skip-amhello-tests.patch	\
   %D%/packages/patches/automake-regexp-syntax.patch		\
   %D%/packages/patches/automake-test-gzip-warning.patch		\
diff --git a/gnu/packages/audacity.scm b/gnu/packages/audacity.scm
index a70d0e3a6..a4ac2a6ff 100644
--- a/gnu/packages/audacity.scm
+++ b/gnu/packages/audacity.scm
@@ -23,6 +23,7 @@
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages)
   #:use-module (gnu packages audio)
+  #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages gtk)
@@ -39,15 +40,20 @@
 (define-public audacity
   (package
     (name "audacity")
-    (version "2.1.2")
+    (version "2.1.3")
     (source
      (origin
        (method url-fetch)
        (uri (string-append "https://github.com/audacity/audacity/archive"
-                           "/Audacity-" version ".zip"))
+                           "/Audacity-" version ".tar.gz"))
        (sha256
-        (base32 "1642i9d5cdmqzj6r0qdl2ldnqsvpb08znnczncysi72x6zpvb5qq"))
-       (patches (search-patches "audacity-fix-ffmpeg-binding.patch"))))
+        (base32 "11mx7gb4dbqrgfp7hm0154x3m76ddnmhf2675q5zkxn7jc5qfc6b"))
+       ;; Replace time-dependent strings.
+       (modules '((guix build utils)))
+       (snippet
+        '(substitute* "src/AboutDialog.cpp"
+           (("__DATE__") "\"2017\"")
+           (("__TIME__") "\"00:00\"")))))
     (build-system gnu-build-system)
     (inputs
      ;; TODO: Add portSMF and libwidgetextra once they're packaged.  In-tree
@@ -73,7 +79,10 @@
        ("lilv" ,lilv)
        ("portaudio" ,portaudio)))
     (native-inputs
-     `(("gettext" ,gettext-minimal)     ;for msgfmt
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("gettext" ,gettext-minimal)     ;for msgfmt
+       ("libtool" ,libtool)
        ("pkg-config" ,pkg-config)
        ("python" ,python-2)
        ("which" ,which)))
@@ -90,6 +99,12 @@
           (string-append "ID3TAG_LIBS=-L" libid3tag "/lib -lid3tag -lz")
           (string-append "LIBMAD_CFLAGS=-I" libmad "/include")
           (string-append "LIBMAD_LIBS=-L" libmad "/lib -lmad")))
+       #:phases
+       (modify-phases %standard-phases
+         ;; Ensure the usage of system libraries.
+         (add-before 'configure 'autoreconf
+           (lambda _
+             (zero? (system* "autoreconf" "-vfi")))))
        ;; The test suite is not "well exercised" according to the developers,
        ;; and fails with various errors.  See
        ;; <http://sourceforge.net/p/audacity/mailman/message/33524292/>.
diff --git a/gnu/packages/patches/audacity-fix-ffmpeg-binding.patch b/gnu/packages/patches/audacity-fix-ffmpeg-binding.patch
deleted file mode 100644
index d6d65338d..000000000
--- a/gnu/packages/patches/audacity-fix-ffmpeg-binding.patch
+++ /dev/null
@@ -1,32 +0,0 @@
-This resolves some "declaration of C function conflicts with previous
-declaration" errors during compilation.
-
---- a/src/FFmpeg.h	2015-02-21 00:33:33.853857529 +0100
-+++ b/src/FFmpeg.h	2015-02-21 00:35:09.626497205 +0100
-@@ -688,7 +688,7 @@
-    FFMPEG_FUNCTION_WITH_RETURN(
-       AVOutputFormat*,
-       av_oformat_next,
--      (AVOutputFormat *f),
-+      (const AVOutputFormat *f),
-       (f)
-    );
-    FFMPEG_FUNCTION_WITH_RETURN(
-@@ -755,7 +755,7 @@
-    FFMPEG_FUNCTION_WITH_RETURN(
-       int,
-       av_fifo_size,
--      (AVFifoBuffer *f),
-+      (const AVFifoBuffer *f),
-       (f)
-    );
-    FFMPEG_FUNCTION_WITH_RETURN(
-@@ -801,7 +801,7 @@
-    FFMPEG_FUNCTION_WITH_RETURN(
-       AVDictionaryEntry *,
-       av_dict_get,
--      (AVDictionary *m, const char *key, const AVDictionaryEntry *prev, int flags),
-+      (const AVDictionary *m, const char *key, const AVDictionaryEntry *prev, int flags),
-       (m, key, prev, flags)
-    );
-    FFMPEG_FUNCTION_WITH_RETURN(
-- 
2.12.2





Information forwarded to guix-patches <at> gnu.org:
bug#26343; Package guix-patches. (Sun, 02 Apr 2017 22:04:01 GMT) Full text and rfc822 format available.

Message #8 received at 26343 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Kei Kebreau <kei <at> openmailbox.org>, 26343 <at> debbugs.gnu.org
Cc: Kei Kebreau <kei <at> openmailbox.org>
Subject: Re: bug#26343: [PATCH] gnu: audacity: Update to 2.1.3.
Date: Mon, 03 Apr 2017 00:03:26 +0200
[Message part 1 (text/plain, inline)]
Kei Kebreau <kei <at> openmailbox.org> writes:

> * gnu/packages/audacity.scm (audacity): Update to 2.1.3.
> [source]: Fetch gzipped tar archive instead of a zip archive; add
> snippet to remove time-dependent code; remove unnecessary patch.
> [native-inputs]: Add autoconf, automake and libtool.
> [arguments]: Add autoreconf phase to detect system libraries.
> * gnu/packages/patches/audacity-fix-ffmpeg-binding.patch: Delete patch.
> * gnu/local.mk: Remove reference to removed patch.
> ---
>  gnu/local.mk                                       |  1 -
>  gnu/packages/audacity.scm                          | 25 +++++++++++++----
>  .../patches/audacity-fix-ffmpeg-binding.patch      | 32 ----------------------
>  3 files changed, 20 insertions(+), 38 deletions(-)
>  delete mode 100644 gnu/packages/patches/audacity-fix-ffmpeg-binding.patch
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 68f561e95..f03f50855 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -494,7 +494,6 @@ dist_patch_DATA =						\
>    %D%/packages/patches/ath9k-htc-firmware-binutils.patch	\
>    %D%/packages/patches/ath9k-htc-firmware-gcc.patch		\
>    %D%/packages/patches/ath9k-htc-firmware-objcopy.patch		\
> -  %D%/packages/patches/audacity-fix-ffmpeg-binding.patch	\
>    %D%/packages/patches/automake-skip-amhello-tests.patch	\
>    %D%/packages/patches/automake-regexp-syntax.patch		\
>    %D%/packages/patches/automake-test-gzip-warning.patch		\
> diff --git a/gnu/packages/audacity.scm b/gnu/packages/audacity.scm
> index a70d0e3a6..a4ac2a6ff 100644
> --- a/gnu/packages/audacity.scm
> +++ b/gnu/packages/audacity.scm
> @@ -23,6 +23,7 @@
>    #:use-module (guix build-system gnu)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages audio)
> +  #:use-module (gnu packages autotools)
>    #:use-module (gnu packages base)
>    #:use-module (gnu packages gettext)
>    #:use-module (gnu packages gtk)
> @@ -39,15 +40,20 @@
>  (define-public audacity
>    (package
>      (name "audacity")
> -    (version "2.1.2")
> +    (version "2.1.3")
>      (source
>       (origin
>         (method url-fetch)
>         (uri (string-append "https://github.com/audacity/audacity/archive"
> -                           "/Audacity-" version ".zip"))
> +                           "/Audacity-" version ".tar.gz"))
>         (sha256
> -        (base32 "1642i9d5cdmqzj6r0qdl2ldnqsvpb08znnczncysi72x6zpvb5qq"))
> -       (patches (search-patches "audacity-fix-ffmpeg-binding.patch"))))
> +        (base32 "11mx7gb4dbqrgfp7hm0154x3m76ddnmhf2675q5zkxn7jc5qfc6b"))
> +       ;; Replace time-dependent strings.
> +       (modules '((guix build utils)))
> +       (snippet
> +        '(substitute* "src/AboutDialog.cpp"
> +           (("__DATE__") "\"2017\"")
> +           (("__TIME__") "\"00:00\"")))))

Now that we're merging core-updates where GCC have been patched to
respect SOURCE_DATE_EPOCH in these macros, this substitution should no
longer be necessary. Can you verify? :)

>      (build-system gnu-build-system)
>      (inputs
>       ;; TODO: Add portSMF and libwidgetextra once they're packaged.  In-tree
> @@ -73,7 +79,10 @@
>         ("lilv" ,lilv)
>         ("portaudio" ,portaudio)))
>      (native-inputs
> -     `(("gettext" ,gettext-minimal)     ;for msgfmt
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("gettext" ,gettext-minimal)     ;for msgfmt
> +       ("libtool" ,libtool)
>         ("pkg-config" ,pkg-config)
>         ("python" ,python-2)
>         ("which" ,which)))
> @@ -90,6 +99,12 @@
>            (string-append "ID3TAG_LIBS=-L" libid3tag "/lib -lid3tag -lz")
>            (string-append "LIBMAD_CFLAGS=-I" libmad "/include")
>            (string-append "LIBMAD_LIBS=-L" libmad "/lib -lmad")))
> +       #:phases
> +       (modify-phases %standard-phases
> +         ;; Ensure the usage of system libraries.
> +         (add-before 'configure 'autoreconf
> +           (lambda _
> +             (zero? (system* "autoreconf" "-vfi")))))

Can you clarify how autoreconf ensures usage of system libraries?
Usually it just re-generates configure scripts and Makefiles from
templates, but should not make any functional difference.

Thanks!
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26343; Package guix-patches. (Sun, 02 Apr 2017 22:08:02 GMT) Full text and rfc822 format available.

Message #11 received at 26343 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Kei Kebreau <kei <at> openmailbox.org>, 26343 <at> debbugs.gnu.org
Cc: Kei Kebreau <kei <at> openmailbox.org>
Subject: Re: bug#26343: [PATCH] gnu: audacity: Update to 2.1.3.
Date: Mon, 03 Apr 2017 00:07:28 +0200
[Message part 1 (text/plain, inline)]
>>      (build-system gnu-build-system)
>>      (inputs
>>       ;; TODO: Add portSMF and libwidgetextra once they're packaged.  In-tree
>> @@ -73,7 +79,10 @@
>>         ("lilv" ,lilv)
>>         ("portaudio" ,portaudio)))
>>      (native-inputs
>> -     `(("gettext" ,gettext-minimal)     ;for msgfmt
>> +     `(("autoconf" ,autoconf)
>> +       ("automake" ,automake)
>> +       ("gettext" ,gettext-minimal)     ;for msgfmt
>> +       ("libtool" ,libtool)
>>         ("pkg-config" ,pkg-config)
>>         ("python" ,python-2)
>>         ("which" ,which)))
>> @@ -90,6 +99,12 @@
>>            (string-append "ID3TAG_LIBS=-L" libid3tag "/lib -lid3tag -lz")
>>            (string-append "LIBMAD_CFLAGS=-I" libmad "/include")
>>            (string-append "LIBMAD_LIBS=-L" libmad "/lib -lmad")))
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         ;; Ensure the usage of system libraries.
>> +         (add-before 'configure 'autoreconf
>> +           (lambda _
>> +             (zero? (system* "autoreconf" "-vfi")))))
>
> Can you clarify how autoreconf ensures usage of system libraries?
> Usually it just re-generates configure scripts and Makefiles from
> templates, but should not make any functional difference.

I also noticed they offer yet another download on the home page:

http://www.audacityteam.org/download/source/

Perhaps this one is properly bootstrapped?
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26343; Package guix-patches. (Mon, 03 Apr 2017 01:49:01 GMT) Full text and rfc822 format available.

Message #14 received at 26343 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26343 <at> debbugs.gnu.org
Subject: Re: bug#26343: [PATCH] gnu: audacity: Update to 2.1.3.
Date: Sun, 02 Apr 2017 21:48:20 -0400
[Message part 1 (text/plain, inline)]
Marius Bakke <mbakke <at> fastmail.com> writes:

> Kei Kebreau <kei <at> openmailbox.org> writes:
>
>> * gnu/packages/audacity.scm (audacity): Update to 2.1.3.
>> [source]: Fetch gzipped tar archive instead of a zip archive; add
>> snippet to remove time-dependent code; remove unnecessary patch.
>> [native-inputs]: Add autoconf, automake and libtool.
>> [arguments]: Add autoreconf phase to detect system libraries.
>> * gnu/packages/patches/audacity-fix-ffmpeg-binding.patch: Delete patch.
>> * gnu/local.mk: Remove reference to removed patch.
>> ---
>>  gnu/local.mk                                       |  1 -
>>  gnu/packages/audacity.scm                          | 25 +++++++++++++----
>>  .../patches/audacity-fix-ffmpeg-binding.patch      | 32 ----------------------
>>  3 files changed, 20 insertions(+), 38 deletions(-)
>>  delete mode 100644 gnu/packages/patches/audacity-fix-ffmpeg-binding.patch
>>
>> diff --git a/gnu/local.mk b/gnu/local.mk
>> index 68f561e95..f03f50855 100644
>> --- a/gnu/local.mk
>> +++ b/gnu/local.mk
>> @@ -494,7 +494,6 @@ dist_patch_DATA =						\
>>    %D%/packages/patches/ath9k-htc-firmware-binutils.patch	\
>>    %D%/packages/patches/ath9k-htc-firmware-gcc.patch		\
>>    %D%/packages/patches/ath9k-htc-firmware-objcopy.patch		\
>> -  %D%/packages/patches/audacity-fix-ffmpeg-binding.patch	\
>>    %D%/packages/patches/automake-skip-amhello-tests.patch	\
>>    %D%/packages/patches/automake-regexp-syntax.patch		\
>>    %D%/packages/patches/automake-test-gzip-warning.patch		\
>> diff --git a/gnu/packages/audacity.scm b/gnu/packages/audacity.scm
>> index a70d0e3a6..a4ac2a6ff 100644
>> --- a/gnu/packages/audacity.scm
>> +++ b/gnu/packages/audacity.scm
>> @@ -23,6 +23,7 @@
>>    #:use-module (guix build-system gnu)
>>    #:use-module (gnu packages)
>>    #:use-module (gnu packages audio)
>> +  #:use-module (gnu packages autotools)
>>    #:use-module (gnu packages base)
>>    #:use-module (gnu packages gettext)
>>    #:use-module (gnu packages gtk)
>> @@ -39,15 +40,20 @@
>>  (define-public audacity
>>    (package
>>      (name "audacity")
>> -    (version "2.1.2")
>> +    (version "2.1.3")
>>      (source
>>       (origin
>>         (method url-fetch)
>>         (uri (string-append "https://github.com/audacity/audacity/archive"
>> -                           "/Audacity-" version ".zip"))
>> +                           "/Audacity-" version ".tar.gz"))
>>         (sha256
>> -        (base32 "1642i9d5cdmqzj6r0qdl2ldnqsvpb08znnczncysi72x6zpvb5qq"))
>> -       (patches (search-patches "audacity-fix-ffmpeg-binding.patch"))))
>> +        (base32 "11mx7gb4dbqrgfp7hm0154x3m76ddnmhf2675q5zkxn7jc5qfc6b"))
>> +       ;; Replace time-dependent strings.
>> +       (modules '((guix build utils)))
>> +       (snippet
>> +        '(substitute* "src/AboutDialog.cpp"
>> +           (("__DATE__") "\"2017\"")
>> +           (("__TIME__") "\"00:00\"")))))
>
> Now that we're merging core-updates where GCC have been patched to
> respect SOURCE_DATE_EPOCH in these macros, this substitution should no
> longer be necessary. Can you verify? :)
>

It works! \o/

>>      (build-system gnu-build-system)
>>      (inputs
>>       ;; TODO: Add portSMF and libwidgetextra once they're packaged.  In-tree
>> @@ -73,7 +79,10 @@
>>         ("lilv" ,lilv)
>>         ("portaudio" ,portaudio)))
>>      (native-inputs
>> -     `(("gettext" ,gettext-minimal)     ;for msgfmt
>> +     `(("autoconf" ,autoconf)
>> +       ("automake" ,automake)
>> +       ("gettext" ,gettext-minimal)     ;for msgfmt
>> +       ("libtool" ,libtool)
>>         ("pkg-config" ,pkg-config)
>>         ("python" ,python-2)
>>         ("which" ,which)))
>> @@ -90,6 +99,12 @@
>>            (string-append "ID3TAG_LIBS=-L" libid3tag "/lib -lid3tag -lz")
>>            (string-append "LIBMAD_CFLAGS=-I" libmad "/include")
>>            (string-append "LIBMAD_LIBS=-L" libmad "/lib -lmad")))
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         ;; Ensure the usage of system libraries.
>> +         (add-before 'configure 'autoreconf
>> +           (lambda _
>> +             (zero? (system* "autoreconf" "-vfi")))))
>
> Can you clarify how autoreconf ensures usage of system libraries?
> Usually it just re-generates configure scripts and Makefiles from
> templates, but should not make any functional difference.
>
> Thanks!

FFmpeg is not detected if autoreconf doesn't run for some reason. With
this phase, everything is detected like normal.

Also, the audacityteam.org URL leads to another webpage with a seemingly
impermanent link to the tarball*. I get the following:

https://download.fosshub.com/Protected/expiretime=1491206292;badurl=aHR0cDovL3d3dy5mb3NzaHViLmNvbS9BdWRhY2l0eS5odG1s/c9aee3215609f12a03856bbf4732fa9ddcaf0424361dc96c6919a3b6543265bb/Audacity/audacity-minsrc-2.1.3.tar.xz

* Take a look at the following thread to see what happened last time
  with this topic. I'm not getting the 403 errors that I was getting
  before though:
  https://lists.gnu.org/archive/html/guix-devel/2017-01/msg01093.html
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26343; Package guix-patches. (Mon, 03 Apr 2017 12:41:02 GMT) Full text and rfc822 format available.

Message #17 received at 26343 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 26343 <at> debbugs.gnu.org
Subject: Re: bug#26343: [PATCH] gnu: audacity: Update to 2.1.3.
Date: Mon, 03 Apr 2017 14:40:10 +0200
[Message part 1 (text/plain, inline)]
Kei Kebreau <kei <at> openmailbox.org> writes:

> Marius Bakke <mbakke <at> fastmail.com> writes:
>
>>>      (build-system gnu-build-system)
>>>      (inputs
>>>       ;; TODO: Add portSMF and libwidgetextra once they're packaged.  In-tree
>>> @@ -73,7 +79,10 @@
>>>         ("lilv" ,lilv)
>>>         ("portaudio" ,portaudio)))
>>>      (native-inputs
>>> -     `(("gettext" ,gettext-minimal)     ;for msgfmt
>>> +     `(("autoconf" ,autoconf)
>>> +       ("automake" ,automake)
>>> +       ("gettext" ,gettext-minimal)     ;for msgfmt
>>> +       ("libtool" ,libtool)
>>>         ("pkg-config" ,pkg-config)
>>>         ("python" ,python-2)
>>>         ("which" ,which)))
>>> @@ -90,6 +99,12 @@
>>>            (string-append "ID3TAG_LIBS=-L" libid3tag "/lib -lid3tag -lz")
>>>            (string-append "LIBMAD_CFLAGS=-I" libmad "/include")
>>>            (string-append "LIBMAD_LIBS=-L" libmad "/lib -lmad")))
>>> +       #:phases
>>> +       (modify-phases %standard-phases
>>> +         ;; Ensure the usage of system libraries.
>>> +         (add-before 'configure 'autoreconf
>>> +           (lambda _
>>> +             (zero? (system* "autoreconf" "-vfi")))))
>>
>> Can you clarify how autoreconf ensures usage of system libraries?
>> Usually it just re-generates configure scripts and Makefiles from
>> templates, but should not make any functional difference.
>
> FFmpeg is not detected if autoreconf doesn't run for some reason. With
> this phase, everything is detected like normal.

Oh. Please mention that in the comment then. Thank you! :)
[signature.asc (application/pgp-signature, inline)]

Reply sent to Kei Kebreau <kei <at> openmailbox.org>:
You have taken responsibility. (Mon, 03 Apr 2017 15:54:01 GMT) Full text and rfc822 format available.

Notification sent to Kei Kebreau <kei <at> openmailbox.org>:
bug acknowledged by developer. (Mon, 03 Apr 2017 15:54:03 GMT) Full text and rfc822 format available.

Message #22 received at 26343-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26343-done <at> debbugs.gnu.org
Subject: Re: bug#26343: [PATCH] gnu: audacity: Update to 2.1.3.
Date: Mon, 03 Apr 2017 11:52:59 -0400
[Message part 1 (text/plain, inline)]
Marius Bakke <mbakke <at> fastmail.com> writes:

> Kei Kebreau <kei <at> openmailbox.org> writes:
>
>> Marius Bakke <mbakke <at> fastmail.com> writes:
>>
>>>>      (build-system gnu-build-system)
>>>>      (inputs
>>>>       ;; TODO: Add portSMF and libwidgetextra once they're packaged.  In-tree
>>>> @@ -73,7 +79,10 @@
>>>>         ("lilv" ,lilv)
>>>>         ("portaudio" ,portaudio)))
>>>>      (native-inputs
>>>> -     `(("gettext" ,gettext-minimal)     ;for msgfmt
>>>> +     `(("autoconf" ,autoconf)
>>>> +       ("automake" ,automake)
>>>> +       ("gettext" ,gettext-minimal)     ;for msgfmt
>>>> +       ("libtool" ,libtool)
>>>>         ("pkg-config" ,pkg-config)
>>>>         ("python" ,python-2)
>>>>         ("which" ,which)))
>>>> @@ -90,6 +99,12 @@
>>>>            (string-append "ID3TAG_LIBS=-L" libid3tag "/lib -lid3tag -lz")
>>>>            (string-append "LIBMAD_CFLAGS=-I" libmad "/include")
>>>>            (string-append "LIBMAD_LIBS=-L" libmad "/lib -lmad")))
>>>> +       #:phases
>>>> +       (modify-phases %standard-phases
>>>> +         ;; Ensure the usage of system libraries.
>>>> +         (add-before 'configure 'autoreconf
>>>> +           (lambda _
>>>> +             (zero? (system* "autoreconf" "-vfi")))))
>>>
>>> Can you clarify how autoreconf ensures usage of system libraries?
>>> Usually it just re-generates configure scripts and Makefiles from
>>> templates, but should not make any functional difference.
>>
>> FFmpeg is not detected if autoreconf doesn't run for some reason. With
>> this phase, everything is detected like normal.
>
> Oh. Please mention that in the comment then. Thank you! :)

Pushed to master. Thanks for the review!
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 02 May 2017 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 8 years and 52 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.