GNU bug report logs - #26342
[PATCH] gnu: emacs-elfeed: Enable tests.

Previous Next

Package: guix-patches;

Reported by: Arun Isaac <arunisaac <at> systemreboot.net>

Date: Sun, 2 Apr 2017 15:14:01 UTC

Severity: normal

Tags: patch

Done: Kei Kebreau <kei <at> openmailbox.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26342 in the body.
You can then email your comments to 26342 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#26342; Package guix-patches. (Sun, 02 Apr 2017 15:14:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Arun Isaac <arunisaac <at> systemreboot.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 02 Apr 2017 15:14:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH] gnu: emacs-elfeed: Enable tests.
Date: Sun,  2 Apr 2017 20:42:35 +0530

* gnu/packages/emacs.scm (emacs-elfeed)[arguments]: Add a 'check' phase.
---
 gnu/packages/emacs.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index cb2792f63..1091e562a 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3100,6 +3100,15 @@ If you want to mark a folder manually as a project just create an empty
                (base32
                 "145glas04zd0s2rmnif46vhyijs4z03v871gfp1dcrwxvvvns8ap"))))
     (build-system emacs-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'install 'check
+           (lambda _
+             (zero? (system* "emacs" "--batch" "--eval" "(add-to-list 'load-path \".\")"
+                             "--eval" "(add-to-list 'load-path \"./tests\")"
+                             "-l" "tests/elfeed-tests.el"
+                             "-f" "ert-run-tests-batch-and-exit")))))))
     (home-page "https://github.com/skeeto/elfeed")
     (synopsis "Atom/RSS feed reader for Emacs")
     (description
-- 
2.11.0
Information forwarded to guix-patches <at> gnu.org:
bug#26342; Package guix-patches. (Sun, 02 Apr 2017 17:03:02 GMT) Full text and rfc822 format available.

Message #8 received at 26342 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 26342 <at> debbugs.gnu.org
Subject: Re: bug#26342: [PATCH] gnu: emacs-elfeed: Enable tests.
Date: Sun, 02 Apr 2017 13:02:21 -0400

[Message part 1 (text/plain, inline)]
Arun Isaac <arunisaac <at> systemreboot.net> writes:

> * gnu/packages/emacs.scm (emacs-elfeed)[arguments]: Add a 'check' phase.
> ---
>  gnu/packages/emacs.scm | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index cb2792f63..1091e562a 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -3100,6 +3100,15 @@ If you want to mark a folder manually as a project just create an empty
>                 (base32
>                  "145glas04zd0s2rmnif46vhyijs4z03v871gfp1dcrwxvvvns8ap"))))
>      (build-system emacs-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'install 'check
> +           (lambda _
> +             (zero? (system* "emacs" "--batch" "--eval" "(add-to-list 'load-path \".\")"
> +                             "--eval" "(add-to-list 'load-path \"./tests\")"
> +                             "-l" "tests/elfeed-tests.el"
> +                             "-f" "ert-run-tests-batch-and-exit")))))))
>      (home-page "https://github.com/skeeto/elfeed")
>      (synopsis "Atom/RSS feed reader for Emacs")
>      (description

Thanks for the patch! I checked out elfeed's makefile and it turns out
this patch can be made even simpler by just calling (zero? (system* "make"
"test")). Could you do that and sumbit the new patch?

[signature.asc (application/pgp-signature, inline)]
Information forwarded to guix-patches <at> gnu.org:
bug#26342; Package guix-patches. (Sun, 02 Apr 2017 18:58:02 GMT) Full text and rfc822 format available.

Message #11 received at 26342 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26342 <at> debbugs.gnu.org
Subject: Re: bug#26342: [PATCH] gnu: emacs-elfeed: Enable tests.
Date: Mon, 03 Apr 2017 00:27:43 +0530

Kei Kebreau writes:

> Arun Isaac <arunisaac <at> systemreboot.net> writes:
>
>> * gnu/packages/emacs.scm (emacs-elfeed)[arguments]: Add a 'check' phase.
>> ---
>>  gnu/packages/emacs.scm | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index cb2792f63..1091e562a 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -3100,6 +3100,15 @@ If you want to mark a folder manually as a project just create an empty
>>                 (base32
>>                  "145glas04zd0s2rmnif46vhyijs4z03v871gfp1dcrwxvvvns8ap"))))
>>      (build-system emacs-build-system)
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'install 'check
>> +           (lambda _
>> +             (zero? (system* "emacs" "--batch" "--eval" "(add-to-list 'load-path \".\")"
>> +                             "--eval" "(add-to-list 'load-path \"./tests\")"
>> +                             "-l" "tests/elfeed-tests.el"
>> +                             "-f" "ert-run-tests-batch-and-exit")))))))
>>      (home-page "https://github.com/skeeto/elfeed")
>>      (synopsis "Atom/RSS feed reader for Emacs")
>>      (description
>
> Thanks for the patch! I checked out elfeed's makefile and it turns out
> this patch can be made even simpler by just calling (zero? (system* "make"
> "test")). Could you do that and sumbit the new patch?

Ah, I missed the Makefile. I'll submit a new patch.
Information forwarded to guix-patches <at> gnu.org:
bug#26342; Package guix-patches. (Sun, 02 Apr 2017 19:22:02 GMT) Full text and rfc822 format available.

Message #14 received at 26342 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26342 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH] gnu: emacs-elfeed: Enable tests.
Date: Mon,  3 Apr 2017 00:50:57 +0530

* gnu/packages/emacs.scm (emacs-elfeed)[arguments]: Add a 'check' phase.
---
 gnu/packages/emacs.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index cb2792f63..83c76113f 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3100,6 +3100,12 @@ If you want to mark a folder manually as a project just create an empty
                (base32
                 "145glas04zd0s2rmnif46vhyijs4z03v871gfp1dcrwxvvvns8ap"))))
     (build-system emacs-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'install 'check
+           (lambda _
+             (zero? (system* "make" "test")))))))
     (home-page "https://github.com/skeeto/elfeed")
     (synopsis "Atom/RSS feed reader for Emacs")
     (description
-- 
2.11.0
Information forwarded to guix-patches <at> gnu.org:
bug#26342; Package guix-patches. (Mon, 03 Apr 2017 03:12:01 GMT) Full text and rfc822 format available.

Message #17 received at 26342 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 26342 <at> debbugs.gnu.org
Subject: Re: bug#26342: [PATCH] gnu: emacs-elfeed: Enable tests.
Date: Sun, 02 Apr 2017 23:11:11 -0400

[Message part 1 (text/plain, inline)]
Arun Isaac <arunisaac <at> systemreboot.net> writes:

> * gnu/packages/emacs.scm (emacs-elfeed)[arguments]: Add a 'check' phase.
> ---
>  gnu/packages/emacs.scm | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index cb2792f63..83c76113f 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -3100,6 +3100,12 @@ If you want to mark a folder manually as a project just create an empty
>                 (base32
>                  "145glas04zd0s2rmnif46vhyijs4z03v871gfp1dcrwxvvvns8ap"))))
>      (build-system emacs-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'install 'check
> +           (lambda _
> +             (zero? (system* "make" "test")))))))
>      (home-page "https://github.com/skeeto/elfeed")
>      (synopsis "Atom/RSS feed reader for Emacs")
>      (description

Pushed to master as 568f977f9c4c2edd0f29b7627b315b716eda9c15. Thanks
again, Arun!

[signature.asc (application/pgp-signature, inline)]
Reply sent to Kei Kebreau <kei <at> openmailbox.org>:
You have taken responsibility. (Mon, 03 Apr 2017 03:13:02 GMT) Full text and rfc822 format available.
Notification sent to Arun Isaac <arunisaac <at> systemreboot.net>:
bug acknowledged by developer. (Mon, 03 Apr 2017 03:13:02 GMT) Full text and rfc822 format available.

Message #22 received at 26342-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: 26342-done <at> debbugs.gnu.org
Subject: Re: bug#26342: [PATCH] gnu: emacs-elfeed: Enable tests.
Date: Sun, 02 Apr 2017 23:12:22 -0400

[Message part 1 (text/plain, inline)]
The patch was applied to the master branch.

[signature.asc (application/pgp-signature, inline)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 01 May 2017 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 8 years and 53 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.