GNU bug report logs - #24423
Proposal to set buffer not-modified when downloading a sieve script

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: TSUCHIYA Masatoshi <tsuchiya <at> namazu.org>
Subject: bug#24423: closed (Re: bug#24423: Proposal to set buffer
 not-modified when downloading a sieve script)
Date: Mon, 12 Sep 2016 23:09:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#24423: Proposal to set buffer not-modified when downloading a sieve script

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 24423 <at> debbugs.gnu.org.

-- 
24423: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24423
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: tsuchiya <at> namazu.org
Cc: 24423-done <at> debbugs.gnu.org
Subject: Re: bug#24423: Proposal to set buffer not-modified when downloading a
 sieve script
Date: Tue, 13 Sep 2016 08:08:45 +0900

On Mon, 12 Sep 2016 16:03:18 -0400, TSUCHIYA Masatoshi wrote:
> Because sieve-edit-script() does not set buffer not-modified when
> downloading a sieve script, so, a user including muself cannot
> distinguish whether the viewing script is modified or not modified from
> the downloaded script on the managesieve server.

> If sieve-edit-script() set buffer not-modified when downloading a sieve
> script, a user can distinguish its modified status easily.

> Therefore, I propose the following patch.

The patch looks fine and useful.  I've committed it in the Emacs
master with this log entry:

sieve.el: Make the buffer to edit unmodified initially (bug#24423)

* lisp/net/sieve.el (sieve-edit-script):
Make the buffer to edit be not modified-p initially (bug#24423).

Thanks.

[Message part 3 (message/rfc822, inline)]

From: TSUCHIYA Masatoshi <tsuchiya <at> namazu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Proposal to set buffer not-modified when downloading a sieve script
Date: Mon, 12 Sep 2016 16:03:18 -0400

[Message part 4 (text/plain, inline)]

Hi,

Because sieve-edit-script() does not set buffer not-modified when
downloading a sieve script, so, a user including muself cannot
distinguish whether the viewing script is modified or not modified from
the downloaded script on the managesieve server.

If sieve-edit-script() set buffer not-modified when downloading a sieve
script, a user can distinguish its modified status easily.

Therefore, I propose the following patch.

-- 
TSUCHIYA Masatoshi

[Message part 5 (text/x-diff, inline)]

--- a/lisp/sieve.el
+++ b/lisp/sieve.el
@@ -207,7 +207,8 @@ require \"fileinto\";
 	      err)
 	  (setq err (sieve-manage-getscript name newbuf sieve-manage-buffer))
 	  (switch-to-buffer newbuf)
-	  (unless (sieve-manage-ok-p err)
+	  (if (sieve-manage-ok-p err)
+	      (set-buffer-modified-p nil)
 	    (error "Sieve download failed: %s" err)))
       (switch-to-buffer (get-buffer-create "template.siv"))
       (insert sieve-template))

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.