GNU bug report logs - #24423
Proposal to set buffer not-modified when downloading a sieve script

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24423 in the body.
You can then email your comments to 24423 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: TSUCHIYA Masatoshi <tsuchiya <at> namazu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Proposal to set buffer not-modified when downloading a sieve script
Date: Mon, 12 Sep 2016 16:03:18 -0400

[Message part 1 (text/plain, inline)]

Hi,

Because sieve-edit-script() does not set buffer not-modified when
downloading a sieve script, so, a user including muself cannot
distinguish whether the viewing script is modified or not modified from
the downloaded script on the managesieve server.

If sieve-edit-script() set buffer not-modified when downloading a sieve
script, a user can distinguish its modified status easily.

Therefore, I propose the following patch.

-- 
TSUCHIYA Masatoshi

[Message part 2 (text/x-diff, inline)]

--- a/lisp/sieve.el
+++ b/lisp/sieve.el
@@ -207,7 +207,8 @@ require \"fileinto\";
 	      err)
 	  (setq err (sieve-manage-getscript name newbuf sieve-manage-buffer))
 	  (switch-to-buffer newbuf)
-	  (unless (sieve-manage-ok-p err)
+	  (if (sieve-manage-ok-p err)
+	      (set-buffer-modified-p nil)
 	    (error "Sieve download failed: %s" err)))
       (switch-to-buffer (get-buffer-create "template.siv"))
       (insert sieve-template))

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 24423-done <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: tsuchiya <at> namazu.org
Cc: 24423-done <at> debbugs.gnu.org
Subject: Re: bug#24423: Proposal to set buffer not-modified when downloading a
 sieve script
Date: Tue, 13 Sep 2016 08:08:45 +0900

On Mon, 12 Sep 2016 16:03:18 -0400, TSUCHIYA Masatoshi wrote:
> Because sieve-edit-script() does not set buffer not-modified when
> downloading a sieve script, so, a user including muself cannot
> distinguish whether the viewing script is modified or not modified from
> the downloaded script on the managesieve server.

> If sieve-edit-script() set buffer not-modified when downloading a sieve
> script, a user can distinguish its modified status easily.

> Therefore, I propose the following patch.

The patch looks fine and useful.  I've committed it in the Emacs
master with this log entry:

sieve.el: Make the buffer to edit unmodified initially (bug#24423)

* lisp/net/sieve.el (sieve-edit-script):
Make the buffer to edit be not modified-p initially (bug#24423).

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.