GNU bug report logs - #24422
Proposal to create `sieve-manage-ignore-broken-tls' option

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24422 in the body.
You can then email your comments to 24422 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: TSUCHIYA Masatoshi <tsuchiya <at> namazu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Proposal to create `sieve-manage-ignore-broken-tls' option
Date: Mon, 12 Sep 2016 15:57:24 -0400

[Message part 1 (text/plain, inline)]

Hi,

When accessing a managesieve server which provides broken TLS
connections, it is quite useful that sieve-manage-open-server() ignores
STARTTLS capability.  Therefore, I propose the following patch.

Regards,

-- 
TSUCHIYA Masatoshi

[Message part 2 (text/x-diff, inline)]

--- a/lisp/sieve-manage.el
+++ b/lisp/sieve-manage.el
@@ -147,6 +147,11 @@ for doing the actual authentication."
   :type 'symbol
   :group 'sieve-manage)
 
+(defcustom sieve-manage-ignore-broken-tls nil
+  "Ignore STARTTLS even if STARTTLS capability is provided."
+  :type 'boolean
+  :group 'sieve-manage)
+
 ;; Internal variables:
 
 (defconst sieve-manage-local-variables '(sieve-manage-server
@@ -211,14 +216,16 @@ Return the buffer associated with the connection."
          :return-list t
          :starttls-function
          (lambda (capabilities)
-           (when (string-match "\\bSTARTTLS\\b" capabilities)
-             "STARTTLS\r\n")))
+	   (when (and (not sieve-manage-ignore-broken-tls)
+		      (string-match "\\bSTARTTLS\\b" capabilities))
+	     "STARTTLS\r\n")))
       (setq sieve-manage-process proc)
       (setq sieve-manage-capability
             (sieve-manage-parse-capability (plist-get props :capabilities)))
       ;; Ignore new capabilities issues after successful STARTTLS
-      (when (and (memq stream '(nil network starttls))
-                 (eq (plist-get props :type) 'tls))
+      (when (or sieve-manage-ignore-broken-tls
+		(and (memq stream '(nil network starttls))
+		     (eq (plist-get props :type) 'tls)))
         (sieve-manage-drop-next-answer))
       (current-buffer))))
 

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 24422-done <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: tsuchiya <at> namazu.org
Cc: 24422-done <at> debbugs.gnu.org
Subject: Re: bug#24422: Proposal to create `sieve-manage-ignore-broken-tls'
 option
Date: Tue, 13 Sep 2016 08:08:37 +0900

On Mon, 12 Sep 2016 15:57:24 -0400, TSUCHIYA Masatoshi wrote:
> When accessing a managesieve server which provides broken TLS
> connections, it is quite useful that sieve-manage-open-server() ignores
> STARTTLS capability.  Therefore, I propose the following patch.

The patch looks fine and not likely to cause a trouble.  I've
committed it in the Emacs master with this log entry:

sieve-manage.el: Allow user to avoid STARTTLS capability test (bug#24422)

* lisp/net/sieve-manage.el
(sieve-manage-ignore-broken-tls): New user option.
(sieve-manage-open-server):
Don't test STARTTLS capability if the option is set (bug#24422).

Thanks.

Message #13 received at 24422 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: 24422 <at> debbugs.gnu.org
Cc: yamaoka <at> jpl.org, tsuchiya <at> namazu.org
Subject: Re: bug#24422: Proposal to create `sieve-manage-ignore-broken-tls'
 option
Date: Tue, 13 Sep 2016 09:21:48 -0400

On Tue, 13 Sep 2016 08:08:37 +0900 Katsumi Yamaoka <yamaoka <at> jpl.org> wrote: 

KY> On Mon, 12 Sep 2016 15:57:24 -0400, TSUCHIYA Masatoshi wrote:
>> When accessing a managesieve server which provides broken TLS
>> connections, it is quite useful that sieve-manage-open-server() ignores
>> STARTTLS capability.  Therefore, I propose the following patch.

KY> The patch looks fine and not likely to cause a trouble.  I've
KY> committed it in the Emacs master with this log entry:

KY> sieve-manage.el: Allow user to avoid STARTTLS capability test (bug#24422)

KY> * lisp/net/sieve-manage.el
KY> (sieve-manage-ignore-broken-tls): New user option.
KY> (sieve-manage-open-server):
KY> Don't test STARTTLS capability if the option is set (bug#24422).

I think the option is badly named. It doesn't ignore broken TLS
(whatever that means), it avoids STARTTLS altogether. So maybe it should
be `sieve-manage-ignore-starttls' or something like that.

Ted

Message #16 received at 24422 <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: 24422 <at> debbugs.gnu.org
Cc: tsuchiya <at> namazu.org
Subject: Re: bug#24422: Proposal to create `sieve-manage-ignore-broken-tls'
 option
Date: Wed, 14 Sep 2016 09:08:17 +0900

On Tue, 13 Sep 2016 09:21:48 -0400, Ted Zlatanov wrote:
> On Tue, 13 Sep 2016 08:08:37 +0900 Katsumi Yamaoka <yamaoka <at> jpl.org> wrote:

KY> On Mon, 12 Sep 2016 15:57:24 -0400, TSUCHIYA Masatoshi wrote:
>>> When accessing a managesieve server which provides broken TLS
>>> connections, it is quite useful that sieve-manage-open-server() ignores
>>> STARTTLS capability.  Therefore, I propose the following patch.

KY> The patch looks fine and not likely to cause a trouble.  I've
KY> committed it in the Emacs master with this log entry:

KY> sieve-manage.el: Allow user to avoid STARTTLS capability test (bug#24422)

KY> * lisp/net/sieve-manage.el
KY> (sieve-manage-ignore-broken-tls): New user option.
KY> (sieve-manage-open-server):
KY> Don't test STARTTLS capability if the option is set (bug#24422).

> I think the option is badly named. It doesn't ignore broken TLS
> (whatever that means), it avoids STARTTLS altogether. So maybe it should
> be `sieve-manage-ignore-starttls' or something like that.

Agreed.  I misunderstood what it tries to do.  It is irrelevant
if the one is broken or not, it simply makes it not use STARTTLS,
and the docstring is correct:

  "Ignore STARTTLS even if STARTTLS capability is provided."

I've renamed it as suggested, with this log entry:

sieve-manage.el: Rename sieve-manage-ignore-broken-tls

* lisp/net/sieve-manage.el (sieve-manage-ignore-starttls):
Rename from sieve-manage-ignore-broken-tls.  If it is set,
sieve-manage will never use STARTTLS even if the server says
it is capable (but may be broken).

Thanks.

Message #19 received at 24422 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 24422 <at> debbugs.gnu.org, tsuchiya <at> namazu.org
Subject: Re: bug#24422: Proposal to create `sieve-manage-ignore-broken-tls'
 option
Date: Tue, 20 Sep 2016 09:00:02 -0400

On Wed, 14 Sep 2016 09:08:17 +0900 Katsumi Yamaoka <yamaoka <at> jpl.org> wrote: 

KY> On Tue, 13 Sep 2016 09:21:48 -0400, Ted Zlatanov wrote:

>> I think the option is badly named. It doesn't ignore broken TLS
>> (whatever that means), it avoids STARTTLS altogether. So maybe it should
>> be `sieve-manage-ignore-starttls' or something like that.

KY> Agreed.  I misunderstood what it tries to do.  It is irrelevant
KY> if the one is broken or not, it simply makes it not use STARTTLS,
KY> and the docstring is correct:

KY>   "Ignore STARTTLS even if STARTTLS capability is provided."

KY> I've renamed it as suggested, with this log entry:

KY> sieve-manage.el: Rename sieve-manage-ignore-broken-tls

KY> * lisp/net/sieve-manage.el (sieve-manage-ignore-starttls):
KY> Rename from sieve-manage-ignore-broken-tls.  If it is set,
KY> sieve-manage will never use STARTTLS even if the server says
KY> it is capable (but may be broken).

Thank you, as always!!! This can be marked as done?

Ted

Message #22 received at 24422-done <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: 24422-done <at> debbugs.gnu.org
Cc: tsuchiya <at> namazu.org
Subject: Re: bug#24422: Proposal to create `sieve-manage-ignore-broken-tls'
 option
Date: Wed, 21 Sep 2016 08:40:18 +0900

On Tue, 20 Sep 2016 09:00:02 -0400, Ted Zlatanov wrote:
> Thank you, as always!!! This can be marked as done?

Tsuchiya-san seems to have no comment, so I'm closing this bug.
Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.