GNU bug report logs - #24423
Proposal to set buffer not-modified when downloading a sieve script

Previous Next

Full log

View this message in rfc822 format

From: TSUCHIYA Masatoshi <tsuchiya <at> namazu.org>
To: 24423 <at> debbugs.gnu.org
Subject: bug#24423: Proposal to set buffer not-modified when downloading a sieve script
Date: Mon, 12 Sep 2016 16:03:18 -0400

[Message part 1 (text/plain, inline)]

Hi,

Because sieve-edit-script() does not set buffer not-modified when
downloading a sieve script, so, a user including muself cannot
distinguish whether the viewing script is modified or not modified from
the downloaded script on the managesieve server.

If sieve-edit-script() set buffer not-modified when downloading a sieve
script, a user can distinguish its modified status easily.

Therefore, I propose the following patch.

-- 
TSUCHIYA Masatoshi

[Message part 2 (text/x-diff, inline)]

--- a/lisp/sieve.el
+++ b/lisp/sieve.el
@@ -207,7 +207,8 @@ require \"fileinto\";
 	      err)
 	  (setq err (sieve-manage-getscript name newbuf sieve-manage-buffer))
 	  (switch-to-buffer newbuf)
-	  (unless (sieve-manage-ok-p err)
+	  (if (sieve-manage-ok-p err)
+	      (set-buffer-modified-p nil)
 	    (error "Sieve download failed: %s" err)))
       (switch-to-buffer (get-buffer-create "template.siv"))
       (insert sieve-template))

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.