GNU bug report logs - #24422
Proposal to create `sieve-manage-ignore-broken-tls' option

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#24422: closed (Proposal to create `sieve-manage-ignore-broken-tls'
 option)
Date: Mon, 12 Sep 2016 23:09:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 13 Sep 2016 08:08:37 +0900
with message-id <b4m8tuw7m2y.fsf <at> jpl.org>
and subject line Re: bug#24422: Proposal to create `sieve-manage-ignore-broken-tls' option
has caused the debbugs.gnu.org bug report #24422,
regarding Proposal to create `sieve-manage-ignore-broken-tls' option
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
24422: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24422
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: TSUCHIYA Masatoshi <tsuchiya <at> namazu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Proposal to create `sieve-manage-ignore-broken-tls' option
Date: Mon, 12 Sep 2016 15:57:24 -0400

[Message part 3 (text/plain, inline)]

Hi,

When accessing a managesieve server which provides broken TLS
connections, it is quite useful that sieve-manage-open-server() ignores
STARTTLS capability.  Therefore, I propose the following patch.

Regards,

-- 
TSUCHIYA Masatoshi

[Message part 4 (text/x-diff, inline)]

--- a/lisp/sieve-manage.el
+++ b/lisp/sieve-manage.el
@@ -147,6 +147,11 @@ for doing the actual authentication."
   :type 'symbol
   :group 'sieve-manage)
 
+(defcustom sieve-manage-ignore-broken-tls nil
+  "Ignore STARTTLS even if STARTTLS capability is provided."
+  :type 'boolean
+  :group 'sieve-manage)
+
 ;; Internal variables:
 
 (defconst sieve-manage-local-variables '(sieve-manage-server
@@ -211,14 +216,16 @@ Return the buffer associated with the connection."
          :return-list t
          :starttls-function
          (lambda (capabilities)
-           (when (string-match "\\bSTARTTLS\\b" capabilities)
-             "STARTTLS\r\n")))
+	   (when (and (not sieve-manage-ignore-broken-tls)
+		      (string-match "\\bSTARTTLS\\b" capabilities))
+	     "STARTTLS\r\n")))
       (setq sieve-manage-process proc)
       (setq sieve-manage-capability
             (sieve-manage-parse-capability (plist-get props :capabilities)))
       ;; Ignore new capabilities issues after successful STARTTLS
-      (when (and (memq stream '(nil network starttls))
-                 (eq (plist-get props :type) 'tls))
+      (when (or sieve-manage-ignore-broken-tls
+		(and (memq stream '(nil network starttls))
+		     (eq (plist-get props :type) 'tls)))
         (sieve-manage-drop-next-answer))
       (current-buffer))))
 

[signature.asc (application/pgp-signature, inline)]

[Message part 6 (message/rfc822, inline)]

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: tsuchiya <at> namazu.org
Cc: 24422-done <at> debbugs.gnu.org
Subject: Re: bug#24422: Proposal to create `sieve-manage-ignore-broken-tls'
 option
Date: Tue, 13 Sep 2016 08:08:37 +0900

On Mon, 12 Sep 2016 15:57:24 -0400, TSUCHIYA Masatoshi wrote:
> When accessing a managesieve server which provides broken TLS
> connections, it is quite useful that sieve-manage-open-server() ignores
> STARTTLS capability.  Therefore, I propose the following patch.

The patch looks fine and not likely to cause a trouble.  I've
committed it in the Emacs master with this log entry:

sieve-manage.el: Allow user to avoid STARTTLS capability test (bug#24422)

* lisp/net/sieve-manage.el
(sieve-manage-ignore-broken-tls): New user option.
(sieve-manage-open-server):
Don't test STARTTLS capability if the option is set (bug#24422).

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.