GNU bug report logs - #23768
[PATCH] tests: adjust to ignore gzip 1.8+ warnings

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23768 in the body.
You can then email your comments to 23768 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: bug-automake <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH] tests: adjust to ignore gzip 1.8+ warnings
Date: Tue, 14 Jun 2016 09:48:29 +0200

This fixes a test failure when testing with gzip 1.8.

* t/distcheck-no-prefix-or-srcdir-override.sh: Instead of testing for an
empty 'stderr' file, check for a zero-line file once gzip warnings have
been removed.
---
 t/distcheck-no-prefix-or-srcdir-override.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/t/distcheck-no-prefix-or-srcdir-override.sh b/t/distcheck-no-prefix-or-srcdir-override.sh
index bef334b..f9d05e1 100644
--- a/t/distcheck-no-prefix-or-srcdir-override.sh
+++ b/t/distcheck-no-prefix-or-srcdir-override.sh
@@ -49,7 +49,11 @@ grep "cannot find sources.* in foobar" stderr || exit 99
 
 ./configure
 run_make -E -O distcheck
-test ! -s stderr
+
+# Gzip 1.8+ emits warnings like "gzip: warning: GZIP environment
+# variable is deprecated"; filter them out.
+test `grep -v '^gzip: warning' stderr | wc -l` -eq 0
+
 # Sanity check: the flags have been actually seen.
 $PERL -e 'undef $/; $_ = <>; s/ \\\n/ /g; print;' <stdout >t
 grep '/configure .* --srcdir am-src'   t || exit 99
-- 
2.8.3

Message #8 received at 23768 <at> debbugs.gnu.org (full text, mbox):

From: Hans-Bernhard Bröker <HBBroeker <at> t-online.de>
To: 23768 <at> debbugs.gnu.org
Subject: Re: bug#23768: [PATCH] tests: adjust to ignore gzip 1.8+ warnings
Date: Wed, 15 Jun 2016 21:50:53 +0200

Am 14.06.2016 um 09:48 schrieb Ludovic Courtès:
> -test ! -s stderr
> +
> +# Gzip 1.8+ emits warnings like "gzip: warning: GZIP environment
> +# variable is deprecated"; filter them out.
> +test `grep -v '^gzip: warning' stderr | wc -l` -eq 0

Hmmm... wouldn't it make much more sense to just eliminate the GZIP 
environment variable, if set?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.