GNU bug report logs - #20132
[PROPOSED PATCH] autoconf: port better to future gzip

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20132 in the body.
You can then email your comments to 20132 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: bug-automake <at> gnu.org
Cc: Paul Eggert <eggert <at> cs.ucla.edu>
Subject: [PROPOSED PATCH] autoconf: port better to future gzip
Date: Tue, 17 Mar 2015 18:28:58 -0700

* lib/am/distdir.am (dist-gzip, dist-shar, distcheck):
Port better to future versions of gzip, which are planned to
deprecate the GZIP environment variable.
---
 lib/am/distdir.am | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/lib/am/distdir.am b/lib/am/distdir.am
index d4dd8cc..87c6730 100644
--- a/lib/am/distdir.am
+++ b/lib/am/distdir.am
@@ -309,6 +309,16 @@ endif %?TOPDIR_P%
 ## We order DIST_TARGETS by expected duration of the compressors,
 ## slowest first, for better parallelism in "make dist".  Do not
 ## reorder DIST_ARCHIVES, users may expect gzip to be first.
+##
+## Traditionally, gzip prepended the contents of the GZIP environment
+## variable to its arguments, and the commands below formerly used
+## this by invoking 'GZIP=$(GZIP_ENV) gzip'.  The GZIP environment
+## variable is now considered to be obsolescent, so the commands below
+## now use 'eval GZIP= gzip $(GZIP_ENV)' instead; this should work
+## with both older and newer gzip implementations.  The 'eval' is to
+## support makefile assignments like 'GZIP_ENV = "-9 -n"' that quote
+## the GZIP_ENV right-hand side because that was needed with the
+## former invocation pattern.
 
 if %?TOPDIR_P%
 
@@ -316,7 +326,7 @@ if %?TOPDIR_P%
 GZIP_ENV = --best
 .PHONY: dist-gzip
 dist-gzip: distdir
-	tardir=$(distdir) && $(am__tar) | GZIP=$(GZIP_ENV) gzip -c >$(distdir).tar.gz
+	tardir=$(distdir) && $(am__tar) | eval GZIP= gzip $(GZIP_ENV) -c >$(distdir).tar.gz
 	$(am__post_remove_distdir)
 
 ?BZIP2?DIST_ARCHIVES += $(distdir).tar.bz2
@@ -352,7 +362,7 @@ dist-shar: distdir
 	@echo WARNING: "Support for shar distribution archives is" \
 	               "deprecated." >&2
 	@echo WARNING: "It will be removed altogether in Automake 2.0" >&2
-	shar $(distdir) | GZIP=$(GZIP_ENV) gzip -c >$(distdir).shar.gz
+	shar $(distdir) | eval GZIP= gzip $(GZIP_ENV) -c >$(distdir).shar.gz
 	$(am__post_remove_distdir)
 
 ?ZIP?DIST_ARCHIVES += $(distdir).zip
@@ -412,7 +422,7 @@ endif %?SUBDIRS%
 distcheck: dist
 	case '$(DIST_ARCHIVES)' in \
 	*.tar.gz*) \
-	  GZIP=$(GZIP_ENV) gzip -dc $(distdir).tar.gz | $(am__untar) ;;\
+	  eval GZIP= gzip $(GZIP_ENV) -dc $(distdir).tar.gz | $(am__untar) ;;\
 	*.tar.bz2*) \
 	  bzip2 -dc $(distdir).tar.bz2 | $(am__untar) ;;\
 	*.tar.lz*) \
@@ -422,7 +432,7 @@ distcheck: dist
 	*.tar.Z*) \
 	  uncompress -c $(distdir).tar.Z | $(am__untar) ;;\
 	*.shar.gz*) \
-	  GZIP=$(GZIP_ENV) gzip -dc $(distdir).shar.gz | unshar ;;\
+	  eval GZIP= gzip $(GZIP_ENV) -dc $(distdir).shar.gz | unshar ;;\
 	*.zip*) \
 	  unzip $(distdir).zip ;;\
 	esac
-- 
2.1.0

Message #8 received at 20132 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>, 20132 <at> debbugs.gnu.org
Subject: Re: bug#20132: [PROPOSED PATCH] autoconf: port better to future gzip
Date: Tue, 21 Apr 2015 07:05:46 -0600

[Message part 1 (text/plain, inline)]

On 03/17/2015 07:28 PM, Paul Eggert wrote:
> * lib/am/distdir.am (dist-gzip, dist-shar, distcheck):
> Port better to future versions of gzip, which are planned to
> deprecate the GZIP environment variable.
> ---
>  lib/am/distdir.am | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)

The title says autoconf:, but the mail was sent to automake, and the
patch applies to the automake tree.  Is the title intentional?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #11 received at 20132 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eric Blake <eblake <at> redhat.com>, 20132 <at> debbugs.gnu.org
Subject: Re: bug#20132: [PROPOSED PATCH] autoconf: port better to future gzip
Date: Tue, 21 Apr 2015 06:55:05 -0700

Eric Blake wrote:
> Is the title intentional?

No, it's a typo, sorry: the title should have said "automake:", not "autoconf:".

Message #14 received at 20132 <at> debbugs.gnu.org (full text, mbox):

From: Pavel Raiskup <praiskup <at> redhat.com>
To: bug-gzip <at> gnu.org
Cc: 20104 <at> debbugs.gnu.org, 20132 <at> debbugs.gnu.org,
 Paul Eggert <eggert <at> cs.ucla.edu>, Jim Meyering <jim <at> meyering.net>,
 Mark Adler <madler <at> alumni.caltech.edu>
Subject: Re: bug#20104: [PATCH] gzip: make the GZIP env var obsolescent
Date: Tue, 28 Jun 2016 14:42:25 +0200

On Wednesday, March 18, 2015 2:40:29 PM CEST Jim Meyering wrote:
> On Tue, Mar 17, 2015 at 10:38 PM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
> > I did propose an Automake patch, here:
> >
> > http://bugs.gnu.org/20132
> 
> Glanced through, but didn't have time for a thorough review.

I don't see issue in that patch; as I believe there is only one 'gzip' (GNU)
and thus passing options via $GZIP was always equivalent to using options
(i.e. no other implementations which could ignore incompatible options in
$GZIP), sounds OK, thanks!

Because this issue (a) breaks Automake's package build (testsuite) in Fedora
where is a new gzip, and it (b) is probably not necessary to bother fedora's
maintainers with GZIP warning anyway, FWIW, I'm going to backport.

Pavel

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.