GNU bug report logs - #23343
25.0.93; URI schemes are not regexp-quoted for `goto-address-url-regexp'

Previous Next

Package: emacs;

Reported by: Phil Sainty <psainty <at> orcon.net.nz>

Date: Sat, 23 Apr 2016 13:52:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 25.0.93

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #17 received at 23343 <at> debbugs.gnu.org (full text, mbox):

From: Phil Sainty <psainty <at> orcon.net.nz>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 23343 <at> debbugs.gnu.org
Subject: Re: bug#23343: 25.0.93; [PATCH] URI schemes are not regexp-quoted for
 `goto-address-url-regexp'
Date: Mon, 25 Apr 2016 01:48:10 +1200
On 24/04/16 23:36, Lars Magne Ingebrigtsen wrote:
> Having variable defaults depend on each other can be awkward, especially
> when it's the "first" variable that users will realistically be
> tweaking.

Yes indeed. I don't especially like the way I've done it -- but it
seemed like an improvement, nevertheless.

>> +(defvar goto-address-uri-schemes
>
> I don't much value to this "intermediate" variable.  It just makes
> things even more complicated to work with, I think.

It's true that this one is an intermediate by default; but it's one
which users might potentially want to set in order to say "I don't
care about the default schemes at all; I only want the specific
schemes I've specified here to be matched."

So of the two new variables I'm adding, a user might set one or the
other depending on their needs. That was my line of thought, anyhow.

-Phil




This bug report was last modified 6 years and 19 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.