GNU bug report logs - #23344
25.0.93; (vc-call-backend 'Git 'mode-line-string default-directory)

Previous Next

Package: emacs;

Reported by: Leo Liu <sdl.web <at> gmail.com>

Date: Sat, 23 Apr 2016 14:33:02 UTC

Severity: normal

Found in version 25.0.93

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23344 in the body.
You can then email your comments to 23344 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#23344; Package emacs. (Sat, 23 Apr 2016 14:33:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Leo Liu <sdl.web <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 23 Apr 2016 14:33:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.93; (vc-call-backend 'Git 'mode-line-string default-directory)
Date: Sat, 23 Apr 2016 22:32:31 +0800

1. Open a directory under git in dired and eval
2. (progn (vc-file-clearprops default-directory)
          (vc-call-backend 'Git 'mode-line-string default-directory))
3. observe the odd string: "Git-04030c40afcef0b9b41fd79ad094c4a7d2c2cc27master"

Leo
Reply sent to Dmitry Gutov <dgutov <at> yandex.ru>:
You have taken responsibility. (Sat, 23 Apr 2016 19:23:01 GMT) Full text and rfc822 format available.
Notification sent to Leo Liu <sdl.web <at> gmail.com>:
bug acknowledged by developer. (Sat, 23 Apr 2016 19:23:02 GMT) Full text and rfc822 format available.

Message #10 received at 23344-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Leo Liu <sdl.web <at> gmail.com>, 23344-done <at> debbugs.gnu.org
Subject: Re: bug#23344: 25.0.93; (vc-call-backend 'Git 'mode-line-string
 default-directory)
Date: Sat, 23 Apr 2016 22:22:19 +0300

Hi Leo,

On 04/23/2016 05:32 PM, Leo Liu wrote:

> 1. Open a directory under git in dired and eval
> 2. (progn (vc-file-clearprops default-directory)
>           (vc-call-backend 'Git 'mode-line-string default-directory))
> 3. observe the odd string: "Git-04030c40afcef0b9b41fd79ad094c4a7d2c2cc27master"

Thanks for the report. I've fixed it in 87ee542.

Is there a particular place where you're calling `mode-line-string' on a 
directory, though?

The return value in this case is poorly defined, because the string 
includes a character indicator of the current VC state of FILE, and the 
VC API doesn't define VC states for directories.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23344; Package emacs. (Sun, 24 Apr 2016 01:23:02 GMT) Full text and rfc822 format available.

Message #13 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#23344: 25.0.93;
 (vc-call-backend 'Git 'mode-line-string default-directory)
Date: Sun, 24 Apr 2016 09:22:21 +0800

On 2016-04-23 22:22 +0300, Dmitry Gutov wrote:
> Is there a particular place where you're calling `mode-line-string' on
> a directory, though?

I use vc-mode-line on a directory. But it was broken after upgrading to
25.0.93 and the form in the subject is the culprit.

Thanks,
Leo
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23344; Package emacs. (Sun, 24 Apr 2016 09:53:02 GMT) Full text and rfc822 format available.

Message #16 received at 23344 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Leo Liu <sdl.web <at> gmail.com>, 23344 <at> debbugs.gnu.org
Subject: Re: bug#23344: 25.0.93; (vc-call-backend 'Git 'mode-line-string
 default-directory)
Date: Sun, 24 Apr 2016 12:52:48 +0300

On 04/24/2016 04:22 AM, Leo Liu wrote:

> I use vc-mode-line on a directory.

But where?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23344; Package emacs. (Sun, 24 Apr 2016 10:03:01 GMT) Full text and rfc822 format available.

Message #19 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#23344: 25.0.93;
 (vc-call-backend 'Git 'mode-line-string default-directory)
Date: Sun, 24 Apr 2016 18:01:47 +0800

On 2016-04-24 12:52 +0300, Dmitry Gutov wrote:
> But where?

For example, in eshell-mode-hook in my init.

Leo
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 22 May 2016 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 9 years and 82 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.