GNU bug report logs - #23343
25.0.93; URI schemes are not regexp-quoted for `goto-address-url-regexp'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23343 in the body.
You can then email your comments to 23343 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Phil Sainty <psainty <at> orcon.net.nz>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.93; URI schemes are not regexp-quoted for
 `goto-address-url-regexp'
Date: Sun, 24 Apr 2016 01:51:08 +1200

The URI schemes from `thing-at-point-uri-schemes' are concatenated
into a regexp group without being suitably escaped, meaning there
are bugs whenever regexp meta-characters appear. e.g.:

bzr+ssh://
iris.beep:

Message #8 received at 23343 <at> debbugs.gnu.org (full text, mbox):

From: Phil Sainty <psainty <at> orcon.net.nz>
To: 23343 <at> debbugs.gnu.org
Subject: bug#23343: 25.0.93; [PATCH] URI schemes are not regexp-quoted for
 `goto-address-url-regexp'
Date: Sun, 24 Apr 2016 02:02:40 +1200

[Message part 1 (text/plain, inline)]

This could be resolved with

-   (mapconcat 'identity
+   (mapconcat 'regexp-quote

But on account of 
http://stackoverflow.com/questions/36787889/how-to-remove-some-link-type-in-emacs
I thought that making it easier to customise this feature was a useful
improvement to make.


-Phil

[0001-Fix-goto-address-url-regexp.patch (text/x-patch, attachment)]

Message #11 received at 23343 <at> debbugs.gnu.org (full text, mbox):

From: Phil Sainty <psainty <at> orcon.net.nz>
To: 23343 <at> debbugs.gnu.org
Subject: Re: bug#23343: 25.0.93; [PATCH] URI schemes are not regexp-quoted for
 `goto-address-url-regexp'
Date: Sun, 24 Apr 2016 10:48:04 +1200

[Message part 1 (text/plain, inline)]

I've made docstring changes to point out that it's only useful to
set goto-address-uri-schemes-ignored and goto-address-uri-schemes
prior to loading the library.

I'm not sure if there's any policy about such things, but it seemed
like it would be quite a lot more work to get around that. I imagine
the :set ability of defcustom would make it possible to have changes
to those variables dynamically update goto-address-url-regexp as well;
but in doing that you'd need to take care not to clobber values which
had themselves been customized also, and it all seemed like a lot of
added complexity for little benefit.


-Phil

[0001-Fix-goto-address-url-regexp.patch (text/x-patch, attachment)]

Message #14 received at 23343 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Phil Sainty <psainty <at> orcon.net.nz>
Cc: 23343 <at> debbugs.gnu.org
Subject: Re: bug#23343: 25.0.93; [PATCH] URI schemes are not regexp-quoted for
 `goto-address-url-regexp'
Date: Sun, 24 Apr 2016 13:36:47 +0200

Phil Sainty <psainty <at> orcon.net.nz> writes:

> I've made docstring changes to point out that it's only useful to
> set goto-address-uri-schemes-ignored and goto-address-uri-schemes
> prior to loading the library.
>
> I'm not sure if there's any policy about such things, but it seemed
> like it would be quite a lot more work to get around that. I imagine
> the :set ability of defcustom would make it possible to have changes
> to those variables dynamically update goto-address-url-regexp as well;
> but in doing that you'd need to take care not to clobber values which
> had themselves been customized also, and it all seemed like a lot of
> added complexity for little benefit.

Having variable defaults depend on each other can be awkward, especially
when it's the "first" variable that users will realistically be
tweaking.

[...]

> +(defvar goto-address-uri-schemes-ignored
> +  ;; By default we exclude `mailto:' (email addresses are matched
> +  ;; by `goto-address-mail-regexp') and also `data:', as it is not
> +  ;; terribly useful to follow those URIs, and leaving them causes
> +  ;; `use Data::Dumper;' to be fontified oddly in Perl files.
> +  '("mailto:" "data:")

Which is this one.  But I don't really see how to fix that without
having a different interface here (i.e., getting rid of
goto-address-url-regexp), so perhaps it's OK...

But:

> +(defvar goto-address-uri-schemes
> +  ;; We use `thing-at-point-uri-schemes', with a few exclusions,
> +  ;; as listed in `goto-address-uri-schemes-ignored'.
> +  (seq-reduce (lambda (accum elt) (delete elt accum))
> +              goto-address-uri-schemes-ignored
> +              (copy-sequence thing-at-point-uri-schemes))

I don't much value to this "intermediate" variable.  It just makes
things even more complicated to work with, I think.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 23343 <at> debbugs.gnu.org (full text, mbox):

From: Phil Sainty <psainty <at> orcon.net.nz>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 23343 <at> debbugs.gnu.org
Subject: Re: bug#23343: 25.0.93; [PATCH] URI schemes are not regexp-quoted for
 `goto-address-url-regexp'
Date: Mon, 25 Apr 2016 01:48:10 +1200

On 24/04/16 23:36, Lars Magne Ingebrigtsen wrote:
> Having variable defaults depend on each other can be awkward, especially
> when it's the "first" variable that users will realistically be
> tweaking.

Yes indeed. I don't especially like the way I've done it -- but it
seemed like an improvement, nevertheless.

>> +(defvar goto-address-uri-schemes
>
> I don't much value to this "intermediate" variable.  It just makes
> things even more complicated to work with, I think.

It's true that this one is an intermediate by default; but it's one
which users might potentially want to set in order to say "I don't
care about the default schemes at all; I only want the specific
schemes I've specified here to be matched."

So of the two new variables I'm adding, a user might set one or the
other depending on their needs. That was my line of thought, anyhow.

-Phil

Message #22 received at 23343 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Phil Sainty <psainty <at> orcon.net.nz>
Cc: 23343 <at> debbugs.gnu.org
Subject: Re: bug#23343: 25.0.93; [PATCH] URI schemes are not regexp-quoted for
 `goto-address-url-regexp'
Date: Tue, 25 Jun 2019 16:02:37 +0200

Phil Sainty <psainty <at> orcon.net.nz> writes:

> It's true that this one is an intermediate by default; but it's one
> which users might potentially want to set in order to say "I don't
> care about the default schemes at all; I only want the specific
> schemes I've specified here to be matched."
>
> So of the two new variables I'm adding, a user might set one or the
> other depending on their needs. That was my line of thought, anyhow.

That's true.  I've now applied your patch to the Emacs trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.