GNU bug report logs - #21885
24.5; Transposing things with a negative argument

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21885 in the body.
You can then email your comments to 21885 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eli Barzilay <eli <at> barzilay.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.5; Transposing things with a negative argument
Date: Thu, 12 Nov 2015 03:12:07 -0500

[Message part 1 (text/plain, inline)]

In the past (IIRC, up to around v24.3) transposing things (chars,
words, sexprs, lines) would always leave the point after the
transposed thing.  This means that I could always use a `C--' prefix
to "drag" the current thing backwards in the same way that the default
action drags it forwards.  This is no longer happenning.

After a few trials the thing that seems to fix it is adding this line
at the end of the `transpose-subr' definition:

    (goto-char (+ (car pos2) (- (cdr pos1) (car pos1))))

To be clear, this is not a backward incompatible change -- it fixes
the *current* incompatible change.

Patch file attached.

[0001-Fix-transpose-subr-with-a-negative-argument.patch (application/octet-stream, attachment)]

[Message part 3 (text/plain, inline)]

-- 
                    ((x=>x(x))(x=>x(x)))                   Eli Barzilay:
                    http://barzilay.org/                   Maze is Life!

Message #8 received at 21885 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eli Barzilay <eli <at> barzilay.org>
Cc: 21885 <at> debbugs.gnu.org
Subject: Re: bug#21885: 24.5; Transposing things with a negative argument
Date: Thu, 12 Nov 2015 18:18:29 +0200

> From: Eli Barzilay <eli <at> barzilay.org>
> Date: Thu, 12 Nov 2015 03:12:07 -0500
> 
> In the past (IIRC, up to around v24.3) transposing things (chars,
> words, sexprs, lines) would always leave the point after the
> transposed thing.  This means that I could always use a `C--' prefix
> to "drag" the current thing backwards in the same way that the default
> action drags it forwards.  This is no longer happenning.

Could you please describe in more detail what do you see vs what you
expected?  I'm not sure I understand the problem; in particular, I do
see point "after the transposed thing", but maybe I don't understand
what you meant by that.

Thanks.

Message #11 received at 21885 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>, Eli Barzilay <eli <at> barzilay.org>
Cc: 21885 <at> debbugs.gnu.org
Subject: Re: bug#21885: 24.5; Transposing things with a negative argument
Date: Thu, 12 Nov 2015 19:00:35 +0100

> Could you please describe in more detail what do you see vs what you
> expected?  I'm not sure I understand the problem; in particular, I do
> see point "after the transposed thing", but maybe I don't understand
> what you meant by that.

Bug#20698?

martin

Message #14 received at 21885 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Leake <stephen_leake <at> stephe-leake.org>
To: Eli Barzilay <eli <at> barzilay.org>
Cc: 21885 <at> debbugs.gnu.org
Subject: Re: bug#21885: 24.5; Transposing things with a negative argument
Date: Thu, 12 Nov 2015 12:11:42 -0600

Eli Barzilay <eli <at> barzilay.org> writes:

> In the past (IIRC, up to around v24.3) transposing things (chars,
> words, sexprs, lines) would always leave the point after the
> transposed thing. ...  This is no longer happenning.

I can't reproduce this. In Emacs 24.3, emacs -Q, in *scratch* buffer,
where | is point:

fob|ar

invoke C-t transpose-char gives:

foab|r

Same behavior in emacs master.

Please post a recipe.

-- 
-- Stephe

Message #17 received at 21885 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: eli <at> barzilay.org, 21885 <at> debbugs.gnu.org
Subject: Re: bug#21885: 24.5; Transposing things with a negative argument
Date: Thu, 12 Nov 2015 20:17:23 +0200

> Date: Thu, 12 Nov 2015 19:00:35 +0100
> From: martin rudalics <rudalics <at> gmx.at>
> CC: 21885 <at> debbugs.gnu.org
> 
> > Could you please describe in more detail what do you see vs what you
> > expected?  I'm not sure I understand the problem; in particular, I do
> > see point "after the transposed thing", but maybe I don't understand
> > what you meant by that.
> 
> Bug#20698?

Looks like that, thanks.

Message #20 received at 21885 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stephen Leake <stephen_leake <at> stephe-leake.org>
Cc: eli <at> barzilay.org, 21885 <at> debbugs.gnu.org
Subject: Re: bug#21885: 24.5; Transposing things with a negative argument
Date: Thu, 12 Nov 2015 20:24:20 +0200

> From: Stephen Leake <stephen_leake <at> stephe-leake.org>
> Date: Thu, 12 Nov 2015 12:11:42 -0600
> Cc: 21885 <at> debbugs.gnu.org
> 
> Eli Barzilay <eli <at> barzilay.org> writes:
> 
> > In the past (IIRC, up to around v24.3) transposing things (chars,
> > words, sexprs, lines) would always leave the point after the
> > transposed thing. ...  This is no longer happenning.
> 
> I can't reproduce this. In Emacs 24.3, emacs -Q, in *scratch* buffer,
> where | is point:
> 
> fob|ar
> 
> invoke C-t transpose-char gives:
> 
> foab|r
> 
> Same behavior in emacs master.

I think I know the answer: the difference is visible only if you
invoke C-t with a negative argument, as in "C-- C-t".

Message #23 received at 21885 <at> debbugs.gnu.org (full text, mbox):

From: Eli Barzilay <eli <at> barzilay.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: martin rudalics <rudalics <at> gmx.at>,
 Stephen Leake <stephen_leake <at> stephe-leake.org>, 21885 <at> debbugs.gnu.org
Subject: Re: bug#21885: 24.5; Transposing things with a negative argument
Date: Thu, 12 Nov 2015 14:27:07 -0500

On Thu, Nov 12, 2015 at 1:24 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> From: Stephen Leake <stephen_leake <at> stephe-leake.org>
>> Date: Thu, 12 Nov 2015 12:11:42 -0600
>> Cc: 21885 <at> debbugs.gnu.org
>>
>> Eli Barzilay <eli <at> barzilay.org> writes:
>>
>> > In the past (IIRC, up to around v24.3) transposing things (chars,
>> > words, sexprs, lines) would always leave the point after the
>> > transposed thing. ...  This is no longer happenning.
> [...]
>
> I think I know the answer: the difference is visible only if you
> invoke C-t with a negative argument, as in "C-- C-t".

Yes, exactly -- and yes, this is the same bug as #20698.  I looked at
the code a bit more since then, and I think that my patch is a fine fix.

-- 
                    ((x=>x(x))(x=>x(x)))                   Eli Barzilay:
                    http://barzilay.org/                   Maze is Life!

Message #30 received at 21885-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eli Barzilay <eli <at> barzilay.org>
Cc: 21885-done <at> debbugs.gnu.org, stephen_leake <at> stephe-leake.org, rudalics <at> gmx.at
Subject: Re: bug#21885: 24.5; Transposing things with a negative argument
Date: Fri, 13 Nov 2015 11:47:54 +0200

> Date: Thu, 12 Nov 2015 14:27:07 -0500
> From: Eli Barzilay <eli <at> barzilay.org>
> Cc: Stephen Leake <stephen_leake <at> stephe-leake.org>, 21885 <at> debbugs.gnu.org, 
> 	martin rudalics <rudalics <at> gmx.at>
> 
> On Thu, Nov 12, 2015 at 1:24 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> >> From: Stephen Leake <stephen_leake <at> stephe-leake.org>
> >> Date: Thu, 12 Nov 2015 12:11:42 -0600
> >> Cc: 21885 <at> debbugs.gnu.org
> >>
> >> Eli Barzilay <eli <at> barzilay.org> writes:
> >>
> >> > In the past (IIRC, up to around v24.3) transposing things (chars,
> >> > words, sexprs, lines) would always leave the point after the
> >> > transposed thing. ...  This is no longer happenning.
> > [...]
> >
> > I think I know the answer: the difference is visible only if you
> > invoke C-t with a negative argument, as in "C-- C-t".
> 
> Yes, exactly -- and yes, this is the same bug as #20698.  I looked at
> the code a bit more since then, and I think that my patch is a fine fix.

Thanks, pushed.

Message #38 received at 21885 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, 21885 <at> debbugs.gnu.org,
 Eli Barzilay <eli <at> barzilay.org>
Cc: 21885-done <at> debbugs.gnu.org, Stephen Leake <stephen_leake <at> stephe-leake.org>
Subject: Re: bug#21885: 24.5; Transposing things with a negative argument
Date: Fri, 13 Nov 2015 14:13:37 +0100

[Message part 1 (text/plain, inline)]

On Fri, Nov 13, 2015 at 10:47 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> Thanks, pushed.

Commit a731c2f163071ed6efe7d93fa9585dd66ddf2fbb adds a test for this bug
(based on the use case in bug#20698).

[Message part 2 (text/html, inline)]

Message #44 received at 21885 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 21885-done <at> debbugs.gnu.org, eli <at> barzilay.org,
 stephen_leake <at> stephe-leake.org, 21885 <at> debbugs.gnu.org
Subject: Re: bug#21885: 24.5; Transposing things with a negative argument
Date: Fri, 13 Nov 2015 15:36:12 +0200

> From: Juanma Barranquero <lekktu <at> gmail.com>
> Date: Fri, 13 Nov 2015 14:13:37 +0100
> Cc: 21885-done <at> debbugs.gnu.org, Stephen Leake <stephen_leake <at> stephe-leake.org>
> 
> On Fri, Nov 13, 2015 at 10:47 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> > Thanks, pushed.
> 
> Commit a731c2f163071ed6efe7d93fa9585dd66ddf2fbb adds a test for this bug (based
> on the use case in bug#20698).

Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.