GNU bug report logs - #19698
Use bool, not int, to flag face changes

Previous Next

Package: emacs;

Reported by: Paul Eggert <eggert <at> cs.ucla.edu>

Date: Tue, 27 Jan 2015 01:19:02 UTC

Severity: wishlist

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Subject: bug#19698: closed (Re: Use bool, not int, to flag face changes)
Date: Wed, 28 Jan 2015 19:18:03 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#19698: Use bool, not int, to flag face changes

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 19698 <at> debbugs.gnu.org.

-- 
19698: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19698
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 19698-done <at> debbugs.gnu.org
Subject: Re: Use bool, not int, to flag face changes
Date: Wed, 28 Jan 2015 11:16:54 -0800
On 01/27/2015 10:20 AM, Eli Zaretskii wrote:
>> Date: Mon, 26 Jan 2015 17:18:12 -0800
>> From: Paul Eggert <eggert <at> cs.ucla.edu>
>> CC: Eli Zaretskii <eliz <at> gnu.org>
>>
>> Attached is a minor patch to simplify the xfaces.c code by using a bool flag
>> 'face_change' instead of an int counter 'face_change_count'.  This affects the
>> MS-Windows port so I'm filing it as a bug report to give Eli a heads-up.
> Thanks, it looks good to me.

Thanks for checking.  I commited it to master as 
cdee38ab61b383f1190d29470319bce3693c7dd9 and marking this as done.

[Message part 3 (message/rfc822, inline)]
From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Emacs bug reports and feature requests <bug-gnu-emacs <at> gnu.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: Use bool, not int, to flag face changes
Date: Mon, 26 Jan 2015 17:18:12 -0800
[Message part 4 (text/plain, inline)]
Tags: patch
Severity: wishlist

Attached is a minor patch to simplify the xfaces.c code by using a bool flag 
'face_change' instead of an int counter 'face_change_count'.  This affects the 
MS-Windows port so I'm filing it as a bug report to give Eli a heads-up.
[0001-Use-bool-not-int-to-track-face-changes.patch (text/x-patch, attachment)]

This bug report was last modified 10 years and 118 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.