GNU bug report logs - #19698
Use bool, not int, to flag face changes

Previous Next

Package: emacs;

Reported by: Paul Eggert <eggert <at> cs.ucla.edu>

Date: Tue, 27 Jan 2015 01:19:02 UTC

Severity: wishlist

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19698 in the body.
You can then email your comments to 19698 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#19698; Package emacs. (Tue, 27 Jan 2015 01:19:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Paul Eggert <eggert <at> cs.ucla.edu>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 27 Jan 2015 01:19:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Emacs bug reports and feature requests <bug-gnu-emacs <at> gnu.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: Use bool, not int, to flag face changes
Date: Mon, 26 Jan 2015 17:18:12 -0800

[Message part 1 (text/plain, inline)]
Tags: patch
Severity: wishlist

Attached is a minor patch to simplify the xfaces.c code by using a bool flag 
'face_change' instead of an int counter 'face_change_count'.  This affects the 
MS-Windows port so I'm filing it as a bug report to give Eli a heads-up.

[0001-Use-bool-not-int-to-track-face-changes.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19698; Package emacs. (Tue, 27 Jan 2015 18:21:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: Use bool, not int, to flag face changes
Date: Tue, 27 Jan 2015 20:20:33 +0200

> Date: Mon, 26 Jan 2015 17:18:12 -0800
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> CC: Eli Zaretskii <eliz <at> gnu.org>
> 
> Attached is a minor patch to simplify the xfaces.c code by using a bool flag 
> 'face_change' instead of an int counter 'face_change_count'.  This affects the 
> MS-Windows port so I'm filing it as a bug report to give Eli a heads-up.

Thanks, it looks good to me.
Reply sent to Paul Eggert <eggert <at> cs.ucla.edu>:
You have taken responsibility. (Wed, 28 Jan 2015 19:18:02 GMT) Full text and rfc822 format available.
Notification sent to Paul Eggert <eggert <at> cs.ucla.edu>:
bug acknowledged by developer. (Wed, 28 Jan 2015 19:18:03 GMT) Full text and rfc822 format available.

Message #13 received at 19698-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 19698-done <at> debbugs.gnu.org
Subject: Re: Use bool, not int, to flag face changes
Date: Wed, 28 Jan 2015 11:16:54 -0800

On 01/27/2015 10:20 AM, Eli Zaretskii wrote:
>> Date: Mon, 26 Jan 2015 17:18:12 -0800
>> From: Paul Eggert <eggert <at> cs.ucla.edu>
>> CC: Eli Zaretskii <eliz <at> gnu.org>
>>
>> Attached is a minor patch to simplify the xfaces.c code by using a bool flag
>> 'face_change' instead of an int counter 'face_change_count'.  This affects the
>> MS-Windows port so I'm filing it as a bug report to give Eli a heads-up.
> Thanks, it looks good to me.

Thanks for checking.  I commited it to master as 
cdee38ab61b383f1190d29470319bce3693c7dd9 and marking this as done.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 26 Feb 2015 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 10 years and 118 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.