GNU bug report logs - #18467
24.4.50; calendar-update-mode-line: Do not overwrite mode-line-format unconditionally

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Schmidt <ch <at> ristopher.com>
Subject: bug#18467: closed (Re: bug#18467: 24.4.50; calendar-update-mode-line:
 Do not overwrite mode-line-format unconditionally)
Date: Sat, 13 Sep 2014 17:55:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#18467: 24.4.50; calendar-update-mode-line: Do not overwrite mode-line-format unconditionally

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 18467 <at> debbugs.gnu.org.

-- 
18467: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18467
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Schmidt <ch <at> ristopher.com>
To: 18467-done <at> debbugs.gnu.org
Subject: Re: bug#18467: 24.4.50;
 calendar-update-mode-line: Do not overwrite mode-line-format
 unconditionally
Date: Sat, 13 Sep 2014 13:54:53 -0400 (EDT)

Glenn Morris <rgm <at> gnu.org> writes:
> Fine by me; please apply to trunk, maybe with a 1-line mention in
> NEWS?  Thanks.

Thanks; done.

[Message part 3 (message/rfc822, inline)]

From: Christopher Schmidt <ch <at> ristopher.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; calendar-update-mode-line: Do not overwrite mode-line-format
 unconditionally
Date: Sat, 13 Sep 2014 05:48:40 -0400 (EDT)

[Message part 4 (text/plain, inline)]

severity: wishlist

[Message part 5 (text/x-diff, inline)]

--- lisp/ChangeLog
+++ lisp/ChangeLog
@@ -1,3 +1,9 @@
+2014-09-13  Christopher Schmidt  <ch <at> ristopher.com>
+
+	* calendar/calendar.el (calendar-update-mode-line):
+	Do not overwrite mode-line-format if calendar-mode-line-format is
+	nil.  (Bug##)
+
 2014-09-13  Eli Zaretskii  <eliz <at> gnu.org>

        * mail/rmailmm.el (rmail-mime-insert-html): Decode the HTML part
--- lisp/calendar/calendar.el
+++ lisp/calendar/calendar.el
@@ -1804,14 +1804,18 @@
                               nil "today"))
    '(calendar-date-string (calendar-current-date) t)
    (calendar-mode-line-entry 'calendar-scroll-left "next month" ">"))
-  "The mode line of the calendar buffer.
+  "If non-nil, the mode line of the calendar buffer.
 This is a list of items that evaluate to strings.  The elements
 are evaluated and concatenated, evenly separated by blanks.
 During evaluation, the variable `date' is available as the date
 nearest the cursor (or today's date if that fails).  To update
-the mode-line as the cursor moves, add `calendar-update-mode-line'
-to `calendar-move-hook'.  Here is an example that has the Hebrew date,
-the day number/days remaining in the year, and the ISO week/year numbers:
+the mode-line as the cursor moves, add
+`calendar-update-mode-line' to `calendar-move-hook'.
+
+If nil, do not modify the mode line at all.
+
+Here is an example that has the Hebrew date, the day number/days
+remaining in the year, and the ISO week/year numbers:

   (list
    \"\"
@@ -1889,7 +1893,8 @@

 (defun calendar-update-mode-line ()
   "Update the calendar mode line with the current date and date style."
-  (if (bufferp (get-buffer calendar-buffer))
+  (if (and calendar-mode-line-format
+           (bufferp (get-buffer calendar-buffer)))
       (with-current-buffer calendar-buffer
         (let ((start (- calendar-left-margin 2))
               (date (condition-case nil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.