GNU bug report logs - #18468
Issues with alignment and m68k register naming

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18468 in the body.
You can then email your comments to 18468 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rob Browning <rlb <at> defaultvalue.org>
To: bug-guile <at> gnu.org
Cc: 649718-forwarded <at> bugs.debian.org, Thorsten Glaser <tg <at> mirbsd.de>,
 649718 <at> bugs.debian.org
Subject: Issues with alignment and m68k register naming
Date: Sat, 13 Sep 2014 13:37:42 -0500

[Message part 1 (text/plain, inline)]

[If possible, please preserve the -forwarded address in any replies.]

This was reported to Debian a bit back, and I thought it might be
appropriate for consideration upstream.

Further details can be found here:

  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=649718

And here's a standalone version of the patch from the debdiff there:

[9000-Fix-alignment-and-m68k-registers.patch (text/x-diff, inline)]

From schwab <at> linux-m68k.org Mon May 12 18:37:51 2014
From: Andreas Schwab <schwab <at> linux-m68k.org>
Message-ID: <87y4y7uf4y.fsf <at> igel.home>
To: Thorsten Glaser <t.glaser <at> tarent.de>
Cc: Manoj Srivastava <srivasta <at> debian.org>, debian-68k <at> lists.debian.org
Date: Mon, 12 May 2014 18:37:49 +0200
X-Original-Subject: Re: Guile language support in make
Subject: Fix alignment and registers for m68k

Fix bogus alignment assumptions (on some architectures, “natural”
alignment is not used, which means even an uint64_t is possibly
unaligned, or aligned to only a 2 byte (m68k) or 4 byte boundary).

Also, fix register name for m68k.
--

Thorsten Glaser <t.glaser <at> tarent.de> writes:

> and the guile-2.0 Build-Depends on m68k because guile does not
> work there (and nobody appears capable enough to debug it)?

--- a/libguile/gsubr.c
+++ b/libguile/gsubr.c
@@ -213,7 +213,7 @@
 */
 static const struct
 {
-  scm_t_uint64 dummy; /* ensure 8-byte alignment; perhaps there's a better way */
+  scm_t_uint64 dummy SCM_ALIGNED (sizeof (scm_t_uint64)); /* ensure 8-byte alignment; perhaps there's a better way */
   const scm_t_uint8 bytes[121 * (sizeof (struct scm_objcode) + 16
                                  + sizeof (struct scm_objcode) + 32)];
 } raw_bytecode = {
@@ -317,7 +317,7 @@ static const struct
 
 static const struct
 {
-  scm_t_uint64 dummy; /* alignment */
+  scm_t_uint64 dummy SCM_ALIGNED (sizeof (scm_t_uint64)); /* alignment */
   scm_t_cell cells[121 * 2]; /* 11*11 double cells */
 } objcode_cells = {
   0,
--- a/libguile/vm-engine.h
+++ b/libguile/vm-engine.h
@@ -74,7 +74,7 @@
 #define FP_REG asm("%r16")
 #endif
 #ifdef __mc68000__
-#define IP_REG asm("a5")
+#define IP_REG asm("a3")
 #define SP_REG asm("a4")
 #define FP_REG
 #endif

[Message part 3 (text/plain, inline)]

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

Message #8 received at 18468 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Rob Browning <rlb <at> defaultvalue.org>
Cc: 649718-forwarded <at> bugs.debian.org, 18468 <at> debbugs.gnu.org,
 Thorsten Glaser <tg <at> mirbsd.de>, 649718 <at> bugs.debian.org
Subject: Re: bug#18468: Issues with alignment and m68k register naming
Date: Sat, 20 Sep 2014 08:52:53 -0400

>   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=649718

I pushed slightly different fixes to the stable-2.0 branch,
commits 97c520fd3ff5ae0305b6d236e0bc31f794a6cce6 and
156119b0223cf14d335ebda84701a69b2ba95757.

I'm closing this bug now.

     Thanks!
       Mark

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.