GNU bug report logs - #1817
last-input-char

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1817 in the body.
You can then email your comments to 1817 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.60; C-x RET c RET RET signals an error
Date: Wed, 07 Jan 2009 19:54:55 +0200

In response to the closed and archived bug#1205:

>>   C-x RET c utf-8 RET C-x C-g
>> produces an unexpected error message:
>>   Wrong type argument: commandp, nil
>
> Perhaps this:
> *** mule-cmds.el         5 Oct 2008 19:07:03 -0000 1.341
> --- mule-cmds.el         21 Oct 2008 02:52:14 -0000
> ***************
> *** 287,292 ****
> --- 287,295 ----
>      (cmd (key-binding keyseq))
>       prefix)
>
> +     (if (char-equal last-input-char ?\C-g)
> +     (keyboard-quit))
> +

I just noticed that this fix in `universal-coding-system-argument'
causes another bug.  It fails with the key sequence `C-x RET c RET RET'
that signals an error:

Debugger entered--Lisp error: (wrong-type-argument characterp return)
  char-equal(return 7)
  universal-coding-system-argument(utf-8-unix)
  call-interactively(universal-coding-system-argument nil nil)

In GNU Emacs 23.0.60 (x86_64-pc-linux-gnu) of 2009-01-06

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #8 received at 1817 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Juri Linkov <juri <at> jurta.org>
Cc: 1817 <at> debbugs.gnu.org
Subject: Re: bug#1817: 23.0.60; C-x RET c RET RET signals an error
Date: Wed, 07 Jan 2009 13:44:48 -0500

merge 1205 1817
stop

Juri Linkov wrote:

> In response to the closed and archived bug#1205:

You can unarchive it, as I did prior to this.

>> +     (if (char-equal last-input-char ?\C-g)
>> +     (keyboard-quit))
>> +
>
> I just noticed that this fix in `universal-coding-system-argument'
> causes another bug.  It fails with the key sequence `C-x RET c RET RET'
> that signals an error:
>
> Debugger entered--Lisp error: (wrong-type-argument characterp return)
>   char-equal(return 7)


It's suprising (to me) that last-input-char might not be a character,
but just change `char-equal' to `equal'.

Message #15 received at 1817 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 1817 <at> debbugs.gnu.org
Subject: Re: bug#1817: 23.0.60; C-x RET c RET RET signals an error
Date: Wed, 07 Jan 2009 21:27:27 +0200

>> In response to the closed and archived bug#1205:
>
> You can unarchive it, as I did prior to this.

Thanks, I missed the `unarchive' command.

>>> +     (if (char-equal last-input-char ?\C-g)
>>> +     (keyboard-quit))
>>
>> I just noticed that this fix in `universal-coding-system-argument'
>> causes another bug.  It fails with the key sequence `C-x RET c RET RET'
>> that signals an error:
>>
>> Debugger entered--Lisp error: (wrong-type-argument characterp return)
>>   char-equal(return 7)
>
> It's suprising (to me) that last-input-char might not be a character,
> but just change `char-equal' to `equal'.

The variable name `last-input-char' is confusing.
It holds an input event, not just a character.
But as I see, its alias is `last-input-event'.
And (info "(elisp) Event Input Misc") says:

     The alias `last-input-char' exists for compatibility
     with Emacs version 18.

So I perhaps the doc string of `last-input-char' should say
that it is an alias for `last-input-event'?

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #18 received at 1817 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Juri Linkov <juri <at> jurta.org>
Cc: 1817 <at> debbugs.gnu.org
Subject: Re: bug#1817: 23.0.60; C-x RET c RET RET signals an error
Date: Wed, 07 Jan 2009 15:00:46 -0500

Juri Linkov wrote:

>      The alias `last-input-char' exists for compatibility
>      with Emacs version 18.
>
> So I perhaps the doc string of `last-input-char' should say
> that it is an alias for `last-input-event'?

Definitely, and an obsolete one too, it sounds like.
Can't it be made a "real" alias?

The comment is also misleading:

  /* Last input character read for any purpose.  */
  Lisp_Object last_input_char;


last-command-char looks similar.

Message #31 received at 1817 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 1817 <at> debbugs.gnu.org, Juri Linkov <juri <at> jurta.org>
Subject: Re: bug#1817: 23.0.60; C-x RET c RET RET signals an error
Date: Thu, 08 Jan 2009 12:00:47 -0500

>> The alias `last-input-char' exists for compatibility
>> with Emacs version 18.
>> 
>> So I perhaps the doc string of `last-input-char' should say
>> that it is an alias for `last-input-event'?

> Definitely, and an obsolete one too, it sounds like.
> Can't it be made a "real" alias?

That would be good, yes: Remove last-input-char from the C code, and
define it in subr.el via define-obsolete-variable-alias.

> last-command-char looks similar.

Then please fix it similarly.


        Stefan

Message #36 received at 1817-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 1817-done <at> debbugs.gnu.org
Subject: Re: bug#1817: 23.0.60; C-x RET c RET RET signals an error
Date: Thu, 08 Jan 2009 22:30:17 -0500

Stefan Monnier wrote:

> That would be good, yes: Remove last-input-char from the C code, and
> define it in subr.el via define-obsolete-variable-alias.
>
>> last-command-char looks similar.
>
> Then please fix it similarly.

done & done

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.