GNU bug report logs - #1205
23.0.60; C-x RET c FOO C-x C-g signals an error

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1205 in the body.
You can then email your comments to 1205 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.60; C-x RET c FOO C-x C-g signals an error
Date: Sun, 19 Oct 2008 17:12:33 +0200

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug <at> gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

  emacs -Q
  C-x RET c utf-8 RET C-x C-g

produces an unexpected error message:

  Wrong type argument: commandp, nil

(What happened here is that I changed my mind after typing the second
C-x and wanted to bail out.  I expected to see "Quit", not an error.)

The problem happens no matter what coding-system you use instead of
utf-8.


If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
d:/gnu/emacs/etc/DEBUG for instructions.


In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-10-19 on HOME-C4E4A596F7
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1255
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  shell-dirtrack-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<down> <down> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <C-right> <C-right> <C-right> <C-right> <C-right> 
<C-right> <C-right> <C-right> <C-right> <left> <left> 
<left> <left> <left> r C-x C-s C-x C-x C-g <up> <up> 
<up> <up> <up> <up> <up> <up> <C-left> <C-left> C-r 
C-w C-w C-w C-r C-s C-s <prior> <prior> <next> <prior> 
<next> <next> <prior> <prior> <next> <next> M-x s h 
e l l - c o m m <tab> <return> l s <tab> . e <tab> 
d : / g <tab> n <tab> C-h c <tab> e m <tab> SPC C-g 
M-! l s C-h c <tab> C-g C-h f m i n i b u f f e r - 
c o m p l e t e - s h e <tab> <return> C-x C-x C-g 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <up> <up> <up> <up> C-r 
m i n i b C-g C-x o C-x o C-SPC C-x o <down> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <return> C-g <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <down> <down> <up> <down> <down> <down> <down> 
<down> <down> <down> <down> <C-left> <left> <left> 
C-h v <return> C-M-v C-x o <prior> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <help-echo> <help-echo> <help-echo> 
M-! l s SPC d : / g n <tab> e m a <tab> / l i s <tab> 
<left> <left> <left> <left> <left> <tab> <down-mouse-2> 
<mouse-2> <C-left> <C-left> <C-left> C-SPC <C-right> 
<C-right> <C-right> <C-right> C-g C-x o C-x <return> 
c u t f - 8 <return> C-x C-g <help-echo> M-x r e p 
o r t - e m a <tab> <return>

Recent messages:
Saving file d:/gnu/emacs/lisp/simple.el...
Wrote d:/gnu/emacs/lisp/simple.el
Quit
Mark saved where search started
TAB (translated from <tab>) runs the command minibuffer-complete-shell-command
Quit
TAB (translated from <tab>) runs the command minibuffer-complete-shell-command
Quit [3 times]
Mark set
Quit [2 times]
universal-coding-system-argument: Wrong type argument: commandp, nil

Message #8 received at 1205 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 1205 <at> debbugs.gnu.org
Subject: Re: bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error
Date: Mon, 20 Oct 2008 22:50:46 -0400

Eli Zaretskii wrote:

>   emacs -Q
>   C-x RET c utf-8 RET C-x C-g
>
> produces an unexpected error message:
>
>   Wrong type argument: commandp, nil


Perhaps this:


*** mule-cmds.el         5 Oct 2008 19:07:03 -0000 1.341
--- mule-cmds.el         21 Oct 2008 02:52:14 -0000
***************
*** 287,292 ****
--- 287,295 ----
     (cmd (key-binding keyseq))
      prefix)
  
+     (if (char-equal last-input-char ?\C-g)
+     (keyboard-quit))
+ 
      (when (memq cmd '(universal-argument digit-argument))
        (call-interactively cmd)
  

Message #13 received at 1205 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 1205 <at> debbugs.gnu.org
Subject: Re: bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error
Date: Tue, 21 Oct 2008 08:32:45 +0200

> From: Glenn Morris <rgm <at> gnu.org>
> Cc: 1205 <at> emacsbugs.donarmstrong.com
> Date: Mon, 20 Oct 2008 22:50:46 -0400
> 
> Eli Zaretskii wrote:
> 
> >   emacs -Q
> >   C-x RET c utf-8 RET C-x C-g
> >
> > produces an unexpected error message:
> >
> >   Wrong type argument: commandp, nil
> 
> 
> Perhaps this:
> 
> 
> *** mule-cmds.el         5 Oct 2008 19:07:03 -0000 1.341
> --- mule-cmds.el         21 Oct 2008 02:52:14 -0000
> ***************
> *** 287,292 ****
> --- 287,295 ----
>      (cmd (key-binding keyseq))
>       prefix)
>   
> +     (if (char-equal last-input-char ?\C-g)
> +     (keyboard-quit))
> + 
>       (when (memq cmd '(universal-argument digit-argument))
>         (call-interactively cmd)

Looks correct to me.  Thanks.

Message #18 received at 1205 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Andreas Schwab <schwab <at> suse.de>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 1205 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error
Date: Tue, 21 Oct 2008 10:52:29 +0200

Glenn Morris <rgm <at> gnu.org> writes:

> +     (if (char-equal last-input-char ?\C-g)

quit_char may not be C-g.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab <at> suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #23 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kevin Rodgers <kevin.d.rodgers <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error
Date: Tue, 21 Oct 2008 20:42:58 -0600

Andreas Schwab wrote:
> Glenn Morris <rgm <at> gnu.org> writes:
> 
>> +     (if (char-equal last-input-char ?\C-g)
> 
> quit_char may not be C-g.

So ?\C-g should be expressed instead as (nth 3 (current-input-mode)),
correct?

-- 
Kevin Rodgers
Denver, Colorado, USA

Message #28 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Kevin Rodgers'" <kevin.d.rodgers <at> gmail.com>,
        <1205 <at> debbugs.gnu.org>, <bug-gnu-emacs <at> gnu.org>
Subject: RE: bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error
Date: Tue, 21 Oct 2008 22:17:51 -0700

> >> +     (if (char-equal last-input-char ?\C-g)
> > 
> > quit_char may not be C-g.
> 
> So ?\C-g should be expressed instead as (nth 3 (current-input-mode)),
> correct?

Essentially the question I asked emacs-devel today (based on this thread, though
I had forgotten where I saw it). See emacs-devel thread "question about
`quit-char'", FYI.

The answer I got was no, not in Emacs 23 (or 22 or 21...). Later, maybe. 

There was a fair amount of noise and distraction in the thread, but that's the
answer I took away for this question.

Message #38 received at 1205-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 1205-done <at> debbugs.gnu.org
Subject: Re: bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error
Date: Wed, 22 Oct 2008 02:45:23 -0400

2008-10-22  Glenn Morris  <rgm <at> gnu.org>

   * international/mule-cmds.el (universal-coding-system-argument):
     Check for C-g.  (Bug#1205)

Message #43 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kevin Rodgers <kevin.d.rodgers <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error
Date: Wed, 22 Oct 2008 01:05:22 -0600

Drew Adams wrote:
>>>> +     (if (char-equal last-input-char ?\C-g)
>>> quit_char may not be C-g.
>> So ?\C-g should be expressed instead as (nth 3 (current-input-mode)),
>> correct?
> 
> Essentially the question I asked emacs-devel today (based on this thread, though
> I had forgotten where I saw it). See emacs-devel thread "question about
> `quit-char'", FYI.
> 
> The answer I got was no, not in Emacs 23 (or 22 or 21...). Later, maybe. 
> 
> There was a fair amount of noise and distraction in the thread, but that's the
> answer I took away for this question.

That's not the conclusion I came to, which is: You should feel fairly
confident in binding C-g as a quit character in your code, but
Emacs itself should continue to fully support current-input-mode/
set-input-mode -- unless and until a decision is reached to deprecate
the QUIT functionality they provide.

-- 
Kevin Rodgers
Denver, Colorado, USA

Message #48 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Kevin Rodgers <kevin.d.rodgers <at> gmail.com>
Cc: 1205 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error
Date: Wed, 22 Oct 2008 11:00:29 -0400

> That's not the conclusion I came to, which is: You should feel fairly
> confident in binding C-g as a quit character in your code, but
> Emacs itself should continue to fully support current-input-mode/
> set-input-mode -- unless and until a decision is reached to deprecate
> the QUIT functionality they provide.

I believe the conclusion of thread is that we should keep doing it the
simple way until either we remove the functionality or we fix all the
code to support the functionality reliably.


        Stefan

Message #58 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Kevin Rodgers'" <kevin.d.rodgers <at> gmail.com>,
        <1205 <at> debbugs.gnu.org>, <bug-gnu-emacs <at> gnu.org>
Subject: RE: bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error
Date: Wed, 22 Oct 2008 09:20:35 -0700

> >>>> +     (if (char-equal last-input-char ?\C-g)
> >>> quit_char may not be C-g.
> >> So ?\C-g should be expressed instead as (nth 3 
> >> (current-input-mode)), correct?
> > 
> > Essentially the question I asked emacs-devel today (based 
> > on this thread, though I had forgotten where I saw it).
> > See emacs-devel thread "question about `quit-char'", FYI.
> > 
> > The answer I got was no, not in Emacs 23 (or 22 or 21...). 
> > Later, maybe. 
> > 
> > There was a fair amount of noise and distraction in the 
> > thread, but that's the answer I took away for this question.
> 
> That's not the conclusion I came to, which is: You should feel fairly
> confident in binding C-g as a quit character in your code, but
> Emacs itself should continue to fully support current-input-mode/
> set-input-mode -- unless and until a decision is reached to deprecate
> the QUIT functionality they provide.

OK, I didn't mean to pronounce on what Emacs would/should support, but rather to
communicate the part about what users should do now in their code. My reading
was not just that one can feel confident using C-g now but that that is what one
should do, for now.

But anyway, you've obviously read the thread, and all I wanted to do was bring
it to your attention.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.