GNU bug report logs - #17204
[PATCH] grep: speed-up for exact matching with begline and endline constraints

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Sun, 6 Apr 2014 09:56:02 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Subject: bug#17204: closed (Re: bug#17204: [PATCH] grep: speed-up for
 exact matching with begline and endline constraints)
Date: Mon, 21 Apr 2014 14:59:03 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#17204: [PATCH] grep: speed-up for exact matching with begline and endline constraints

which was filed against the grep package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 17204 <at> debbugs.gnu.org.

-- 
17204: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17204
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 17204-done <at> debbugs.gnu.org
Subject: Re: bug#17204: [PATCH] grep: speed-up for exact matching with begline
 and endline constraints
Date: Mon, 21 Apr 2014 07:58:43 -0700
[Message part 3 (text/plain, inline)]
Thanks, I looked at that, got derailed by finding and fixing a bug with 
NUL bytes that turned out to be a pre-existing bug, and finally 
installed it just now, with a slightly-reworded commit message.  I also 
installed the attached minor-improvement patch as well (some of it 
cleans up preexisting code in the neighborhood).
[0001-dfa-minor-improvements-to-previous-patch.patch (text/plain, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] grep: speed-up for exact matching with begline and endline
 constraints
Date: Sun, 06 Apr 2014 18:55:03 +0900
[Message part 6 (text/plain, inline)]
dfamust turns on the flag when a state exactly matches the proposed one.
However, when the state has begline and/or endline constraints, turns
off it.

This patch enables to match a state exactly, even if the state has
begline and/or endline constraints.  If a exact string has one of their
constrations, the string adding eolbyte to a head and/or foot is pushed
to kwsincr().  In addition, if it has begline constration, start
searching from just before the position of the text.

Norihiro
[patch.txt (text/plain, attachment)]

This bug report was last modified 11 years and 38 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.