GNU bug report logs - #17204
[PATCH] grep: speed-up for exact matching with begline and endline constraints

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17204 in the body.
You can then email your comments to 17204 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] grep: speed-up for exact matching with begline and endline
 constraints
Date: Sun, 06 Apr 2014 18:55:03 +0900

[Message part 1 (text/plain, inline)]

dfamust turns on the flag when a state exactly matches the proposed one.
However, when the state has begline and/or endline constraints, turns
off it.

This patch enables to match a state exactly, even if the state has
begline and/or endline constraints.  If a exact string has one of their
constrations, the string adding eolbyte to a head and/or foot is pushed
to kwsincr().  In addition, if it has begline constration, start
searching from just before the position of the text.

Norihiro

[patch.txt (text/plain, attachment)]

Message #8 received at 17204 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 17204 <at> debbugs.gnu.org
Subject: bug#17204: [PATCH] grep: speed-up for exact matching with begline and
 endline constraints
Date: Tue, 08 Apr 2014 22:30:45 +0900

[Message part 1 (text/plain, inline)]

I rebased this patch.  I also changed some variables into `bool'.

[patch.txt (text/plain, attachment)]

Message #11 received at 17204 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 17204 <at> debbugs.gnu.org
Subject: bug#17204: [PATCH] grep: speed-up for exact matching with begline and
 endline constraints
Date: Wed, 09 Apr 2014 22:58:35 +0900

[Message part 1 (text/plain, inline)]

I rebased this patch.  I also changed some variables into `bool'.

[patch.txt (text/plain, attachment)]

Message #14 received at 17204 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 17204 <at> debbugs.gnu.org
Subject: bug#17204: [PATCH] grep: speed-up for exact matching with begline and
 endline constraints
Date: Wed, 09 Apr 2014 23:31:33 +0900

[Message part 1 (text/plain, inline)]

I rebased this patch.  I also changed some variables into `bool'.

[patch.txt (text/plain, attachment)]

Message #17 received at 17204 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 17204 <at> debbugs.gnu.org
Subject: bug#17204: [PATCH] grep: speed-up for exact matching with begline and
 endline constraints
Date: Sat, 12 Apr 2014 09:13:00 +0900

[Message part 1 (text/plain, inline)]

I rebased this patch because of confliction in src/kwsearch.c.

[patch.txt (text/plain, attachment)]

Message #20 received at 17204 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 17204 <at> debbugs.gnu.org
Subject: bug#17204: [PATCH] grep: speed-up for exact matching with begline and
 endline constraints
Date: Sat, 19 Apr 2014 00:02:33 +0900

[Message part 1 (text/plain, inline)]

I rebased this patch because of confliction.

[patch.txt (text/plain, attachment)]

Message #23 received at 17204 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 17204 <at> debbugs.gnu.org
Subject: bug#17204: [PATCH] grep: speed-up for exact matching with begline and
 endline constraints
Date: Sun, 20 Apr 2014 09:57:26 +0900

[Message part 1 (text/plain, inline)]

Norihiro Tanaka wrote:
> I rebased this patch because of confliction.

I fixed the degration in rebase.

[patch.txt (text/plain, attachment)]

Message #28 received at 17204-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 17204-done <at> debbugs.gnu.org
Subject: Re: bug#17204: [PATCH] grep: speed-up for exact matching with begline
 and endline constraints
Date: Mon, 21 Apr 2014 07:58:43 -0700

[Message part 1 (text/plain, inline)]

Thanks, I looked at that, got derailed by finding and fixing a bug with 
NUL bytes that turned out to be a pre-existing bug, and finally 
installed it just now, with a slightly-reworded commit message.  I also 
installed the attached minor-improvement patch as well (some of it 
cleans up preexisting code in the neighborhood).

[0001-dfa-minor-improvements-to-previous-patch.patch (text/plain, attachment)]

Message #31 received at 17204 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: 17204 <at> debbugs.gnu.org, Paul Eggert <eggert <at> cs.ucla.edu>, 
 Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 17204-done <at> debbugs.gnu.org
Subject: Re: bug#17204: [PATCH] grep: speed-up for exact matching with begline
 and endline constraints
Date: Mon, 21 Apr 2014 11:43:07 -0700

On Mon, Apr 21, 2014 at 7:58 AM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
> Thanks, I looked at that, got derailed by finding and fixing a bug with NUL
> bytes that turned out to be a pre-existing bug, and finally installed it
> just now, with a slightly-reworded commit message.  I also installed the
> attached minor-improvement patch as well (some of it cleans up preexisting
> code in the neighborhood).

Thanks yet again, to both of you for all the work.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.