GNU bug report logs - #17203
[PATCH] grep: speed-up of DFA by checking multibyte characters on demand

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17203 in the body.
You can then email your comments to 17203 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] grep: speed-up of DFA by checking multibyte characters on
 demand
Date: Sun, 06 Apr 2014 18:52:17 +0900

[Message part 1 (text/plain, inline)]

If dfaexec() runs in non-UTF8 locales, length and wide character
representation are checked for all characters of a line in a input
string.  However, if matched early in the line, results for remaining
characters are wasted.

This patch checks multibyte characters on demand.  It enables to
accomplish to speed-up for matched early and reduce required memories.

Norihiro

[patch.txt (text/plain, attachment)]

Message #8 received at 17203 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 17203 <at> debbugs.gnu.org
Subject: bug#17203: [PATCH] grep: speed-up of DFA by checking multibyte
 characters on demand
Date: Tue, 08 Apr 2014 22:27:13 +0900

[Message part 1 (text/plain, inline)]

Now, I rebased this patch.

[patch.txt (text/plain, attachment)]

Message #11 received at 17203 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 17203 <at> debbugs.gnu.org
Subject: bug#17203: [PATCH] grep: speed-up of DFA by checking multibyte
 characters on demand
Date: Wed, 09 Apr 2014 22:58:34 +0900

[Message part 1 (text/plain, inline)]

Now, I rebased this patch.

[patch.txt (text/plain, attachment)]

Message #16 received at 17203-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 17203-done <at> debbugs.gnu.org
Subject: Re: bug#17203: [PATCH] grep: speed-up of DFA by checking multibyte
 characters on demand
Date: Thu, 17 Apr 2014 23:30:21 -0700

[Message part 1 (text/plain, inline)]

Thanks.  It's nice to see the code get smaller and simpler.  I rebased 
that patch again and tweaked the commit message (attachment 1), and 
followed up with a minor fixup patch to remove a now-unused macro and 
reindent to fit into 80 columns (attachment 2.)

[0001-dfa-speed-up-by-checking-multibyte-characters-on-dem.patch (text/plain, attachment)]

[0002-dfa-minor-cleanup.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.