GNU bug report logs - #16143
24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkbox

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#16143: closed (24.3.50; [PATCH] eww: fixed wrong key bind to
 eww-toggle-checkbox)
Date: Sat, 21 Dec 2013 20:50:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 21 Dec 2013 15:50:39 -0500
with message-id <878uvec4io.fsf <at> flea.lifelogs.com>
and subject line Re: bug#16143: 24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkboxx
has caused the debbugs.gnu.org bug report #16143,
regarding 24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkbox
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
16143: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16143
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkbox
Date: Sat, 14 Dec 2013 21:35:06 +0900

Keybind of the toggle-checkbox with space key is wrong.
I am sorry If I'm wrong. The key bind [space] can not work in my
environment.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

        * net/eww.el (eww-checkbox-map): fixed wrong key bind to eww-toggle-checkbox

---
 lisp/net/eww.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 34c6728..a6447f2 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -563,7 +563,7 @@ appears in a <link> or <a> tag."

 (defvar eww-checkbox-map
   (let ((map (make-sparse-keymap)))
-    (define-key map [space] 'eww-toggle-checkbox)
+    (define-key map " " 'eww-toggle-checkbox)
     (define-key map "\r" 'eww-toggle-checkbox)
     (define-key map [(control c) (control c)] 'eww-submit)
     map))
-- 
1.8.3.1

[Message part 3 (message/rfc822, inline)]

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: 16143-done <at> debbugs.gnu.org
Subject: Re: bug#16143: 24.3.50;
 [PATCH] eww: fixed wrong key bind to eww-toggle-checkboxx
Date: Sat, 21 Dec 2013 15:50:39 -0500

On Sun, 15 Dec 2013 01:22:07 +0900 Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> wrote: 

KN> I resend my patch with a fixed comment.
KN> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

KN>         * net/eww.el (eww-checkbox-map): Fix wrong key bind to eww-toggle-checkbox.

Applied, thank you.

Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.