GNU bug report logs - #16143
24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkbox

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16143 in the body.
You can then email your comments to 16143 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkbox
Date: Sat, 14 Dec 2013 21:35:06 +0900

Keybind of the toggle-checkbox with space key is wrong.
I am sorry If I'm wrong. The key bind [space] can not work in my
environment.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

        * net/eww.el (eww-checkbox-map): fixed wrong key bind to eww-toggle-checkbox

---
 lisp/net/eww.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 34c6728..a6447f2 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -563,7 +563,7 @@ appears in a <link> or <a> tag."

 (defvar eww-checkbox-map
   (let ((map (make-sparse-keymap)))
-    (define-key map [space] 'eww-toggle-checkbox)
+    (define-key map " " 'eww-toggle-checkbox)
     (define-key map "\r" 'eww-toggle-checkbox)
     (define-key map [(control c) (control c)] 'eww-submit)
     map))
-- 
1.8.3.1

Message #8 received at 16143 <at> debbugs.gnu.org (full text, mbox):

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: 16143 <at> debbugs.gnu.org
Subject: Re: bug#16143: 24.3.50;
 [PATCH] eww: fixed wrong key bind to eww-toggle-checkboxx
Date: Sun, 15 Dec 2013 01:22:07 +0900

I resend my patch with a fixed comment.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

        * net/eww.el (eww-checkbox-map): Fix wrong key bind to eww-toggle-checkbox.

---
 lisp/net/eww.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 34c6728..a6447f2 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -563,7 +563,7 @@ appears in a <link> or <a> tag."

 (defvar eww-checkbox-map
   (let ((map (make-sparse-keymap)))
-    (define-key map [space] 'eww-toggle-checkbox)
+    (define-key map " " 'eww-toggle-checkbox)
     (define-key map "\r" 'eww-toggle-checkbox)
     (define-key map [(control c) (control c)] 'eww-submit)
     map))
-- 
1.8.3.1

Message #13 received at 16143-done <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: 16143-done <at> debbugs.gnu.org
Subject: Re: bug#16143: 24.3.50;
 [PATCH] eww: fixed wrong key bind to eww-toggle-checkboxx
Date: Sat, 21 Dec 2013 15:50:39 -0500

On Sun, 15 Dec 2013 01:22:07 +0900 Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> wrote: 

KN> I resend my patch with a fixed comment.
KN> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

KN>         * net/eww.el (eww-checkbox-map): Fix wrong key bind to eww-toggle-checkbox.

Applied, thank you.

Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.