GNU bug report logs - #16142
24.3.50; [PATCH] eww: Delete keymap to eww-submit with Enter in the text field.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16142 in the body.
You can then email your comments to 16142 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50;
 [PATCH] eww: Delete keymap to eww-submit with Enter in the text field.
Date: Sat, 14 Dec 2013 21:15:47 +0900

The key map to eww-submit with Enter key in the text field should be
deleted. It is easy to mistake.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

        * net/eww.el (eww-text-map): Delete keymap to eww-submit with
          Enter in the text field.

---
 lisp/net/eww.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 34c6728..011d3fb 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -571,7 +571,6 @@ appears in a <link> or <a> tag."
 (defvar eww-text-map
   (let ((map (make-keymap)))
     (set-keymap-parent map text-mode-map)
-    (define-key map "\r" 'eww-submit)
     (define-key map [(control a)] 'eww-beginning-of-text)
     (define-key map [(control c) (control c)] 'eww-submit)
     (define-key map [(control e)] 'eww-end-of-text)
-- 
1.8.3.1

Kenjiro

Message #8 received at 16142 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 16142 <at> debbugs.gnu.org
Subject: Re: bug#16142: 24.3.50;
 [PATCH] eww: Delete keymap to eww-submit with Enter in the text field.
Date: Sat, 21 Dec 2013 15:44:06 -0500

On Sat, 14 Dec 2013 21:15:47 +0900 Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> wrote: 

KN> The key map to eww-submit with Enter key in the text field should be
KN> deleted. It is easy to mistake.

I'm not sure, leaving for Lars to decide.

Ted

Message #11 received at 16142 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: 16142 <at> debbugs.gnu.org
Subject: Re: bug#16142: 24.3.50;
 [PATCH] eww: Delete keymap to eww-submit with Enter in the text field.
Date: Tue, 24 Dec 2013 08:28:33 +0100

Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> writes:

> The key map to eww-submit with Enter key in the text field should be
> deleted. It is easy to mistake.

It's how all other web browsers work, and is necessary for using the web
at all.  It's common now to eschew submit buttons.  So rejected.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #20 received at 16142 <at> debbugs.gnu.org (full text, mbox):

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>, 16142 <at> debbugs.gnu.org
Subject: Re: bug#16142: 24.3.50;
 [PATCH] eww: Delete keymap to eww-submit with Enter in the text field.
Date: Wed, 25 Dec 2013 19:37:25 +0900

> It's how all other web browsers work, and is necessary for using the web
> at all.  It's common now to eschew submit buttons.  So rejected.

You are right, it was my mistake. But it is the problem that users can't
distiguish input text from textarea, like following HTML.

 <form method="POST" action="./dummy.php">
 <input type="text" name="example1" size="10">
 <p>
 <textarea name="example1" rows="1"></textarea>
 </form>

I think eww should change the color to distinguish. I send new patch,
please reconsider and review it.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

        * net/eww.el(eww-form-textarea): New defface for textarea.
        (eww-tag-textarea): Apply textarea color.

---
 lisp/net/eww.el | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 02c93a0..576778c 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -115,6 +115,14 @@ See also `eww-form-checkbox-selected-symbol'."
   :version "24.4"
   :group 'eww)
 
+(defface eww-form-textarea
+  '((t (:background "#C0C0C0"
+		    :foreground "black"
+		    :box (:line-width 1))))
+  "Face for eww text inputs."
+  :version "24.4"
+  :group 'eww)
+
 (defvar eww-current-url nil)
 (defvar eww-current-dom nil)
 (defvar eww-current-source nil)
@@ -776,7 +784,7 @@ See URL `https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input'.")
 	(when (> pad 0)
 	  (insert (make-string pad ? ))))
       (add-face-text-property (line-beginning-position)
-			      (point) 'eww-form-text)
+			      (point) 'eww-form-textarea)
       (put-text-property (line-beginning-position) (point)
 			 'local-map eww-textarea-map)
       (forward-line 1))
-- 
1.8.3.1

Regards,

Kenjiro


larsi <at> gnus.org writes:

> Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> writes:
>
>> The key map to eww-submit with Enter key in the text field should be
>> deleted. It is easy to mistake.
>
> It's how all other web browsers work, and is necessary for using the web
> at all.  It's common now to eschew submit buttons.  So rejected.

Message #23 received at 16142 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: 16142 <at> debbugs.gnu.org
Subject: Re: bug#16142: 24.3.50;
 [PATCH] eww: Delete keymap to eww-submit with Enter in the text field.
Date: Wed, 25 Dec 2013 16:33:39 +0100

Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> writes:

> You are right, it was my mistake. But it is the problem that users can't
> distiguish input text from textarea, like following HTML.

Makes sense.  Applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.