GNU bug report logs - #16141
24.3.50; [PATCH] eww: added text-property to jump to next select field.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16141 in the body.
You can then email your comments to 16141 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nakayama Kenjiro <nakayamakenjiro <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50;
 [PATCH] eww: added text-property to jump to next select field.
Date: Sat, 14 Dec 2013 21:05:40 +0900

It is useful, if we can jump to next select fiedld with tab commadn.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

        * net/eww.el (eww-tag-select): added text-property to jump to
          next select field.

---
 lisp/net/eww.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 1693e74..0264174 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -841,7 +841,8 @@ See URL
`https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input'.")
       (put-text-property start (point) 'eww-form menu)
       (add-face-text-property start (point) 'eww-form-select)
       (put-text-property start (point) 'keymap eww-select-map)
-      (put-text-property start (1+ start) 'help-echo "select field")
+      (unless (= start (point))
+       (put-text-property start (1+ start) 'help-echo "select field"))
       (shr-ensure-paragraph))))

 (defun eww-select-display (select)
-- 
1.8.3.1


Kenjiro

Message #8 received at 16141 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Nakayama Kenjiro <nakayamakenjiro <at> gmail.com>
Cc: 16141 <at> debbugs.gnu.org
Subject: Re: bug#16141: 24.3.50;
 [PATCH] eww: added text-property to jump to next select field.
Date: Sat, 14 Dec 2013 09:22:50 -0500

> It is useful, if we can jump to next select fiedld with tab commadn.
> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

Thank you for your patch.  I'll let the EWW maintainers decide what to
do with it, but I just wanted to point out:

>         * net/eww.el (eww-tag-select): added text-property to jump to
>           next select field.

Such comments should describe what the change *does* rather than what it
*did*, i.e. use the present tense (and capitalize the word after the
colon since it starts a sentence).


        Stefan

Message #11 received at 16141 <at> debbugs.gnu.org (full text, mbox):

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Nakayama Kenjiro <nakayamakenjiro <at> gmail.com>, 16141 <at> debbugs.gnu.org
Subject: Re: bug#16141: 24.3.50;
 [PATCH] eww: added text-property to jump to next select field.
Date: Sun, 15 Dec 2013 01:18:54 +0900

> Such comments should describe what the change *does* rather than what it
> *did*, i.e. use the present tense (and capitalize the word after the
> colon since it starts a sentence).

Thank you Stefan.

I resend patch with a fixed comment.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

        * net/eww.el (eww-tag-select): Add text-property to jump to
          next select field.

---
 lisp/net/eww.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 1693e74..0264174 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -841,7 +841,8 @@ See URL
`https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input[1]'.")
       (put-text-property start (point) 'eww-form menu)
       (add-face-text-property start (point) 'eww-form-select)
       (put-text-property start (point) 'keymap eww-select-map)
-      (put-text-property start (1+ start) 'help-echo "select field")
+      (unless (= start (point))
+       (put-text-property start (1+ start) 'help-echo "select field"))
       (shr-ensure-paragraph))))

 (defun eww-select-display (select)
-- 
1.8.3.1



monnier <at> IRO.UMontreal.CA writes:

>> It is useful, if we can jump to next select fiedld with tab commadn.
>> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
>
> Thank you for your patch.  I'll let the EWW maintainers decide what to
> do with it, but I just wanted to point out:
>
>>         * net/eww.el (eww-tag-select): added text-property to jump to
>>           next select field.
>
> Such comments should describe what the change *does* rather than what it
> *did*, i.e. use the present tense (and capitalize the word after the
> colon since it starts a sentence).
>
>
>         Stefan

Message #14 received at 16141 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>,
 Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 16141 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: Re: bug#16141: 24.3.50;
 [PATCH] eww: added text-property to jump to next select field.
Date: Sat, 21 Dec 2013 15:48:28 -0500

On Sun, 15 Dec 2013 01:18:54 +0900 Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> wrote: 

>> Such comments should describe what the change *does* rather than what it
>> *did*, i.e. use the present tense (and capitalize the word after the
>> colon since it starts a sentence).

KN> Thank you Stefan.

KN> I resend patch with a fixed comment.

KN> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

KN>         * net/eww.el (eww-tag-select): Add text-property to jump to
KN>           next select field.

It doesn't apply cleanly anymore, sorry.  Can you rebase and resend?

Thanks
Ted

Message #17 received at 16141 <at> debbugs.gnu.org (full text, mbox):

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>,
 Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>, 16141 <at> debbugs.gnu.org,
 Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: Re: bug#16141: 24.3.50;
 [PATCH] eww: added text-property to jump to next select field.
Date: Sun, 22 Dec 2013 10:56:53 +0900

> It doesn't apply cleanly anymore, sorry.  Can you rebase and resend?

Sorry, it's my mistake. This is proper patch.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

        * net/eww.el (eww-tag-select): Add text-property to jump to
          next select field.

---
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 15bb2c0..cd59380 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -847,6 +847,8 @@ See URL `https://developer.mozilla.org/en-US/docs/Web/HTML/Element/
       (put-text-property start (point) 'eww-form menu)
       (add-face-text-property start (point) 'eww-form-select)
       (put-text-property start (point) 'keymap eww-select-map)
+      (unless (= start (point))
+       (put-text-property start (1+ start) 'help-echo "select field"))
       (shr-ensure-paragraph))))

 (defun eww-select-display (select)

--

Kenjiro NAKAYAMA

tzz <at> lifelogs.com writes:

> On Sun, 15 Dec 2013 01:18:54 +0900 Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> wrote: 
>
>>> Such comments should describe what the change *does* rather than what it
>>> *did*, i.e. use the present tense (and capitalize the word after the
>>> colon since it starts a sentence).
>
> KN> Thank you Stefan.
>
> KN> I resend patch with a fixed comment.
>
> KN> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
>
> KN>         * net/eww.el (eww-tag-select): Add text-property to jump to
> KN>           next select field.
>
> It doesn't apply cleanly anymore, sorry.  Can you rebase and resend?
>
> Thanks
> Ted

Message #22 received at 16141-done <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 16141-done <at> debbugs.gnu.org
Subject: Re: bug#16141: 24.3.50;
 [PATCH] eww: added text-property to jump to next select field.
Date: Sun, 22 Dec 2013 17:41:09 -0500

On Sun, 22 Dec 2013 10:56:53 +0900 Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> wrote: 

>> It doesn't apply cleanly anymore, sorry.  Can you rebase and resend?
KN> Sorry, it's my mistake. This is proper patch.

KN> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

KN>         * net/eww.el (eww-tag-select): Add text-property to jump to
KN>           next select field.

Applied, thank you.

Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.