GNU bug report logs - #16141
24.3.50; [PATCH] eww: added text-property to jump to next select field.

Previous Next

Package: emacs;

Reported by: Nakayama Kenjiro <nakayamakenjiro <at> gmail.com>

Date: Sat, 14 Dec 2013 12:06:01 UTC

Severity: wishlist

Tags: patch

Found in version 24.3.50

Done: Ted Zlatanov <tzz <at> lifelogs.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Nakayama Kenjiro <nakayamakenjiro <at> gmail.com>
Cc: 16141 <at> debbugs.gnu.org
Subject: bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field.
Date: Sat, 14 Dec 2013 09:22:50 -0500

> It is useful, if we can jump to next select fiedld with tab commadn.
> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

Thank you for your patch.  I'll let the EWW maintainers decide what to
do with it, but I just wanted to point out:

>         * net/eww.el (eww-tag-select): added text-property to jump to
>           next select field.

Such comments should describe what the change *does* rather than what it
*did*, i.e. use the present tense (and capitalize the word after the
colon since it starts a sentence).


        Stefan
This bug report was last modified 11 years and 153 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.