GNU bug report logs - #16141
24.3.50; [PATCH] eww: added text-property to jump to next select field.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#16141: closed (24.3.50; [PATCH] eww: added text-property to
 jump to next select field.)
Date: Sun, 22 Dec 2013 22:40:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 22 Dec 2013 17:41:09 -0500
with message-id <87ob48bjay.fsf <at> flea.lifelogs.com>
and subject line Re: bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field.
has caused the debbugs.gnu.org bug report #16141,
regarding 24.3.50; [PATCH] eww: added text-property to jump to next select field.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
16141: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16141
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nakayama Kenjiro <nakayamakenjiro <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50;
 [PATCH] eww: added text-property to jump to next select field.
Date: Sat, 14 Dec 2013 21:05:40 +0900

It is useful, if we can jump to next select fiedld with tab commadn.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

        * net/eww.el (eww-tag-select): added text-property to jump to
          next select field.

---
 lisp/net/eww.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 1693e74..0264174 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -841,7 +841,8 @@ See URL
`https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input'.")
       (put-text-property start (point) 'eww-form menu)
       (add-face-text-property start (point) 'eww-form-select)
       (put-text-property start (point) 'keymap eww-select-map)
-      (put-text-property start (1+ start) 'help-echo "select field")
+      (unless (= start (point))
+       (put-text-property start (1+ start) 'help-echo "select field"))
       (shr-ensure-paragraph))))

 (defun eww-select-display (select)
-- 
1.8.3.1


Kenjiro

[Message part 3 (message/rfc822, inline)]

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 16141-done <at> debbugs.gnu.org
Subject: Re: bug#16141: 24.3.50;
 [PATCH] eww: added text-property to jump to next select field.
Date: Sun, 22 Dec 2013 17:41:09 -0500

On Sun, 22 Dec 2013 10:56:53 +0900 Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> wrote: 

>> It doesn't apply cleanly anymore, sorry.  Can you rebase and resend?
KN> Sorry, it's my mistake. This is proper patch.

KN> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

KN>         * net/eww.el (eww-tag-select): Add text-property to jump to
KN>           next select field.

Applied, thank you.

Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.