GNU bug report logs - #16141
24.3.50; [PATCH] eww: added text-property to jump to next select field.

Previous Next

Full log

Message #17 received at 16141 <at> debbugs.gnu.org (full text, mbox):

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>,
 Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>, 16141 <at> debbugs.gnu.org,
 Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: Re: bug#16141: 24.3.50;
 [PATCH] eww: added text-property to jump to next select field.
Date: Sun, 22 Dec 2013 10:56:53 +0900

> It doesn't apply cleanly anymore, sorry.  Can you rebase and resend?

Sorry, it's my mistake. This is proper patch.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

        * net/eww.el (eww-tag-select): Add text-property to jump to
          next select field.

---
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 15bb2c0..cd59380 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -847,6 +847,8 @@ See URL `https://developer.mozilla.org/en-US/docs/Web/HTML/Element/
       (put-text-property start (point) 'eww-form menu)
       (add-face-text-property start (point) 'eww-form-select)
       (put-text-property start (point) 'keymap eww-select-map)
+      (unless (= start (point))
+       (put-text-property start (1+ start) 'help-echo "select field"))
       (shr-ensure-paragraph))))

 (defun eww-select-display (select)

--

Kenjiro NAKAYAMA

tzz <at> lifelogs.com writes:

> On Sun, 15 Dec 2013 01:18:54 +0900 Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> wrote: 
>
>>> Such comments should describe what the change *does* rather than what it
>>> *did*, i.e. use the present tense (and capitalize the word after the
>>> colon since it starts a sentence).
>
> KN> Thank you Stefan.
>
> KN> I resend patch with a fixed comment.
>
> KN> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
>
> KN>         * net/eww.el (eww-tag-select): Add text-property to jump to
> KN>           next select field.
>
> It doesn't apply cleanly anymore, sorry.  Can you rebase and resend?
>
> Thanks
> Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.