GNU bug report logs - #16141
24.3.50; [PATCH] eww: added text-property to jump to next select field.

Previous Next

Full log

Message #14 received at 16141 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>,
 Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 16141 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: Re: bug#16141: 24.3.50;
 [PATCH] eww: added text-property to jump to next select field.
Date: Sat, 21 Dec 2013 15:48:28 -0500

On Sun, 15 Dec 2013 01:18:54 +0900 Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> wrote: 

>> Such comments should describe what the change *does* rather than what it
>> *did*, i.e. use the present tense (and capitalize the word after the
>> colon since it starts a sentence).

KN> Thank you Stefan.

KN> I resend patch with a fixed comment.

KN> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

KN>         * net/eww.el (eww-tag-select): Add text-property to jump to
KN>           next select field.

It doesn't apply cleanly anymore, sorry.  Can you rebase and resend?

Thanks
Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.