GNU bug report logs - #15708
[PATCH 6/8] EWW: Erase old title.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15708 in the body.
You can then email your comments to 15708 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
To: bug-gnu-emacs <at> gnu.org
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Subject: [PATCH 6/8] EWW: Erase old title.
Date: Fri, 25 Oct 2013 01:44:11 +0200

* lisp/net/eww.el (eww-render): Set `eww-current-title' back to "".

Signed-off-by: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
---
 lisp/net/eww.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 6335bd8..55a3177 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -192,6 +192,7 @@ (defun eww-render (status url &optional point)
 	   (t
 	    (eww-display-raw)))
 	  (setq eww-current-url url
+                eww-current-title ""
 		eww-history-position 0)
 	  (eww-update-header-line-format)
 	  (cond
-- 
1.8.4.1

Message #10 received at 15708 <at> debbugs.gnu.org (full text, mbox):

From: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
To: bug-gnu-emacs <at> gnu.org
Cc: 15708 <at> debbugs.gnu.org, Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#15708: [PATCH 6/8] EWW: Erase old title.
Date: Sat, 26 Oct 2013 03:17:34 +0200

Sorry, I messed up this patch during merge.  The title should of course be 
reset before rendering the HTML.  I'll resend the patch.

Regards,
Rüdiger

On Friday 25 October 2013 01:44:11 Rüdiger Sonderfeld wrote:
> * lisp/net/eww.el (eww-render): Set `eww-current-title' back to "".
> 
> Signed-off-by: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
> ---
>  lisp/net/eww.el | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> index 6335bd8..55a3177 100644
> --- a/lisp/net/eww.el
> +++ b/lisp/net/eww.el
> @@ -192,6 +192,7 @@ (defun eww-render (status url &optional point)
>  	   (t
>  	    (eww-display-raw)))
>  	  (setq eww-current-url url
> +                eww-current-title ""
>  		eww-history-position 0)
>  	  (eww-update-header-line-format)
>  	  (cond

Message #16 received at 15708 <at> debbugs.gnu.org (full text, mbox):

From: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
To: bug-gnu-emacs <at> gnu.org
Cc: 15708 <at> debbugs.gnu.org, Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Subject: [PATCH] EWW: Erase old title.
Date: Sat, 26 Oct 2013 13:04:31 +0200

* lisp/net/eww.el (eww-render): Set `eww-current-title' back to "".

Signed-off-by: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
---
 lisp/net/eww.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 6335bd8..e264606 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -180,6 +180,7 @@ (defun eww-render (status url &optional point)
 	 (data-buffer (current-buffer)))
     (unwind-protect
 	(progn
+          (setq eww-current-title "")
 	  (cond
            ((and eww-use-external-browser-for-content-type
                  (string-match-p eww-use-external-browser-for-content-type
-- 
1.8.4.1

Message #22 received at 15708 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
Cc: 15708 <at> debbugs.gnu.org, 15710 <at> debbugs.gnu.org
Subject: Re: bug#15710: [PATCH 8/8] * lisp/net/shr.el: Fix typo.
Date: Sun, 01 Dec 2013 16:36:16 +0100

Rüdiger Sonderfeld <ruediger <at> c-plusplus.de> writes:

> -		;; hader + body + footer
> +		;; header + body + footer

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #25 received at 15708 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
Cc: 15708 <at> debbugs.gnu.org, 15704 <at> debbugs.gnu.org
Subject: Re: bug#15704: [PATCH 2/8] EWW: Handle HTML5 input types as text
 input.
Date: Sun, 01 Dec 2013 16:38:59 +0100

Rüdiger Sonderfeld <ruediger <at> c-plusplus.de> writes:

> * lisp/net/eww.el (eww-text-input-types): New const.
>   (eww-process-text-input): Treat input types in
>   `eww-text-input-types' as text.

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #28 received at 15708 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
Cc: 15708 <at> debbugs.gnu.org, 15707 <at> debbugs.gnu.org
Subject: Re: bug#15707: [PATCH 5/8] EWW: Option to always use external-browser
 for certain content.
Date: Sun, 01 Dec 2013 16:44:41 +0100

Rüdiger Sonderfeld <ruediger <at> c-plusplus.de> writes:

> Emacs can not display videos and has only limited audio support.
> Therefore it makes sense to call an external browser for links of that
> kind.  This is also a problem because shr turns <video> and <audio>
> tags into links to the media.
>
> * lisp/net/eww.el (eww-use-external-browser-for-content-type): New
>   customizable variable.
>   (eww-render): Handle `eww-use-external-browser-for-content-type'.
>   Use \\` to match beginning of string instead of ^.
>   (eww-browse-with-external-browser): Provide optional URL parameter.

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #31 received at 15708 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
Cc: 15708 <at> debbugs.gnu.org, 15706 <at> debbugs.gnu.org
Subject: Re: bug#15706: [PATCH 4/8] shr: Add support for <audio> tag.
Date: Sun, 01 Dec 2013 16:46:04 +0100

Rüdiger Sonderfeld <ruediger <at> c-plusplus.de> writes:

> * lisp/net/shr.el (shr-tag-audio): New function.

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #34 received at 15708 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
Cc: 15708 <at> debbugs.gnu.org, 15705 <at> debbugs.gnu.org
Subject: Re: bug#15705: [PATCH 3/8] shr: Display content for video if no
 poster is available.
Date: Sun, 01 Dec 2013 16:46:14 +0100

Rüdiger Sonderfeld <ruediger <at> c-plusplus.de> writes:

> * lisp/net/shr.el (shr-tag-video): If poster is nil display a default
>   value instead.

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #37 received at 15708 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
Cc: 15708 <at> debbugs.gnu.org
Subject: Re: bug#15708: [PATCH 6/8] EWW: Erase old title.
Date: Sun, 01 Dec 2013 16:47:53 +0100

Rüdiger Sonderfeld <ruediger <at> c-plusplus.de> writes:

> * lisp/net/eww.el (eww-render): Set `eww-current-title' back to "".

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #40 received at 15708 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
Cc: 15703 <at> debbugs.gnu.org, 15708 <at> debbugs.gnu.org
Subject: Re: bug#15703: [PATCH 1/8] EWW: Support user defined representation
 for checkbox.
Date: Sun, 01 Dec 2013 16:53:20 +0100

Rüdiger Sonderfeld <ruediger <at> c-plusplus.de> writes:

> Unicode provides BALLOT BOX* symbols to represent check boxes.
>
> * lisp/net/eww.el (eww-form-checkbox-selected-symbol): New
>   customizable variable.
>   (eww-form-checkbox-symbol): New customizable variable.
>   (eww-form-checkbox): Use `eww-form-checkbox-selected-symbol' and
>   `eww-form-checkbox-symbol'.
>   (eww-toggle-checkbox): Use `eww-form-checkbox-selected-symbol' and
>   `eww-form-checkbox-symbol'.

Thanks; applied.

Having a more general mechanism for specifying alternate symbols work be
nice, but since Emacs doesn't have that yet, this is OK, I think.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.