GNU bug report logs - #15705
[PATCH 3/8] shr: Display content for video if no poster is available.

Previous Next

Package: emacs;

Reported by: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>

Date: Thu, 24 Oct 2013 23:45:01 UTC

Severity: normal

Tags: fixed, patch

Merged with 15702, 15703, 15704, 15706, 15707, 15708, 15709, 15710

Fixed in version 24.4

Done: Lars Magne Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15705 in the body.
You can then email your comments to 15705 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#15705; Package emacs. (Thu, 24 Oct 2013 23:45:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 24 Oct 2013 23:45:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
To: bug-gnu-emacs <at> gnu.org
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Subject: [PATCH 3/8] shr: Display content for video if no poster is available.
Date: Fri, 25 Oct 2013 01:43:39 +0200

* lisp/net/shr.el (shr-tag-video): If poster is nil display a default
  value instead.

Signed-off-by: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
---
 lisp/net/shr.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index b742172..39e0470 100644
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -1101,7 +1101,9 @@ (defun shr-tag-video (cont)
   (let ((image (cdr (assq :poster cont)))
 	(url (cdr (assq :src cont)))
 	(start (point)))
-    (shr-tag-img nil image)
+    (if image
+        (shr-tag-img nil image)
+      (shr-insert " [video] "))
     (shr-urlify start (shr-expand-url url))))
 
 (defun shr-tag-img (cont &optional url)
-- 
1.8.4.1
Merged 15702 15703 15704 15705 15706 15707 15708 15709 15710. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Thu, 24 Oct 2013 23:55:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#15705; Package emacs. (Sun, 01 Dec 2013 15:47:02 GMT) Full text and rfc822 format available.

Message #10 received at 15705 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
Cc: 15708 <at> debbugs.gnu.org, 15705 <at> debbugs.gnu.org
Subject: Re: bug#15705: [PATCH 3/8] shr: Display content for video if no
 poster is available.
Date: Sun, 01 Dec 2013 16:46:14 +0100

Rüdiger Sonderfeld <ruediger <at> c-plusplus.de> writes:

> * lisp/net/shr.el (shr-tag-video): If poster is nil display a default
>   value instead.

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Magne Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 01 Dec 2013 15:54:08 GMT) Full text and rfc822 format available.
bug marked as fixed in version 24.4, send any further explanations to 15708 <at> debbugs.gnu.org and Rüdiger Sonderfeld <ruediger <at> c-plusplus.de> Request was from Lars Magne Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 01 Dec 2013 15:54:11 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 30 Dec 2013 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 11 years and 230 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.