GNU bug report logs - #14994
24.3; gnus-completing-read in smime.el fails to complete

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#14994: closed (24.3; gnus-completing-read in smime.el fails
 to complete)
Date: Thu, 01 Aug 2013 00:13:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 01 Aug 2013 09:12:19 +0900
with message-id <b4mtxjas1zw.fsf <at> jpl.org>
and subject line Re: bug#14994: 24.3; gnus-completing-read in smime.el fails to complete
has caused the debbugs.gnu.org bug report #14994,
regarding 24.3; gnus-completing-read in smime.el fails to complete
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
14994: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14994
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jens Lechtenboerger <lechten <at> wi.uni-muenster.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; gnus-completing-read in smime.el fails to complete
Date: Wed, 31 Jul 2013 11:48:13 +0200

Hi there,

the calls to gnus-completing-read in smime-sign-buffer and
smime-decrypt-buffer do not provide completion support.

If I change gnus-completing-read-function from
gnus-emacs-completing-read to completing-read, everything works:

(setq gnus-completing-read-function 'completing-read)

A related problem is reported there:
https://bugs.launchpad.net/ubuntu/+source/emacs24/+bug/1096449

Best wishes
Jens

[Message part 3 (message/rfc822, inline)]

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Jens Lechtenboerger <lechten <at> wi.uni-muenster.de>
Cc: 14994-done <at> debbugs.gnu.org
Subject: Re: bug#14994: 24.3;
 gnus-completing-read in smime.el fails to complete
Date: Thu, 01 Aug 2013 09:12:19 +0900

[Message part 4 (text/plain, inline)]

Jens Lechtenboerger wrote:
> Hi there,

> the calls to gnus-completing-read in smime-sign-buffer and
> smime-decrypt-buffer do not provide completion support.

> If I change gnus-completing-read-function from
> gnus-emacs-completing-read to completing-read, everything works:

> (setq gnus-completing-read-function 'completing-read)

> A related problem is reported there:
> https://bugs.launchpad.net/ubuntu/+source/emacs24/+bug/1096449

> Best wishes
> Jens

This has been fixed at 2013-05-01 (bug#14304), so it will work
properly in the forthcoming Emacs 24.4.  Here's a patch for 24.3:

[Message part 5 (text/x-patch, inline)]

--- gnus-util.el~	2013-01-01 20:37:17.000000000 +0000
+++ gnus-util.el	2013-08-01 00:10:19.897216100 +0000
@@ -1531,9 +1531,12 @@
   "Call standard `completing-read-function'."
   (let ((completion-styles gnus-completion-styles))
     (completing-read prompt
-                     ;; Old XEmacs (at least 21.4) expect an alist for
-                     ;; collection.
-                     (mapcar 'list collection)
+                     ;; Old XEmacs (at least 21.4) expect an alist,
+		     ;; in which the car of each element is a string,
+		     ;; for collection.
+                     (mapcar (lambda (elem)
+			       (list (format "%s" (or (car-safe elem) elem))))
+			     collection)
                      nil require-match initial-input history def)))
 
 (autoload 'ido-completing-read "ido")

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.