GNU bug report logs - #14994
24.3; gnus-completing-read in smime.el fails to complete

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14994 in the body.
You can then email your comments to 14994 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jens Lechtenboerger <lechten <at> wi.uni-muenster.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; gnus-completing-read in smime.el fails to complete
Date: Wed, 31 Jul 2013 11:48:13 +0200

Hi there,

the calls to gnus-completing-read in smime-sign-buffer and
smime-decrypt-buffer do not provide completion support.

If I change gnus-completing-read-function from
gnus-emacs-completing-read to completing-read, everything works:

(setq gnus-completing-read-function 'completing-read)

A related problem is reported there:
https://bugs.launchpad.net/ubuntu/+source/emacs24/+bug/1096449

Best wishes
Jens

Message #10 received at 14994-done <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Jens Lechtenboerger <lechten <at> wi.uni-muenster.de>
Cc: 14994-done <at> debbugs.gnu.org
Subject: Re: bug#14994: 24.3;
 gnus-completing-read in smime.el fails to complete
Date: Thu, 01 Aug 2013 09:12:19 +0900

[Message part 1 (text/plain, inline)]

Jens Lechtenboerger wrote:
> Hi there,

> the calls to gnus-completing-read in smime-sign-buffer and
> smime-decrypt-buffer do not provide completion support.

> If I change gnus-completing-read-function from
> gnus-emacs-completing-read to completing-read, everything works:

> (setq gnus-completing-read-function 'completing-read)

> A related problem is reported there:
> https://bugs.launchpad.net/ubuntu/+source/emacs24/+bug/1096449

> Best wishes
> Jens

This has been fixed at 2013-05-01 (bug#14304), so it will work
properly in the forthcoming Emacs 24.4.  Here's a patch for 24.3:

[Message part 2 (text/x-patch, inline)]

--- gnus-util.el~	2013-01-01 20:37:17.000000000 +0000
+++ gnus-util.el	2013-08-01 00:10:19.897216100 +0000
@@ -1531,9 +1531,12 @@
   "Call standard `completing-read-function'."
   (let ((completion-styles gnus-completion-styles))
     (completing-read prompt
-                     ;; Old XEmacs (at least 21.4) expect an alist for
-                     ;; collection.
-                     (mapcar 'list collection)
+                     ;; Old XEmacs (at least 21.4) expect an alist,
+		     ;; in which the car of each element is a string,
+		     ;; for collection.
+                     (mapcar (lambda (elem)
+			       (list (format "%s" (or (car-safe elem) elem))))
+			     collection)
                      nil require-match initial-input history def)))
 
 (autoload 'ido-completing-read "ido")

Message #13 received at 14994 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 14994 <at> debbugs.gnu.org
Cc: lechten <at> wi.uni-muenster.de, yamaoka <at> jpl.org
Subject: Re: bug#14994: 24.3;
 gnus-completing-read in smime.el fails to complete
Date: Wed, 31 Jul 2013 22:30:13 -0400

> +                     ;; Old XEmacs (at least 21.4) expect an alist,
> +		     ;; in which the car of each element is a string,
> +		     ;; for collection.
> +                     (mapcar (lambda (elem)
> +			       (list (format "%s" (or (car-safe elem) elem))))
> +			     collection)
>                       nil require-match initial-input history def)))
 
I recommend you wrap this in an (if (featurep 'xemacs) ...) so as to
avoid using this code when it's not needed.  After all, it looks both
inefficient and hackish.


        Stefan

Message #16 received at 14994 <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: lechten <at> wi.uni-muenster.de, 14994 <at> debbugs.gnu.org
Subject: Re: bug#14994: 24.3;
 gnus-completing-read in smime.el fails to complete
Date: Thu, 01 Aug 2013 12:51:53 +0900

Stefan Monnier wrote:
>> +                     ;; Old XEmacs (at least 21.4) expect an alist,
>> +		     ;; in which the car of each element is a string,
>> +		     ;; for collection.
>> +                     (mapcar (lambda (elem)
>> +			       (list (format "%s" (or (car-safe elem) elem))))
>> +			     collection)
>>                       nil require-match initial-input history def)))

> I recommend you wrap this in an (if (featurep 'xemacs) ...) so as to
> avoid using this code when it's not needed.  After all, it looks both
> inefficient and hackish.

Indeed.  I've simply isolated it as an XEmacs stuff.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.