GNU bug report logs - #14995
[PATCH] vc-do-command ignores symbolic links

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14995 in the body.
You can then email your comments to 14995 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xue Fuqiao <xfq.free <at> gmail.com>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] vc-do-command ignores symbolic links
Date: Wed, 31 Jul 2013 18:53:42 +0800

tags patch

This small patch fixes a bug in vc-do-command:

=== modified file 'lisp/vc/vc-dispatcher.el'
--- lisp/vc/vc-dispatcher.el    2013-06-15 02:50:47 +0000
+++ lisp/vc/vc-dispatcher.el    2013-07-31 10:49:27 +0000
@@ -275,11 +275,8 @@
 that is inserted into the command line before the filename.
 Return the return value of the slave command in the synchronous
 case, and the process object in the asynchronous case."
-  ;; FIXME: file-relative-name can return a bogus result because
-  ;; it doesn't look at the actual file-system to see if symlinks
-  ;; come into play.
   (let* ((files
-      (mapcar (lambda (f) (file-relative-name (expand-file-name f)))
+      (mapcar (lambda (f) (file-relative-name (file-truename
(expand-file-name f))))
           (if (listp file-or-list) file-or-list (list file-or-list))))
      (full-command
       ;; What we're doing here is preparing a version of the command


-- 
Best regards, Xue Fuqiao.
http://www.gnu.org/software/emacs/

Message #8 received at 14995 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Xue Fuqiao <xfq.free <at> gmail.com>
Cc: 14995 <at> debbugs.gnu.org
Subject: Re: bug#14995: [PATCH] vc-do-command ignores symbolic links
Date: Wed, 31 Jul 2013 10:13:23 -0400

> This small patch fixes a bug in vc-do-command:

> === modified file 'lisp/vc/vc-dispatcher.el'
> --- lisp/vc/vc-dispatcher.el    2013-06-15 02:50:47 +0000
> +++ lisp/vc/vc-dispatcher.el    2013-07-31 10:49:27 +0000
> @@ -275,11 +275,8 @@
>  that is inserted into the command line before the filename.
>  Return the return value of the slave command in the synchronous
>  case, and the process object in the asynchronous case."
> -  ;; FIXME: file-relative-name can return a bogus result because
> -  ;; it doesn't look at the actual file-system to see if symlinks
> -  ;; come into play.
>    (let* ((files
> -      (mapcar (lambda (f) (file-relative-name (expand-file-name f)))
> +      (mapcar (lambda (f) (file-relative-name (file-truename
> (expand-file-name f))))
>            (if (listp file-or-list) file-or-list (list file-or-list))))
>       (full-command
>        ;; What we're doing here is preparing a version of the command

I'm not completely sure this fix is needed (and I'd rather avoid
calling file-truename, if possible).  Do you have a concrete case where
this causes problems?


        Stefan

Message #11 received at 14995 <at> debbugs.gnu.org (full text, mbox):

From: Xue Fuqiao <xfq.free <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 14995 <at> debbugs.gnu.org
Subject: Re: bug#14995: [PATCH] vc-do-command ignores symbolic links
Date: Thu, 1 Aug 2013 06:38:57 +0800

On Wed, Jul 31, 2013 at 10:13 PM, Stefan Monnier
<monnier <at> iro.umontreal.ca> wrote:
>> This small patch fixes a bug in vc-do-command:
>
>> === modified file 'lisp/vc/vc-dispatcher.el'
>> --- lisp/vc/vc-dispatcher.el    2013-06-15 02:50:47 +0000
>> +++ lisp/vc/vc-dispatcher.el    2013-07-31 10:49:27 +0000
>> @@ -275,11 +275,8 @@
>>  that is inserted into the command line before the filename.
>>  Return the return value of the slave command in the synchronous
>>  case, and the process object in the asynchronous case."
>> -  ;; FIXME: file-relative-name can return a bogus result because
>> -  ;; it doesn't look at the actual file-system to see if symlinks
>> -  ;; come into play.
>>    (let* ((files
>> -      (mapcar (lambda (f) (file-relative-name (expand-file-name f)))
>> +      (mapcar (lambda (f) (file-relative-name (file-truename
>> (expand-file-name f))))
>>            (if (listp file-or-list) file-or-list (list file-or-list))))
>>       (full-command
>>        ;; What we're doing here is preparing a version of the command
>
> I'm not completely sure this fix is needed (and I'd rather avoid
> calling file-truename, if possible).  Do you have a concrete case where
> this causes problems?

No.  I made this patch in passing when I was reading vc-dispatcher.

-- 
Best regards, Xue Fuqiao.
http://www.gnu.org/software/emacs/

Message #14 received at 14995 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Xue Fuqiao <xfq.free <at> gmail.com>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 14995 <at> debbugs.gnu.org
Subject: Re: bug#14995: [PATCH] vc-do-command ignores symbolic links
Date: Wed, 05 Feb 2014 17:00:26 -0800

Xue Fuqiao <xfq.free <at> gmail.com> writes:

>> I'm not completely sure this fix is needed (and I'd rather avoid
>> calling file-truename, if possible).  Do you have a concrete case where
>> this causes problems?
>
> No.  I made this patch in passing when I was reading vc-dispatcher.

Then I guess this can be closed.  If there is a bug here, please reopen
this report.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.