GNU bug report logs - #1241
patch: thingatpt.el syntactic sugar (cont.)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Chong Yidong <cyd <at> stupidchicken.com>
Subject: bug#1241: marked as done (patch: thingatpt.el syntactic sugar 
 (cont.))

[Message part 1 (text/plain, inline)]

Your message dated Fri, 24 Oct 2008 20:14:07 -0400
with message-id <87iqrhleeo.fsf <at> cyd.mit.edu>
and subject line Re: patch: thingatpt.el syntactic sugar (cont.)
has caused the Emacs bug report #1241,
regarding patch: thingatpt.el syntactic sugar (cont.)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don <at> donarmstrong.com
immediately.)


-- 
1241: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=1241
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Aaron S. Hawley" <aaronh <at> garden.org>
To: bug-gnu-emacs <at> gnu.org
Subject: patch: thingatpt.el syntactic sugar (cont.)
Date: Fri, 24 Oct 2008 13:54:49 -0400

[Message part 3 (text/plain, inline)]

I posted this patch last year, but I don't think anybody picked it up.

http://lists.gnu.org/archive/html/bug-gnu-emacs/2007-10/msg00091.html

An updated version of the patch is attached and in-line below.
/a


Index: thingatpt.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/thingatpt.el,v
retrieving revision 1.47
diff -u -r1.47 thingatpt.el
--- thingatpt.el	22 Oct 2008 20:51:23 -0000	1.47
+++ thingatpt.el	24 Oct 2008 17:50:47 -0000
@@ -169,19 +169,19 @@
       (nth 3 (parse-partial-sexp (point) orig)))))

 (defun end-of-sexp ()
-  (let ((char-syntax (char-syntax (char-after (point)))))
+  (let ((char-syntax (char-syntax (char-after))))
     (if (or (eq char-syntax ?\))
-	    (and (eq char-syntax ?\") (in-string-p)))
-	(forward-char 1)
+           (and (eq char-syntax ?\") (in-string-p)))
+       (forward-char 1)
       (forward-sexp 1))))

 (put 'sexp 'end-op 'end-of-sexp)

 (defun beginning-of-sexp ()
-  (let ((char-syntax (char-syntax (char-before (point)))))
+  (let ((char-syntax (char-syntax (char-before))))
     (if (or (eq char-syntax ?\()
-	    (and (eq char-syntax ?\") (in-string-p)))
-	(forward-char -1)
+           (and (eq char-syntax ?\") (in-string-p)))
+       (forward-char -1)
       (forward-sexp -1))))

 (put 'sexp 'beginning-op 'beginning-of-sexp)
@@ -405,10 +405,10 @@
   (interactive "p")
   (while (< arg 0)
     (skip-syntax-backward
-     (char-to-string (char-syntax (char-after (1- (point))))))
+     (char-to-string (char-syntax (char-before))))
     (setq arg (1+ arg)))
   (while (> arg 0)
-    (skip-syntax-forward (char-to-string (char-syntax (char-after 
(point)))))
+    (skip-syntax-forward (char-to-string (char-syntax (char-after))))
     (setq arg (1- arg))))

 ;;  Aliases

[thingatpt.el.diff (text/plain, inline)]

Index: thingatpt.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/thingatpt.el,v
retrieving revision 1.47
diff -u -r1.47 thingatpt.el
--- thingatpt.el	22 Oct 2008 20:51:23 -0000	1.47
+++ thingatpt.el	24 Oct 2008 17:50:47 -0000
@@ -169,19 +169,19 @@
       (nth 3 (parse-partial-sexp (point) orig)))))
 
 (defun end-of-sexp ()
-  (let ((char-syntax (char-syntax (char-after (point)))))
+  (let ((char-syntax (char-syntax (char-after))))
     (if (or (eq char-syntax ?\))
-	    (and (eq char-syntax ?\") (in-string-p)))
-	(forward-char 1)
+           (and (eq char-syntax ?\") (in-string-p)))
+       (forward-char 1)
       (forward-sexp 1))))
 
 (put 'sexp 'end-op 'end-of-sexp)
 
 (defun beginning-of-sexp ()
-  (let ((char-syntax (char-syntax (char-before (point)))))
+  (let ((char-syntax (char-syntax (char-before))))
     (if (or (eq char-syntax ?\()
-	    (and (eq char-syntax ?\") (in-string-p)))
-	(forward-char -1)
+           (and (eq char-syntax ?\") (in-string-p)))
+       (forward-char -1)
       (forward-sexp -1))))
 
 (put 'sexp 'beginning-op 'beginning-of-sexp)
@@ -405,10 +405,10 @@
   (interactive "p")
   (while (< arg 0)
     (skip-syntax-backward
-     (char-to-string (char-syntax (char-after (1- (point))))))
+     (char-to-string (char-syntax (char-before))))
     (setq arg (1+ arg)))
   (while (> arg 0)
-    (skip-syntax-forward (char-to-string (char-syntax (char-after (point)))))
+    (skip-syntax-forward (char-to-string (char-syntax (char-after))))
     (setq arg (1- arg))))
 
 ;;  Aliases

[Message part 5 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> stupidchicken.com>
To: "Aaron S. Hawley" <aaronh <at> garden.org>
Cc: 1241-done <at> debbugs.gnu.org
Subject: Re: patch: thingatpt.el syntactic sugar (cont.)
Date: Fri, 24 Oct 2008 20:14:07 -0400

> I posted this patch last year, but I don't think anybody picked it up.

I applied it.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.