GNU bug report logs - #1241
patch: thingatpt.el syntactic sugar (cont.)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1241 in the body.
You can then email your comments to 1241 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Aaron S. Hawley" <aaronh <at> garden.org>
To: bug-gnu-emacs <at> gnu.org
Subject: patch: thingatpt.el syntactic sugar (cont.)
Date: Fri, 24 Oct 2008 13:54:49 -0400

[Message part 1 (text/plain, inline)]

I posted this patch last year, but I don't think anybody picked it up.

http://lists.gnu.org/archive/html/bug-gnu-emacs/2007-10/msg00091.html

An updated version of the patch is attached and in-line below.
/a


Index: thingatpt.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/thingatpt.el,v
retrieving revision 1.47
diff -u -r1.47 thingatpt.el
--- thingatpt.el	22 Oct 2008 20:51:23 -0000	1.47
+++ thingatpt.el	24 Oct 2008 17:50:47 -0000
@@ -169,19 +169,19 @@
       (nth 3 (parse-partial-sexp (point) orig)))))

 (defun end-of-sexp ()
-  (let ((char-syntax (char-syntax (char-after (point)))))
+  (let ((char-syntax (char-syntax (char-after))))
     (if (or (eq char-syntax ?\))
-	    (and (eq char-syntax ?\") (in-string-p)))
-	(forward-char 1)
+           (and (eq char-syntax ?\") (in-string-p)))
+       (forward-char 1)
       (forward-sexp 1))))

 (put 'sexp 'end-op 'end-of-sexp)

 (defun beginning-of-sexp ()
-  (let ((char-syntax (char-syntax (char-before (point)))))
+  (let ((char-syntax (char-syntax (char-before))))
     (if (or (eq char-syntax ?\()
-	    (and (eq char-syntax ?\") (in-string-p)))
-	(forward-char -1)
+           (and (eq char-syntax ?\") (in-string-p)))
+       (forward-char -1)
       (forward-sexp -1))))

 (put 'sexp 'beginning-op 'beginning-of-sexp)
@@ -405,10 +405,10 @@
   (interactive "p")
   (while (< arg 0)
     (skip-syntax-backward
-     (char-to-string (char-syntax (char-after (1- (point))))))
+     (char-to-string (char-syntax (char-before))))
     (setq arg (1+ arg)))
   (while (> arg 0)
-    (skip-syntax-forward (char-to-string (char-syntax (char-after 
(point)))))
+    (skip-syntax-forward (char-to-string (char-syntax (char-after))))
     (setq arg (1- arg))))

 ;;  Aliases

[thingatpt.el.diff (text/plain, inline)]

Index: thingatpt.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/thingatpt.el,v
retrieving revision 1.47
diff -u -r1.47 thingatpt.el
--- thingatpt.el	22 Oct 2008 20:51:23 -0000	1.47
+++ thingatpt.el	24 Oct 2008 17:50:47 -0000
@@ -169,19 +169,19 @@
       (nth 3 (parse-partial-sexp (point) orig)))))
 
 (defun end-of-sexp ()
-  (let ((char-syntax (char-syntax (char-after (point)))))
+  (let ((char-syntax (char-syntax (char-after))))
     (if (or (eq char-syntax ?\))
-	    (and (eq char-syntax ?\") (in-string-p)))
-	(forward-char 1)
+           (and (eq char-syntax ?\") (in-string-p)))
+       (forward-char 1)
       (forward-sexp 1))))
 
 (put 'sexp 'end-op 'end-of-sexp)
 
 (defun beginning-of-sexp ()
-  (let ((char-syntax (char-syntax (char-before (point)))))
+  (let ((char-syntax (char-syntax (char-before))))
     (if (or (eq char-syntax ?\()
-	    (and (eq char-syntax ?\") (in-string-p)))
-	(forward-char -1)
+           (and (eq char-syntax ?\") (in-string-p)))
+       (forward-char -1)
       (forward-sexp -1))))
 
 (put 'sexp 'beginning-op 'beginning-of-sexp)
@@ -405,10 +405,10 @@
   (interactive "p")
   (while (< arg 0)
     (skip-syntax-backward
-     (char-to-string (char-syntax (char-after (1- (point))))))
+     (char-to-string (char-syntax (char-before))))
     (setq arg (1+ arg)))
   (while (> arg 0)
-    (skip-syntax-forward (char-to-string (char-syntax (char-after (point)))))
+    (skip-syntax-forward (char-to-string (char-syntax (char-after))))
     (setq arg (1- arg))))
 
 ;;  Aliases

Message #10 received at 1241-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: "Aaron S. Hawley" <aaronh <at> garden.org>
Cc: 1241-done <at> debbugs.gnu.org
Subject: Re: patch: thingatpt.el syntactic sugar (cont.)
Date: Fri, 24 Oct 2008 20:14:07 -0400

> I posted this patch last year, but I don't think anybody picked it up.

I applied it.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.