GNU bug report logs - #1239
PATCH: Fix corner case of texinfo-insert-quote

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1239 in the body.
You can then email your comments to 1239 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Aaron S. Hawley" <aaronh <at> garden.org>
To: bug-gnu-emacs <at> gnu.org
Subject: PATCH: Fix corner case of texinfo-insert-quote
Date: Fri, 24 Oct 2008 13:40:46 -0400

[Message part 1 (text/plain, inline)]

Patch is attached and in-line.  It would be nice to have this, in case 
one tries to do quotation mark manipulation with with-temp-buffer.

Thanks for Emacs,
/a

Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.14668
diff -u -r1.14668 ChangeLog
--- ChangeLog	24 Oct 2008 09:39:28 -0000	1.14668
+++ ChangeLog	24 Oct 2008 17:29:37 -0000
@@ -1,3 +1,8 @@
+2008-10-24  Aaron S. Hawley  <aaronh <at> garden.org>
+
+	* textmodes/texinfo.el (texinfo-insert-quote): Handle corner
+	 case where point is at the beginning of the buffer.
+
 2008-10-24  Juanma Barranquero  <lekktu <at> gmail.com>

 	* subr.el (locate-user-emacs-file): New function.
Index: textmodes/texinfo.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/textmodes/texinfo.el,v
retrieving revision 1.122
diff -u -r1.122 texinfo.el
--- textmodes/texinfo.el	6 May 2008 04:33:13 -0000	1.122
+++ textmodes/texinfo.el	24 Oct 2008 17:29:37 -0000
@@ -682,7 +682,9 @@
     (if (or arg
 	    (= (preceding-char) ?\\)
 	    (save-excursion
-	      (backward-char (length texinfo-open-quote))
+	      (if (> (point) (length texinfo-open-quote))
+		  (backward-char (length texinfo-open-quote))
+		(goto-char (point-min)))
 	      (when (or (looking-at texinfo-open-quote)
 			(looking-at texinfo-close-quote))
 		(delete-char (length texinfo-open-quote))
@@ -694,7 +696,8 @@
 		    (setq in-env t)))))
 	(self-insert-command (prefix-numeric-value arg))
       (insert
-       (if (memq (char-syntax (preceding-char)) '(?\( ?> ?\s))
+       (if (or (bobp) ;; (eq (preceding-char) 0)
+	       (memq (char-syntax (preceding-char)) '(?\( ?> ?\s)))
 	   texinfo-open-quote
 	 texinfo-close-quote)))))

[texinfo.el-bobp.diff (text/plain, inline)]

Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.14668
diff -u -r1.14668 ChangeLog
--- ChangeLog	24 Oct 2008 09:39:28 -0000	1.14668
+++ ChangeLog	24 Oct 2008 17:29:37 -0000
@@ -1,3 +1,8 @@
+2008-10-24  Aaron S. Hawley  <aaronh <at> garden.org>
+
+	* textmodes/texinfo.el (texinfo-insert-quote): Handle corner
+	 case where point is at the beginning of the buffer.
+
 2008-10-24  Juanma Barranquero  <lekktu <at> gmail.com>
 
 	* subr.el (locate-user-emacs-file): New function.
Index: textmodes/texinfo.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/textmodes/texinfo.el,v
retrieving revision 1.122
diff -u -r1.122 texinfo.el
--- textmodes/texinfo.el	6 May 2008 04:33:13 -0000	1.122
+++ textmodes/texinfo.el	24 Oct 2008 17:29:37 -0000
@@ -682,7 +682,9 @@
     (if (or arg
 	    (= (preceding-char) ?\\)
 	    (save-excursion
-	      (backward-char (length texinfo-open-quote))
+	      (if (> (point) (length texinfo-open-quote))
+		  (backward-char (length texinfo-open-quote))
+		(goto-char (point-min)))
 	      (when (or (looking-at texinfo-open-quote)
 			(looking-at texinfo-close-quote))
 		(delete-char (length texinfo-open-quote))
@@ -694,7 +696,8 @@
 		    (setq in-env t)))))
 	(self-insert-command (prefix-numeric-value arg))
       (insert
-       (if (memq (char-syntax (preceding-char)) '(?\( ?> ?\s))
+       (if (or (bobp) ;; (eq (preceding-char) 0)
+	       (memq (char-syntax (preceding-char)) '(?\( ?> ?\s)))
 	   texinfo-open-quote
 	 texinfo-close-quote)))))
 

Message #12 received at 1239-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 1239-done <at> debbugs.gnu.org
Subject: Re: bug#1239: PATCH: Fix corner case of texinfo-insert-quote
Date: Mon, 01 Dec 2008 22:37:34 -0500

OK; installed.

2008-12-02  Aaron S. Hawley  <aaronh <at> garden.org>

  * textmodes/texinfo.el (texinfo-insert-quote): Handle
  corner case where point is at the beginning of the buffer.  (Bug#1239)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.