GNU bug report logs - #1233
rcirc fill-region bugfix

Previous Next

Package: emacs;

Reported by: Jeff Makey <jeff <at> sdsc.edu>

Date: Thu, 23 Oct 2008 15:20:02 UTC

Severity: normal

Tags: patch

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Jeff Makey <jeff <at> sdsc.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: bug#1233: rcirc fill-region bugfix
Date: Thu, 23 Oct 2008 08:10:27 -0700
When a message begins with a very long word (typically a URL), rcirc
in Emacs 22 inserts a useless newline like this:

08:10 <SaintNick>
                  http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
                  has this month's archives

The patch below excludes the timestamp and nick from the beginning of
the filled region, which will cause such a line to be shown in this
more compact format:

08:10 <SaintNick> http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
                  has this month's archives

 -----------------------------------------------------------------

--- rcirc.el.orig	2008-02-10 06:03:53 -0800
+++ rcirc.el	2008-10-08 23:33:57 -0700
@@ -1251,7 +1251,7 @@
 					 (rcirc-fill-column
 					  rcirc-fill-column)
 					 (t fill-column))))
-		  (fill-region fill-start rcirc-prompt-start-marker 'left t)))))
+		  (fill-region text-start rcirc-prompt-start-marker 'left t)))))
 
 	  ;; set inserted text to be read-only
 	  (when rcirc-read-only-flag





This bug report was last modified 16 years and 214 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.