GNU bug report logs - #1233
rcirc fill-region bugfix

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1233 in the body.
You can then email your comments to 1233 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Jeff Makey <jeff <at> sdsc.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: rcirc fill-region bugfix
Date: Thu, 23 Oct 2008 08:10:27 -0700

When a message begins with a very long word (typically a URL), rcirc
in Emacs 22 inserts a useless newline like this:

08:10 <SaintNick>
                  http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
                  has this month's archives

The patch below excludes the timestamp and nick from the beginning of
the filled region, which will cause such a line to be shown in this
more compact format:

08:10 <SaintNick> http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
                  has this month's archives

 -----------------------------------------------------------------

--- rcirc.el.orig	2008-02-10 06:03:53 -0800
+++ rcirc.el	2008-10-08 23:33:57 -0700
@@ -1251,7 +1251,7 @@
 					 (rcirc-fill-column
 					  rcirc-fill-column)
 					 (t fill-column))))
-		  (fill-region fill-start rcirc-prompt-start-marker 'left t)))))
+		  (fill-region text-start rcirc-prompt-start-marker 'left t)))))
 
 	  ;; set inserted text to be read-only
 	  (when rcirc-read-only-flag

Message #12 received at 1233 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Ryan Yeske  <rcyeske <at> gmail.com>
Cc: 1233 <at> debbugs.gnu.org
Subject: Re: rcirc fill-region bugfix
Date: Thu, 23 Oct 2008 18:04:50 -0400

Hi Ryan,

Could you review this patch?

Jeff Makey <jeff <at> sdsc.edu> wrote:

> When a message begins with a very long word (typically a URL), rcirc
> in Emacs 22 inserts a useless newline like this:
>
> 08:10 <SaintNick>
>                   http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
>                   has this month's archives
>
> The patch below excludes the timestamp and nick from the beginning of
> the filled region, which will cause such a line to be shown in this
> more compact format:
>
> 08:10 <SaintNick> http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
>                   has this month's archives


--- rcirc.el.orig	2008-02-10 06:03:53 -0800
+++ rcirc.el	2008-10-08 23:33:57 -0700
@@ -1251,7 +1251,7 @@
 					 (rcirc-fill-column
 					  rcirc-fill-column)
 					 (t fill-column))))
-		  (fill-region fill-start rcirc-prompt-start-marker 'left t)))))
+		  (fill-region text-start rcirc-prompt-start-marker 'left t)))))
 
 	  ;; set inserted text to be read-only
 	  (when rcirc-read-only-flag

Message #17 received at 1233 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Ryan Yeske <rcyeske <at> gmail.com>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: Ryan Yeske <rcyeske <at> gmail.com>, 1233 <at> debbugs.gnu.org
Subject: Re: rcirc fill-region bugfix
Date: Mon, 27 Oct 2008 20:06:36 -0700

Chong Yidong <cyd <at> stupidchicken.com> writes:

> Hi Ryan,
>
> Could you review this patch?

It looks good to me.  Thanks for the patch, Jeff.

The way filling is handled in the CVS trunk has been reworked, and it
includes a fix along these lines already.

Ryan



> Jeff Makey <jeff <at> sdsc.edu> wrote:
>
>> When a message begins with a very long word (typically a URL), rcirc
>> in Emacs 22 inserts a useless newline like this:
>>
>> 08:10 <SaintNick>
>>                   http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
>>                   has this month's archives
>>
>> The patch below excludes the timestamp and nick from the beginning of
>> the filled region, which will cause such a line to be shown in this
>> more compact format:
>>
>> 08:10 <SaintNick> http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
>>                   has this month's archives
>
>
> --- rcirc.el.orig	2008-02-10 06:03:53 -0800
> +++ rcirc.el	2008-10-08 23:33:57 -0700
> @@ -1251,7 +1251,7 @@
>  					 (rcirc-fill-column
>  					  rcirc-fill-column)
>  					 (t fill-column))))
> -		  (fill-region fill-start rcirc-prompt-start-marker 'left t)))))
> +		  (fill-region text-start rcirc-prompt-start-marker 'left t)))))
>  
>  	  ;; set inserted text to be read-only
>  	  (when rcirc-read-only-flag

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.