GNU bug report logs - #1236
ispell-complete-word / key binding not shown in menu

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1236 in the body.
You can then email your comments to 1236 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: David Reitter <david.reitter <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: ispell-complete-word / key binding not shown in menu
Date: Thu, 23 Oct 2008 22:31:50 -0400

[Message part 1 (text/plain, inline)]

`ispell-complete-word' appears in the Spell Checking menu and is, in  
text-mode at least, bound to M-TAB, as C-h f/k will show.  However, it  
does not have its key binding listed in the menu.

Listing the correct key bindings in the menus is important - it's  
pretty difficult for newbies to learn these things otherwise.

This occurs with the old Carbon port (22) and with a recent build of  
Cocoa (23).


Begin forwarded message:

> From: dranorter <dranorter <at> gmail.com>
> Date: 12 August 2008 10:19:33 EDT
> To: aquamacs-bugs <at> aquamacs.org
> Subject: Re: [Aquamacs-bugs] Random aquamacs impressions
>
>
>>> - Some of the menus don't have keyboard shortcuts listed.
>> Is that because the associated functions have no key bindings, or are
>> the shortcut indicators genuinely missing? (Either is possible.)
>
> I was thinking of edit > complete word, which doesn't have a
> key binding. It would have been helpful to me at the time to
> still have M-x ispell-complete-word listed but of course there
> wouldn't be room, so whatever.

[smime.p7s (application/pkcs7-signature, attachment)]

Message #8 received at 1236 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: David Reitter <david.reitter <at> gmail.com>
Cc: 1236 <at> debbugs.gnu.org
Subject: Re: bug#1236: ispell-complete-word / key binding not shown in menu
Date: Fri, 24 Oct 2008 00:18:05 -0400

reassign 1236 emacs,ns
stop

David Reitter wrote:

> `ispell-complete-word' appears in the Spell Checking menu and is, in  
> text-mode at least, bound to M-TAB, as C-h f/k will show.  However, it  
> does not have its key binding listed in the menu.

Works fine in GNU/Linux:

emacs -Q
M-x text-mode
Tools -> Spell Checking
  -> "Complete Word" has M-TAB binding displayed

M-x lisp-mode
  -> "Complete Word" has no keybinding, none displayed


> Listing the correct key bindings in the menus is important - it's  
> pretty difficult for newbies to learn these things otherwise.

Hopefully they learn about C-h k.

Message #15 received at 1236 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>
To: Glenn Morris <rgm <at> gnu.org>, 1236 <at> debbugs.gnu.org
Cc: David Reitter <david.reitter <at> gmail.com>
Subject: Re: bug#1236: ispell-complete-word / key binding not shown in menu
Date: Sat, 25 Oct 2008 17:37:51 +0900

>>>>> On Fri, 24 Oct 2008 00:18:05 -0400, Glenn Morris <rgm <at> gnu.org> said:

>> `ispell-complete-word' appears in the Spell Checking menu and is, in  
>> text-mode at least, bound to M-TAB, as C-h f/k will show.  However, it  
>> does not have its key binding listed in the menu.

> Works fine in GNU/Linux:

> emacs -Q
> M-x text-mode
> Tools -> Spell Checking
> -> "Complete Word" has M-TAB binding displayed

> M-x lisp-mode
> -> "Complete Word" has no keybinding, none displayed

Probably you tried with Emacs 23, and Emacs 22 on GNU/Linux would
behave as OP described.  I think the following change made the
difference.

2008-05-16  Stefan Monnier  <monnier <at> iro.umontreal.ca>

	* keyboard.c (parse_menu_item): Do not cache key shortcut any more.

				     YAMAMOTO Mitsuharu
				mituharu <at> math.s.chiba-u.ac.jp

Message #18 received at 1236 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>
Cc: 1236 <at> debbugs.gnu.org, David Reitter <david.reitter <at> gmail.com>
Subject: Re: bug#1236: ispell-complete-word / key binding not shown in menu
Date: Sat, 25 Oct 2008 14:45:52 -0400

YAMAMOTO Mitsuharu wrote:

> Probably you tried with Emacs 23, and Emacs 22 on GNU/Linux would
> behave as OP described.

I did indeed, since Emacs 22 is dead, and the problem was also said to
occur with "a recent build of Cocoa (23)". Does it? (I can't build that.)

Message #23 received at 1236 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: David Reitter <david.reitter <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>,
        1236 <at> debbugs.gnu.org
Subject: Re: bug#1236: ispell-complete-word / key binding not shown in menu
Date: Sat, 25 Oct 2008 17:27:37 -0400

[Message part 1 (text/plain, inline)]

On 25 Oct 2008, at 14:45, Glenn Morris wrote:

> YAMAMOTO Mitsuharu wrote:
>
>> Probably you tried with Emacs 23, and Emacs 22 on GNU/Linux would
>> behave as OP described.
>
> I did indeed, since Emacs 22 is dead, and the problem was also said to
> occur with "a recent build of Cocoa (23)". Does it? (I can't build  
> that.)

In general: given that there are tens if not hundreds of thousands of  
users out there on Emacs 22, with stopping to fix bugs we're not doing  
ourselves a favor.

Applying Stefan's patch (which just turns off this cache) causes a  
crash while building (before dumping), which I don't have the chance  
to investigate further.

Indeed, the key hint problem occurred with 23 as well, so perhaps we  
should fix it on that end first.

[smime.p7s (application/pkcs7-signature, attachment)]

Message #28 received at 1236 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 1236 <at> debbugs.gnu.org, David Reitter <david.reitter <at> gmail.com>
Subject: Re: bug#1236: ispell-complete-word / key binding not shown in menu
Date: Sun, 26 Oct 2008 13:18:52 +0900

>>>>> On Sat, 25 Oct 2008 14:45:52 -0400, Glenn Morris <rgm <at> gnu.org> said:

>> Probably you tried with Emacs 23, and Emacs 22 on GNU/Linux would
>> behave as OP described.

> I did indeed, since Emacs 22 is dead, and the problem was also said
> to occur with "a recent build of Cocoa (23)". Does it? (I can't
> build that.)

Menus in the Cocoa/GNUstep port doesn't show key bindings as in other
platforms (at least by default) in the first place.

				     YAMAMOTO Mitsuharu
				mituharu <at> math.s.chiba-u.ac.jp

Message #33 received at 1236 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: David Reitter <david.reitter <at> gmail.com>
To: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>,
        Adrian Robert <adrian.b.robert <at> gmail.com>
Cc: Glenn Morris <rgm <at> gnu.org>, 1236 <at> debbugs.gnu.org
Subject: Re: bug#1236: ispell-complete-word / key binding not shown in menu
Date: Sun, 26 Oct 2008 09:56:15 -0400

[Message part 1 (text/plain, inline)]

On 26 Oct 2008, at 00:18, YAMAMOTO Mitsuharu wrote:

>>>>>> On Sat, 25 Oct 2008 14:45:52 -0400, Glenn Morris <rgm <at> gnu.org>  
>>>>>> said:
>
>>> Probably you tried with Emacs 23, and Emacs 22 on GNU/Linux would
>>> behave as OP described.
>
>> I did indeed, since Emacs 22 is dead, and the problem was also said
>> to occur with "a recent build of Cocoa (23)". Does it? (I can't
>> build that.)
>
> Menus in the Cocoa/GNUstep port doesn't show key bindings as in other
> platforms (at least by default) in the first place.


Using the 23 code that turns off caching of key binding hints does fix  
the problem in 22 Carbon Emacs.

23 Cocoa has a different problem with key bindings.  No key binding is  
displayed here:

(defun foo () (interactive))
(global-set-key "\M-p" 'foo)
(define-key menu-bar-file-menu [new-file]
  '(menu-item "Foo!"
	      foo))
(ns-reset-menu) ;; doesn't help

[smime.p7s (application/pkcs7-signature, attachment)]

Message #38 received at 1236-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Adrian Robert <adrian.b.robert <at> gmail.com>
To: 1236-done <at> debbugs.gnu.org
Subject: Re: ispell-complete-word / key binding not shown in menu
Date: Thu, 22 Jan 2009 14:26:27 +0200

Fixed 2009/01/22 with changes to nsmenu.m: EmacsMenu.  Non-super  
keybindings are displayed as strings appended in parentheses, as in  
"Visit New File... (C-x C-f)".  This is ugly, however it seems that  
NSMenuItem will not accept multi-character strings for  
keyEquivalent.  If anyone can improve upon / work around this  
situation please go ahead.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.