GNU bug report logs - #1233
rcirc fill-region bugfix

Previous Next

Full log

Message #12 received at 1233 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Ryan Yeske  <rcyeske <at> gmail.com>
Cc: 1233 <at> debbugs.gnu.org
Subject: Re: rcirc fill-region bugfix
Date: Thu, 23 Oct 2008 18:04:50 -0400

Hi Ryan,

Could you review this patch?

Jeff Makey <jeff <at> sdsc.edu> wrote:

> When a message begins with a very long word (typically a URL), rcirc
> in Emacs 22 inserts a useless newline like this:
>
> 08:10 <SaintNick>
>                   http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
>                   has this month's archives
>
> The patch below excludes the timestamp and nick from the beginning of
> the filled region, which will cause such a line to be shown in this
> more compact format:
>
> 08:10 <SaintNick> http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
>                   has this month's archives


--- rcirc.el.orig	2008-02-10 06:03:53 -0800
+++ rcirc.el	2008-10-08 23:33:57 -0700
@@ -1251,7 +1251,7 @@
 					 (rcirc-fill-column
 					  rcirc-fill-column)
 					 (t fill-column))))
-		  (fill-region fill-start rcirc-prompt-start-marker 'left t)))))
+		  (fill-region text-start rcirc-prompt-start-marker 'left t)))))
 
 	  ;; set inserted text to be read-only
 	  (when rcirc-read-only-flag

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.