GNU bug report logs - #9803
Add ERT option to skip test

Previous Next

Full log

Message #33 received at 9803 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Glenn Morris <rgm <at> gnu.org>, 9803 <at> debbugs.gnu.org
Subject: Re: bug#9803: [PATCH] Add ERT option to skip test
Date: Mon, 21 Oct 2013 12:53:14 -0400

> Well, I've made a change to call (fset 'skip-if 'ert--skip-if) in
> ert--run-test-internal. After running the test, it is reverted by
> (unintern 'skip-if nil).

Yuck!

> Therefore, `skip-if' is visible only inside tests defined with
> `ert-deftest'.

Not "inside" but "during".  I.e. it can still affect any code run during
the tests.

> If this is acceptable, I could apply this change also for
> `should', `should-not' and `should-error'.

No, better leave them as always-global.

> I've tried to change it as proposed by Stefan, but I'm too stupid to
> manage all this sophisticated cl-* stuff :-(

What have you tried and how did it fail?


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.